All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] MIPS: dbau1x00: Disable compilation of flash driver stub
Date: Thu, 3 Feb 2011 13:14:29 +0100	[thread overview]
Message-ID: <201102031314.29646.sr@denx.de> (raw)
In-Reply-To: <1296734392-15203-4-git-send-email-daniel.schwierzeck@googlemail.com>

Hi Daniel,

On Thursday 03 February 2011 12:59:52 daniel.schwierzeck at googlemail.com wrote:
> All dbau1x00 boards use the CFI driver so this stub driver is useless
> and should not be compiled.
> 
> This patch fixes the error:
> 
> u-boot-git/board/dbau1x00/flash.c:34: multiple definition of `flash_init'
> drivers/mtd/libmtd.o:u-boot-git/drivers/mtd/cfi_flash.c:2084: first defined
> here board/dbau1x00/libdbau1x00.o: In function `write_buff':
> u-boot-git/board/dbau1x00/flash.c:40: multiple definition of `write_buff'
> drivers/mtd/libmtd.o:u-boot-git/drivers/mtd/cfi_flash.c:1265: first defined
> here

I suggest that you not only disable the compilation of this file, but remove 
it completely.
 
Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

  reply	other threads:[~2011-02-03 12:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-03 11:59 [U-Boot] [PATCH 0/3] MIPS: Fix failed run of MAKEALL mips script daniel.schwierzeck at googlemail.com
2011-02-03 11:59 ` [U-Boot] [PATCH 1/3] MIPS: VCT: Fix enabling of unwanted options if networking or USB support are disabled daniel.schwierzeck at googlemail.com
2011-02-03 12:12   ` Stefan Roese
2011-02-03 12:31     ` Daniel Schwierzeck
2011-02-03 11:59 ` [U-Boot] [PATCH 2/3] MIPS: Purple: Fix multiple definition error on final linking of u-boot binary daniel.schwierzeck at googlemail.com
2011-02-05 12:11   ` Shinya Kuribayashi
2011-02-05 14:15     ` Wolfgang Denk
2011-02-03 11:59 ` [U-Boot] [PATCH 3/3] MIPS: dbau1x00: Disable compilation of flash driver stub daniel.schwierzeck at googlemail.com
2011-02-03 12:14   ` Stefan Roese [this message]
2011-02-03 12:36     ` Daniel Schwierzeck
2011-02-03 13:35       ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201102031314.29646.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.