All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] MIPS: Purple: Fix multiple definition error on final linking of u-boot binary
Date: Sat, 05 Feb 2011 15:15:12 +0100	[thread overview]
Message-ID: <20110205141512.8DFBD15242F@gemini.denx.de> (raw)
In-Reply-To: <4D4D3E6B.2040605@pobox.com>

Dear Shinya Kuribayashi,

In message <4D4D3E6B.2040605@pobox.com> you wrote:
>
> > --- a/board/purple/u-boot.lds
> > +++ b/board/purple/u-boot.lds
> > @@ -36,11 +36,6 @@ SECTIONS
> >  	{
> >  	  arch/mips/cpu/start.o		(.text)
> >  	  board/purple/lowlevel_init.o	(.text)
> > -	  arch/mips/cpu/cache.o		(.text)
> > -	  common/main.o			(.text)
> > -	  common/dlmalloc.o		(.text)
> > -	  common/cmd_boot.o		(.text)
> > -	  lib/zlib.o		(.text)
> >  	  . = DEFINED(env_offset) ? env_offset : .;
> >  	  common/env_embedded.o	(.ppcenv)
> 
> This is ok, though we have some room for further cealnups.  With having
> .text statement in the lowlevel_init.S, we could remove all these lines.

The prupose of explicitly pulling in these objects at that place is to
fill in the first flash sector below the sector(s) that is/are
reserved for the environment (we call this setup "embedded
environment").

But then, the Purple board has not been actively maintained for years,
and I guess we could as well remove it.  At least I have not had
access to this board for several yars.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The more complex the mind, the greater the need for the simplicity of
play.
	-- Kirk, "Shore Leave", stardate 3025.8

  reply	other threads:[~2011-02-05 14:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-03 11:59 [U-Boot] [PATCH 0/3] MIPS: Fix failed run of MAKEALL mips script daniel.schwierzeck at googlemail.com
2011-02-03 11:59 ` [U-Boot] [PATCH 1/3] MIPS: VCT: Fix enabling of unwanted options if networking or USB support are disabled daniel.schwierzeck at googlemail.com
2011-02-03 12:12   ` Stefan Roese
2011-02-03 12:31     ` Daniel Schwierzeck
2011-02-03 11:59 ` [U-Boot] [PATCH 2/3] MIPS: Purple: Fix multiple definition error on final linking of u-boot binary daniel.schwierzeck at googlemail.com
2011-02-05 12:11   ` Shinya Kuribayashi
2011-02-05 14:15     ` Wolfgang Denk [this message]
2011-02-03 11:59 ` [U-Boot] [PATCH 3/3] MIPS: dbau1x00: Disable compilation of flash driver stub daniel.schwierzeck at googlemail.com
2011-02-03 12:14   ` Stefan Roese
2011-02-03 12:36     ` Daniel Schwierzeck
2011-02-03 13:35       ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110205141512.8DFBD15242F@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.