From: Arnd Bergmann <arnd@arndb.de>
To: Meador Inge <meador_inge@mentor.com>
Cc: Hollis Blanchard <hollis_blanchard@mentor.com>,
devicetree-discuss@lists.ozlabs.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 1/3] powerpc: Removing support for 'protected-sources'
Date: Fri, 4 Feb 2011 13:17:32 +0100 [thread overview]
Message-ID: <201102041317.32739.arnd@arndb.de> (raw)
In-Reply-To: <4D4B3A4E.2070106@mentor.com>
On Friday 04 February 2011, Meador Inge wrote:
> On 02/03/2011 09:56 AM, Arnd Bergmann wrote:
> So in 'mpic_init' we don't initialize anything and then in
> 'mpic_host_map' we lazily do the VECPRI and CPU binding initialization with:
>
> if (!(mpic->flags & MPIC_WANTS_RESET))
> if (!(mpic_is_ipi(mpic, hw)
> || mpic_is_timer_interrupt(mpic, hw)))
> mpic_init_vector(mpic, hw);
>
> Thus when 'no-reset' is thrown it ensures that only the sources which
> are mentioned in the device tree are actually initialized. The net
> effect should be the same as what 'protected-sources' was accomplishing,
> but without having to maintain the list of sources in the property cell.
That sounds like a good idea, but unfortunately, it's not what SLOF
implements on QS21/QS22. It's a legacy product and there won't be
any firmware updates. Moreover, it relies on the open firmware
implementation and cannot boot with a flattened device tree image,
so I don't see how your patch can work on the old systems.
Maybe you can treat the presence of a 'protected-sources' property
the same way that you treat the no-reset property?
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Meador Inge <meador_inge-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
Cc: Hollis Blanchard
<hollis_blanchard-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Subject: Re: [PATCH v2 1/3] powerpc: Removing support for 'protected-sources'
Date: Fri, 4 Feb 2011 13:17:32 +0100 [thread overview]
Message-ID: <201102041317.32739.arnd@arndb.de> (raw)
In-Reply-To: <4D4B3A4E.2070106-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
On Friday 04 February 2011, Meador Inge wrote:
> On 02/03/2011 09:56 AM, Arnd Bergmann wrote:
> So in 'mpic_init' we don't initialize anything and then in
> 'mpic_host_map' we lazily do the VECPRI and CPU binding initialization with:
>
> if (!(mpic->flags & MPIC_WANTS_RESET))
> if (!(mpic_is_ipi(mpic, hw)
> || mpic_is_timer_interrupt(mpic, hw)))
> mpic_init_vector(mpic, hw);
>
> Thus when 'no-reset' is thrown it ensures that only the sources which
> are mentioned in the device tree are actually initialized. The net
> effect should be the same as what 'protected-sources' was accomplishing,
> but without having to maintain the list of sources in the property cell.
That sounds like a good idea, but unfortunately, it's not what SLOF
implements on QS21/QS22. It's a legacy product and there won't be
any firmware updates. Moreover, it relies on the open firmware
implementation and cannot boot with a flattened device tree image,
so I don't see how your patch can work on the old systems.
Maybe you can treat the presence of a 'protected-sources' property
the same way that you treat the no-reset property?
Arnd
next prev parent reply other threads:[~2011-02-04 12:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 1:51 [PATCH v2 0/3] powerpc: Open PIC binding and 'no-reset' implementation Meador Inge
2011-02-03 1:51 ` [PATCH v2 1/3] powerpc: Removing support for 'protected-sources' Meador Inge
2011-02-03 15:56 ` Arnd Bergmann
2011-02-03 23:29 ` Meador Inge
2011-02-03 23:29 ` Meador Inge
2011-02-04 12:17 ` Arnd Bergmann [this message]
2011-02-04 12:17 ` Arnd Bergmann
2011-02-03 1:51 ` [PATCH v2 2/3] powerpc: document the Open PIC device tree binding Meador Inge
2011-02-03 1:51 ` Meador Inge
2011-02-03 15:56 ` Grant Likely
2011-02-03 15:56 ` Grant Likely
2011-02-03 16:29 ` Meador Inge
2011-02-03 16:36 ` Grant Likely
2011-02-03 16:36 ` Grant Likely
2011-02-03 17:02 ` Yoder Stuart-B08248
2011-02-03 17:02 ` Yoder Stuart-B08248
2011-02-03 1:51 ` [PATCH v2 3/3] powerpc: make MPIC honor the 'no-reset' device tree property Meador Inge
2011-02-03 15:22 ` [PATCH v2 0/3] powerpc: Open PIC binding and 'no-reset' implementation Kumar Gala
2011-02-03 15:22 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102041317.32739.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=hollis_blanchard@mentor.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=meador_inge@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.