Re: [PATCH 02/14] POWER: bq27x00: Improve temperature precession

[Rodolfo Giometti <giometti@enneenne.com>]

On Sun, Feb 06, 2011 at 01:47:59AM +0100, Lars-Peter Clausen wrote:
> This patch improves the precession of the temperature property of the bq27x00
> driver.
> By dividing before multiplying the current code effectively cuts of the last
> decimal digit. This patch fixes it by multiplying before dividing.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
>  drivers/power/bq27x00_battery.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/power/bq27x00_battery.c b/drivers/power/bq27x00_battery.c
> index bb043f9..4f74659 100644
> --- a/drivers/power/bq27x00_battery.c
> +++ b/drivers/power/bq27x00_battery.c
> @@ -109,7 +109,7 @@ static int bq27x00_battery_temperature(struct bq27x00_device_info *di)
>  	if (di->chip == BQ27500)
>  		return temp - 2731;
>  	else
> -		return ((temp >> 2) - 273) * 10;
> +		return ((temp * 5) - 5463) / 2;
>  }
>  
>  /*
> -- 
> 1.7.2.3

Acked-by: Rodolfo Giometti <giometti@linux.it>

-- 

GNU/Linux Solutions                  e-mail: giometti@enneenne.com
Linux Device Driver                          giometti@linux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it