From: Vivek Goyal <vgoyal@redhat.com>
To: "Ahmed S. Darwish" <darwish.07@gmail.com>
Cc: linux-doc@vger.kernel.org, kexec@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>,
Haren Myneni <hbabu@us.ibm.com>,
Randy Dunlap <rdunlap@xenotime.net>,
Simon Horman <horms@verge.net.au>,
Eric Biederman <ebiederm@xmission.com>
Subject: Re: [PATCH v2 -next] Documentation: Improve crashkernel= description
Date: Mon, 7 Feb 2011 09:25:50 -0500 [thread overview]
Message-ID: <20110207142550.GA7437@redhat.com> (raw)
In-Reply-To: <20110207113054.GA10388@laptop>
On Mon, Feb 07, 2011 at 01:30:54PM +0200, Ahmed S. Darwish wrote:
>
> Had to explore two C code files to make sense of the 'crashkernel='
> kernel parameter values. Improve the situation.
>
Did you look at Documentation/kdump/kdump.txt before looking into the
code. I thought kdump.txt explained the meaning of crashkernel= well.
In case if it was not obivious that for further details look into
kdump.txt, I will suggest to add a line asking reader to look into
kdump.txt for more details.
Tough crashkernel= range1:size1[,range2:size2,...][@offset], description
in next line already mentions kdump.txt
This patch looks good to me as it is though.
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Vivek
> Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com>
> ---
>
> diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
> index 89835a4..5ad9980 100644
> --- a/Documentation/kernel-parameters.txt
> +++ b/Documentation/kernel-parameters.txt
> @@ -545,9 +545,12 @@ and is between 256 and 4096 characters. It is defined in the file
> Format:
> <first_slot>,<last_slot>,<port>,<enum_bit>[,<debug>]
>
> - crashkernel=nn[KMG]@ss[KMG]
> - [KNL] Reserve a chunk of physical memory to
> - hold a kernel to switch to with kexec on panic.
> + crashkernel=size[KMG][@offset[KMG]]
> + [KNL] Using kexec, Linux can switch to a 'crash kernel'
> + upon panic. This parameter reserves the physical
> + memory region [offset, offset + size] for that kernel
> + image. If '@offset' is omitted, then a suitable offset
> + is selected automatically.
>
> crashkernel=range1:size1[,range2:size2,...][@offset]
> [KNL] Same as above, but depends on the memory
>
> --
> Darwish
> http://darwish.07.googlepages.com
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com>
To: "Ahmed S. Darwish" <darwish.07@gmail.com>
Cc: Randy Dunlap <rdunlap@xenotime.net>,
Simon Horman <horms@verge.net.au>,
Haren Myneni <hbabu@us.ibm.com>,
Eric Biederman <ebiederm@xmission.com>,
kexec@lists.infradead.org, LKML <linux-kernel@vger.kernel.org>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v2 -next] Documentation: Improve crashkernel= description
Date: Mon, 7 Feb 2011 09:25:50 -0500 [thread overview]
Message-ID: <20110207142550.GA7437@redhat.com> (raw)
In-Reply-To: <20110207113054.GA10388@laptop>
On Mon, Feb 07, 2011 at 01:30:54PM +0200, Ahmed S. Darwish wrote:
>
> Had to explore two C code files to make sense of the 'crashkernel='
> kernel parameter values. Improve the situation.
>
Did you look at Documentation/kdump/kdump.txt before looking into the
code. I thought kdump.txt explained the meaning of crashkernel= well.
In case if it was not obivious that for further details look into
kdump.txt, I will suggest to add a line asking reader to look into
kdump.txt for more details.
Tough crashkernel= range1:size1[,range2:size2,...][@offset], description
in next line already mentions kdump.txt
This patch looks good to me as it is though.
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Vivek
> Signed-off-by: Ahmed S. Darwish <darwish.07@gmail.com>
> ---
>
> diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
> index 89835a4..5ad9980 100644
> --- a/Documentation/kernel-parameters.txt
> +++ b/Documentation/kernel-parameters.txt
> @@ -545,9 +545,12 @@ and is between 256 and 4096 characters. It is defined in the file
> Format:
> <first_slot>,<last_slot>,<port>,<enum_bit>[,<debug>]
>
> - crashkernel=nn[KMG]@ss[KMG]
> - [KNL] Reserve a chunk of physical memory to
> - hold a kernel to switch to with kexec on panic.
> + crashkernel=size[KMG][@offset[KMG]]
> + [KNL] Using kexec, Linux can switch to a 'crash kernel'
> + upon panic. This parameter reserves the physical
> + memory region [offset, offset + size] for that kernel
> + image. If '@offset' is omitted, then a suitable offset
> + is selected automatically.
>
> crashkernel=range1:size1[,range2:size2,...][@offset]
> [KNL] Same as above, but depends on the memory
>
> --
> Darwish
> http://darwish.07.googlepages.com
next prev parent reply other threads:[~2011-02-07 14:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-06 15:41 [PATCH -next] Documentation: Improve crashkernel= description Ahmed S. Darwish
2011-02-06 15:41 ` Ahmed S. Darwish
2011-02-06 21:57 ` Simon Horman
2011-02-06 21:57 ` Simon Horman
2011-02-07 2:25 ` Rob Landley
2011-02-07 2:25 ` Rob Landley
2011-02-07 2:35 ` Eric W. Biederman
2011-02-07 2:35 ` Eric W. Biederman
2011-02-07 2:42 ` Simon Horman
2011-02-07 2:42 ` Simon Horman
2011-02-07 14:33 ` Vivek Goyal
2011-02-07 14:33 ` Vivek Goyal
2011-02-07 10:59 ` WANG Cong
2011-02-07 4:14 ` Randy Dunlap
2011-02-07 4:14 ` Randy Dunlap
2011-02-07 11:30 ` [PATCH v2 " Ahmed S. Darwish
2011-02-07 11:30 ` Ahmed S. Darwish
2011-02-07 11:41 ` Simon Horman
2011-02-07 11:41 ` Simon Horman
2011-02-07 14:25 ` Vivek Goyal [this message]
2011-02-07 14:25 ` Vivek Goyal
2011-02-07 16:01 ` [PATCH v3 " Ahmed S. Darwish
2011-02-07 16:01 ` Ahmed S. Darwish
2011-02-08 18:50 ` Randy Dunlap
2011-02-08 18:50 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110207142550.GA7437@redhat.com \
--to=vgoyal@redhat.com \
--cc=darwish.07@gmail.com \
--cc=ebiederm@xmission.com \
--cc=hbabu@us.ibm.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.