From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 6/7] ASoC: Samsung: neo1973_gta02: Fix bluetooth DAI registration
Date: Mon, 7 Feb 2011 18:17:02 +0000 [thread overview]
Message-ID: <20110207181702.GR10564@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4D50355A.60500@metafoo.de>
Once more I've reflowed your text. *Please* fix this, it's really
hurting the legibility of your mail.
On Mon, Feb 07, 2011 at 07:09:30PM +0100, Lars-Peter Clausen wrote:
> On 02/07/2011 06:49 PM, Mark Brown wrote:
> > The card is only registering one DAI, all the other DAIs are attached to
> > other devices in the system.
> Isn't the card the combination of these other devices?
Well, yes...
> > The bluetooth chip is an actual device which I can point to on the
> > board and schematic, having a struct device to represent a device that's
> > actually present doesn't seem like a great leap.
> Well, there is an actual device representing the bt device, but since
> this is the standard bt usb device I have no idea how we would get an
> reference to it from within the sound board driver.
If you've got a real device and a driver binding to it then you can make
the driver for that device register the DAI from its probe function, no
need for the machine driver to get involved.
> > It does mean it's named after the board.
> Ok. Could you please explain how snd_soc_register_machine would work
> and how it would effekt the naming of the dai? I couldn't find any
> reference to it.
Sorry, snd_soc_register_card(). This skips the soc-audio device and
allows the card to be registered from a regular device, meaning you can
do things like pass platform data in sanely and handle multiple boards
in a kernel without machine_is_() faff.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/7] ASoC: Samsung: neo1973_gta02: Fix bluetooth DAI registration
Date: Mon, 7 Feb 2011 18:17:02 +0000 [thread overview]
Message-ID: <20110207181702.GR10564@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4D50355A.60500@metafoo.de>
Once more I've reflowed your text. *Please* fix this, it's really
hurting the legibility of your mail.
On Mon, Feb 07, 2011 at 07:09:30PM +0100, Lars-Peter Clausen wrote:
> On 02/07/2011 06:49 PM, Mark Brown wrote:
> > The card is only registering one DAI, all the other DAIs are attached to
> > other devices in the system.
> Isn't the card the combination of these other devices?
Well, yes...
> > The bluetooth chip is an actual device which I can point to on the
> > board and schematic, having a struct device to represent a device that's
> > actually present doesn't seem like a great leap.
> Well, there is an actual device representing the bt device, but since
> this is the standard bt usb device I have no idea how we would get an
> reference to it from within the sound board driver.
If you've got a real device and a driver binding to it then you can make
the driver for that device register the DAI from its probe function, no
need for the machine driver to get involved.
> > It does mean it's named after the board.
> Ok. Could you please explain how snd_soc_register_machine would work
> and how it would effekt the naming of the dai? I couldn't find any
> reference to it.
Sorry, snd_soc_register_card(). This skips the soc-audio device and
allows the card to be registered from a regular device, meaning you can
do things like pass platform data in sanely and handle multiple boards
in a kernel without machine_is_() faff.
next prev parent reply other threads:[~2011-02-07 18:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-06 23:04 [PATCH 1/7] ASoC: neo1973_wm8753: Remove scenario management code Lars-Peter Clausen
2011-02-06 23:04 ` [PATCH 2/7] ASoC: neo1973_wm8753: Move lm4857 specefic code to its own module Lars-Peter Clausen
2011-02-06 23:04 ` Lars-Peter Clausen
2011-02-07 11:50 ` Mark Brown
2011-02-07 11:50 ` Mark Brown
2011-02-06 23:04 ` [PATCH 3/7] ASoC: codecs: lm4857: Use dev_pm_ops Lars-Peter Clausen
2011-02-06 23:04 ` Lars-Peter Clausen
2011-02-06 23:04 ` [PATCH 4/7] ASoC: neo1973_gta02_wm8753: Remove lm4853_{set,get}_state Lars-Peter Clausen
2011-02-06 23:04 ` [PATCH 5/7] ASoC: Samsung: neo1973: Use gpio_request_array to request gpios Lars-Peter Clausen
2011-02-06 23:04 ` Lars-Peter Clausen
2011-02-06 23:04 ` [PATCH 6/7] ASoC: Samsung: neo1973_gta02: Fix bluetooth DAI registration Lars-Peter Clausen
2011-02-07 11:59 ` Mark Brown
2011-02-07 11:59 ` Mark Brown
2011-02-07 16:53 ` Lars-Peter Clausen
2011-02-07 17:02 ` Mark Brown
2011-02-07 17:37 ` Lars-Peter Clausen
2011-02-07 17:37 ` Lars-Peter Clausen
2011-02-07 17:49 ` Mark Brown
2011-02-07 17:49 ` Mark Brown
2011-02-07 18:09 ` Lars-Peter Clausen
2011-02-07 18:09 ` Lars-Peter Clausen
2011-02-07 18:17 ` Mark Brown [this message]
2011-02-07 18:17 ` Mark Brown
2011-02-07 22:55 ` Adding bluetooth PCM interface support to ASoC (Was: Re: [PATCH 6/7] ASoC: Samsung: neo1973_gta02: Fix bluetooth DAI registration) Lars-Peter Clausen
2011-02-07 22:55 ` Lars-Peter Clausen
2011-02-08 13:08 ` Mark Brown
2011-02-08 13:08 ` Mark Brown
2011-02-06 23:04 ` [PATCH 7/7] ASoC: Samsung: Merge neo1937 and neo1973_gta02 sound board driver Lars-Peter Clausen
2011-02-07 2:25 ` [alsa-devel] [PATCH 1/7] ASoC: neo1973_wm8753: Remove scenario management code Jassi Brar
2011-02-07 11:42 ` Mark Brown
2011-02-07 11:42 ` Mark Brown
2011-02-07 17:01 ` Lars-Peter Clausen
2011-02-07 17:01 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110207181702.GR10564@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.