* [PATCH] perf: fix compile error in annotate.h
@ 2011-02-08 12:20 Stephane Eranian
2011-02-08 13:51 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 4+ messages in thread
From: Stephane Eranian @ 2011-02-08 12:20 UTC (permalink / raw)
To: linux-kernel
Cc: peterz, mingo, paulus, davem, fweisbec, perfmon2-devel, eranian,
eranian, robert.richter, acme
The following patch is necessary to compile without NEWT.
Signed-off-by: Stephane Eranian <eranian@google.com>
---
diff --git a/tools/perf/util/annotate.h b/tools/perf/util/annotate.h
index b1253aa..bc08b36 100644
--- a/tools/perf/util/annotate.h
+++ b/tools/perf/util/annotate.h
@@ -82,7 +82,7 @@ int symbol__tty_annotate(struct symbol *sym, struct map *map, int evidx,
int max_lines);
#ifdef NO_NEWT_SUPPORT
-static inline int symbol__tui_annotate(symbol *sym __used,
+static inline int symbol__tui_annotate(struct symbol *sym __used,
struct map *map __used, int evidx __used)
{
return 0;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] perf: fix compile error in annotate.h
2011-02-08 12:20 [PATCH] perf: fix compile error in annotate.h Stephane Eranian
@ 2011-02-08 13:51 ` Arnaldo Carvalho de Melo
2011-02-08 15:19 ` Ingo Molnar
0 siblings, 1 reply; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2011-02-08 13:51 UTC (permalink / raw)
To: Stephane Eranian
Cc: linux-kernel, peterz, mingo, paulus, davem, fweisbec,
perfmon2-devel, eranian, robert.richter, Borislav Petkov
Em Tue, Feb 08, 2011 at 02:20:01PM +0200, Stephane Eranian escreveu:
> The following patch is necessary to compile without NEWT.
Merged already, Borislav Petkov sent a similar patch.
Thanks,
- Arnaldo
> Signed-off-by: Stephane Eranian <eranian@google.com>
> ---
>
> diff --git a/tools/perf/util/annotate.h b/tools/perf/util/annotate.h
> index b1253aa..bc08b36 100644
> --- a/tools/perf/util/annotate.h
> +++ b/tools/perf/util/annotate.h
> @@ -82,7 +82,7 @@ int symbol__tty_annotate(struct symbol *sym, struct map *map, int evidx,
> int max_lines);
>
> #ifdef NO_NEWT_SUPPORT
> -static inline int symbol__tui_annotate(symbol *sym __used,
> +static inline int symbol__tui_annotate(struct symbol *sym __used,
> struct map *map __used, int evidx __used)
> {
> return 0;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] perf: fix compile error in annotate.h
2011-02-08 13:51 ` Arnaldo Carvalho de Melo
@ 2011-02-08 15:19 ` Ingo Molnar
2011-02-08 15:47 ` Stephane Eranian
0 siblings, 1 reply; 4+ messages in thread
From: Ingo Molnar @ 2011-02-08 15:19 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo
Cc: Stephane Eranian, linux-kernel, peterz, paulus, davem, fweisbec,
perfmon2-devel, eranian, robert.richter, Borislav Petkov
* Arnaldo Carvalho de Melo <acme@redhat.com> wrote:
> Em Tue, Feb 08, 2011 at 02:20:01PM +0200, Stephane Eranian escreveu:
> > The following patch is necessary to compile without NEWT.
>
> Merged already, Borislav Petkov sent a similar patch.
I just pushed it out - Stephane, mind checking that latest -tip indeed fixes things
for you?
Thanks,
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] perf: fix compile error in annotate.h
2011-02-08 15:19 ` Ingo Molnar
@ 2011-02-08 15:47 ` Stephane Eranian
0 siblings, 0 replies; 4+ messages in thread
From: Stephane Eranian @ 2011-02-08 15:47 UTC (permalink / raw)
To: Ingo Molnar
Cc: Arnaldo Carvalho de Melo, linux-kernel, peterz, paulus, davem,
fweisbec, perfmon2-devel, eranian, robert.richter,
Borislav Petkov
On Tue, Feb 8, 2011 at 4:19 PM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Arnaldo Carvalho de Melo <acme@redhat.com> wrote:
>
>> Em Tue, Feb 08, 2011 at 02:20:01PM +0200, Stephane Eranian escreveu:
>> > The following patch is necessary to compile without NEWT.
>>
>> Merged already, Borislav Petkov sent a similar patch.
>
> I just pushed it out - Stephane, mind checking that latest -tip indeed fixes things
> for you?
>
Works for me now, thanks.
Acked-by: Stephane Eranian <eranian@google.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-02-08 15:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-08 12:20 [PATCH] perf: fix compile error in annotate.h Stephane Eranian
2011-02-08 13:51 ` Arnaldo Carvalho de Melo
2011-02-08 15:19 ` Ingo Molnar
2011-02-08 15:47 ` Stephane Eranian
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.