From: Arnd Bergmann <arnd@arndb.de>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Dave Martin <dave.martin@linaro.org>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
linux-arm-kernel@lists.infradead.org,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, Jean Pihet-XID <j-pihet@ti.com>
Subject: Re: [PATCH v2] ARM: Define wfi() macro for v6 processors
Date: Tue, 8 Feb 2011 17:58:14 +0100 [thread overview]
Message-ID: <201102081758.14606.arnd@arndb.de> (raw)
In-Reply-To: <20110208163229.GC6188@n2100.arm.linux.org.uk>
On Tuesday 08 February 2011 17:32:29 Russell King - ARM Linux wrote:
> On Tue, Feb 08, 2011 at 04:17:58PM +0100, Arnd Bergmann wrote:
> > On Tuesday 08 February 2011, Dave Martin wrote:
> > > CFLAGS_cpu_specific_object.o += -march=armv7-a
> > >
> > > Whether it's safe to do it depends on whether code from that file
> > > could ever get run on other processors. I'm not so sure of the answer
> > > to that..., but perhaps someone else has a better idea.
> >
> > We already do this a lot from arch/arm/mm/Makefile, and those
> > files are typically just one function per file, so they can easily
> > be proven to be safe that way.
>
> No, we do that with assembly files. It doesn't work soo well with
> C files as we really don't want GCC itself to generate v7 instructions
> unless we explicitly ask for them.
>
> The other issue here is that somtimes generating code with different
> -march options leads to the linker refusing to link them together...
Ok, I see. Is that a bug in existing toolchains, or something more
fundamental?
I would have expected that you could at least mix all compiler options
that don't impact the ABI or the instruction set like -mthumb.
Also, I think we can still build with e.g. "-march=armv6 -Wa,-march=armv7",
which should tell the compiler to only emit armv6 instructions, but make
the assembler more permissive for inline assembly.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: Define wfi() macro for v6 processors
Date: Tue, 8 Feb 2011 17:58:14 +0100 [thread overview]
Message-ID: <201102081758.14606.arnd@arndb.de> (raw)
In-Reply-To: <20110208163229.GC6188@n2100.arm.linux.org.uk>
On Tuesday 08 February 2011 17:32:29 Russell King - ARM Linux wrote:
> On Tue, Feb 08, 2011 at 04:17:58PM +0100, Arnd Bergmann wrote:
> > On Tuesday 08 February 2011, Dave Martin wrote:
> > > CFLAGS_cpu_specific_object.o += -march=armv7-a
> > >
> > > Whether it's safe to do it depends on whether code from that file
> > > could ever get run on other processors. I'm not so sure of the answer
> > > to that..., but perhaps someone else has a better idea.
> >
> > We already do this a lot from arch/arm/mm/Makefile, and those
> > files are typically just one function per file, so they can easily
> > be proven to be safe that way.
>
> No, we do that with assembly files. It doesn't work soo well with
> C files as we really don't want GCC itself to generate v7 instructions
> unless we explicitly ask for them.
>
> The other issue here is that somtimes generating code with different
> -march options leads to the linker refusing to link them together...
Ok, I see. Is that a bug in existing toolchains, or something more
fundamental?
I would have expected that you could at least mix all compiler options
that don't impact the ABI or the instruction set like -mthumb.
Also, I think we can still build with e.g. "-march=armv6 -Wa,-march=armv7",
which should tell the compiler to only emit armv6 instructions, but make
the assembler more permissive for inline assembly.
Arnd
next prev parent reply other threads:[~2011-02-08 16:58 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-08 11:01 [PATCH v2] ARM: Define wfi() macro for v6 processors Dave Martin
2011-02-08 11:01 ` Dave Martin
2011-02-08 11:08 ` Russell King - ARM Linux
2011-02-08 11:08 ` Russell King - ARM Linux
2011-02-08 11:16 ` Dave Martin
2011-02-08 11:16 ` Dave Martin
2011-02-08 12:11 ` Arnd Bergmann
2011-02-08 12:11 ` Arnd Bergmann
2011-02-08 12:13 ` Russell King - ARM Linux
2011-02-08 12:13 ` Russell King - ARM Linux
2011-02-08 12:53 ` Arnd Bergmann
2011-02-08 12:53 ` Arnd Bergmann
2011-02-08 14:45 ` Dave Martin
2011-02-08 14:45 ` Dave Martin
2011-02-08 14:54 ` Santosh Shilimkar
2011-02-08 14:54 ` Santosh Shilimkar
2011-02-08 15:09 ` Dave Martin
2011-02-08 15:09 ` Dave Martin
2011-02-08 15:17 ` Arnd Bergmann
2011-02-08 15:17 ` Arnd Bergmann
2011-02-08 16:32 ` Russell King - ARM Linux
2011-02-08 16:32 ` Russell King - ARM Linux
2011-02-08 16:58 ` Arnd Bergmann [this message]
2011-02-08 16:58 ` Arnd Bergmann
2011-02-08 17:15 ` Dave Martin
2011-02-08 17:15 ` Dave Martin
2011-02-08 15:15 ` Arnd Bergmann
2011-02-08 15:15 ` Arnd Bergmann
2011-02-08 15:30 ` Dave Martin
2011-02-08 15:30 ` Dave Martin
2011-02-08 15:42 ` Arnd Bergmann
2011-02-08 15:42 ` Arnd Bergmann
2011-02-08 16:21 ` Dave Martin
2011-02-08 16:21 ` Dave Martin
2011-02-09 10:07 ` Arnd Bergmann
2011-02-09 10:07 ` Arnd Bergmann
2011-02-08 16:25 ` Russell King - ARM Linux
2011-02-08 16:25 ` Russell King - ARM Linux
2011-02-08 16:31 ` Dave Martin
2011-02-08 16:31 ` Dave Martin
2011-02-08 16:47 ` Arnd Bergmann
2011-02-08 16:47 ` Arnd Bergmann
2011-02-08 16:55 ` Russell King - ARM Linux
2011-02-08 16:55 ` Russell King - ARM Linux
2011-02-08 17:00 ` Dave Martin
2011-02-08 17:00 ` Dave Martin
2011-02-08 16:20 ` Russell King - ARM Linux
2011-02-08 16:20 ` Russell King - ARM Linux
2011-02-08 16:28 ` Dave Martin
2011-02-08 16:28 ` Dave Martin
2011-02-08 12:22 ` Dave Martin
2011-02-08 12:22 ` Dave Martin
2011-02-08 12:31 ` Santosh Shilimkar
2011-02-08 12:31 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102081758.14606.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=dave.martin@linaro.org \
--cc=j-pihet@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nicolas.pitre@linaro.org \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.