From: Andrew Morton <akpm@linux-foundation.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
Balbir Singh <balbir@linux.vnet.ibm.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [patch 0/4] memcg: operate on page quantities internally
Date: Wed, 9 Feb 2011 13:37:57 -0800 [thread overview]
Message-ID: <20110209133757.735b08ab.akpm@linux-foundation.org> (raw)
In-Reply-To: <1297249313-23746-1-git-send-email-hannes@cmpxchg.org>
On Wed, 9 Feb 2011 12:01:49 +0100
Johannes Weiner <hannes@cmpxchg.org> wrote:
> Hi,
>
> this patch set converts the memcg charge and uncharge paths to operate
> on multiples of pages instead of bytes. It already was a good idea
> before, but with the merge of THP we made a real mess by specifying
> huge pages alternatingly in bytes or in number of regular pages.
>
> If I did not miss anything, this should leave only res_counter and
> user-visible stuff in bytes. The ABI probably won't change, so next
> up is converting res_counter to operate on page quantities.
>
I worry that there will be unconverted code and we'll end up adding
bugs.
A way to minimise the risk is to force compilation errors and warnings:
rename fields and functions, reorder function arguments. Did your
patches do this as much as they could have?
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 0/4] memcg: operate on page quantities internally
Date: Wed, 9 Feb 2011 13:37:57 -0800 [thread overview]
Message-ID: <20110209133757.735b08ab.akpm@linux-foundation.org> (raw)
In-Reply-To: <1297249313-23746-1-git-send-email-hannes@cmpxchg.org>
On Wed, 9 Feb 2011 12:01:49 +0100
Johannes Weiner <hannes@cmpxchg.org> wrote:
> Hi,
>
> this patch set converts the memcg charge and uncharge paths to operate
> on multiples of pages instead of bytes. It already was a good idea
> before, but with the merge of THP we made a real mess by specifying
> huge pages alternatingly in bytes or in number of regular pages.
>
> If I did not miss anything, this should leave only res_counter and
> user-visible stuff in bytes. The ABI probably won't change, so next
> up is converting res_counter to operate on page quantities.
>
I worry that there will be unconverted code and we'll end up adding
bugs.
A way to minimise the risk is to force compilation errors and warnings:
rename fields and functions, reorder function arguments. Did your
patches do this as much as they could have?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-02-09 21:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 11:01 [patch 0/4] memcg: operate on page quantities internally Johannes Weiner
2011-02-09 11:01 ` Johannes Weiner
2011-02-09 11:01 ` [patch 1/4] memcg: keep only one charge cancelling function Johannes Weiner
2011-02-09 11:01 ` Johannes Weiner
2011-02-09 23:51 ` KAMEZAWA Hiroyuki
2011-02-09 23:51 ` KAMEZAWA Hiroyuki
2011-02-10 12:26 ` Johannes Weiner
2011-02-10 12:26 ` Johannes Weiner
2011-02-09 11:01 ` [patch 2/4] memcg: convert per-cpu stock from bytes to page granularity Johannes Weiner
2011-02-09 11:01 ` Johannes Weiner
2011-02-09 23:52 ` KAMEZAWA Hiroyuki
2011-02-09 23:52 ` KAMEZAWA Hiroyuki
2011-02-09 11:01 ` [patch 3/4] memcg: convert uncharge batching " Johannes Weiner
2011-02-09 11:01 ` Johannes Weiner
2011-02-09 23:53 ` KAMEZAWA Hiroyuki
2011-02-09 23:53 ` KAMEZAWA Hiroyuki
2011-02-09 11:01 ` [patch 4/4] memcg: unify charge/uncharge quantities to units of pages Johannes Weiner
2011-02-09 11:01 ` Johannes Weiner
2011-02-09 23:54 ` KAMEZAWA Hiroyuki
2011-02-09 23:54 ` KAMEZAWA Hiroyuki
2011-02-10 12:36 ` Johannes Weiner
2011-02-10 12:36 ` Johannes Weiner
2011-02-09 21:37 ` Andrew Morton [this message]
2011-02-09 21:37 ` [patch 0/4] memcg: operate on page quantities internally Andrew Morton
2011-02-10 12:40 ` Johannes Weiner
2011-02-10 12:40 ` Johannes Weiner
2011-02-09 23:50 ` KAMEZAWA Hiroyuki
2011-02-09 23:50 ` KAMEZAWA Hiroyuki
2011-02-10 12:42 ` Johannes Weiner
2011-02-10 12:42 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110209133757.735b08ab.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.