From: Marcelo Tosatti <mtosatti@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 02/15] Refactor cpu_has_work/any_cpu_has_work in cpus.c
Date: Wed, 9 Feb 2011 11:54:16 -0200 [thread overview]
Message-ID: <20110209135416.GA32689@amt.cnet> (raw)
In-Reply-To: <4D524B56.1050900@web.de>
On Wed, Feb 09, 2011 at 09:07:50AM +0100, Jan Kiszka wrote:
> > Do you really find it easier to read evaluations grouped with || ? I
> > don't.
>
> I do, specifically as the old version was even more confusing in that
> important detail "return 0" vs. "return 1". But even the new benefits
> from the grouping IMHO.
Well alright.
> > Sorry but the name change does not feel right either: CPU is still idle
> > if the vm is not running.
>
> But that's exactly what the function returns. Or is it confusing if we
> are talking about the vcpu or the whole thread here? What about
> "cpu_thread_is_idle" then?
Yes thats better.
WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 02/15] Refactor cpu_has_work/any_cpu_has_work in cpus.c
Date: Wed, 9 Feb 2011 11:54:16 -0200 [thread overview]
Message-ID: <20110209135416.GA32689@amt.cnet> (raw)
In-Reply-To: <4D524B56.1050900@web.de>
On Wed, Feb 09, 2011 at 09:07:50AM +0100, Jan Kiszka wrote:
> > Do you really find it easier to read evaluations grouped with || ? I
> > don't.
>
> I do, specifically as the old version was even more confusing in that
> important detail "return 0" vs. "return 1". But even the new benefits
> from the grouping IMHO.
Well alright.
> > Sorry but the name change does not feel right either: CPU is still idle
> > if the vm is not running.
>
> But that's exactly what the function returns. Or is it confusing if we
> are talking about the vcpu or the whole thread here? What about
> "cpu_thread_is_idle" then?
Yes thats better.
next prev parent reply other threads:[~2011-02-09 14:44 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 11:19 [PATCH 00/15] [uq/master] Patch queue, part III Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-07 11:19 ` [PATCH 01/15] Refactor kvm&tcg function names in cpus.c Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-07 11:19 ` [PATCH 02/15] Refactor cpu_has_work/any_cpu_has_work " Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-08 18:50 ` Marcelo Tosatti
2011-02-08 18:50 ` [Qemu-devel] " Marcelo Tosatti
2011-02-09 8:07 ` Jan Kiszka
2011-02-09 8:07 ` [Qemu-devel] " Jan Kiszka
2011-02-09 13:54 ` Marcelo Tosatti [this message]
2011-02-09 13:54 ` Marcelo Tosatti
2011-02-09 15:29 ` [PATCH v2 " Jan Kiszka
2011-02-09 15:29 ` [Qemu-devel] " Jan Kiszka
2011-02-07 11:19 ` [PATCH 03/15] Fix a few coding style violations " Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-07 11:19 ` [PATCH 04/15] Improve vm_stop reason declarations Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-08 18:59 ` Marcelo Tosatti
2011-02-08 18:59 ` [Qemu-devel] " Marcelo Tosatti
2011-02-09 8:07 ` Jan Kiszka
2011-02-09 8:07 ` [Qemu-devel] " Jan Kiszka
2011-02-09 14:17 ` Marcelo Tosatti
2011-02-09 14:17 ` [Qemu-devel] " Marcelo Tosatti
2011-02-09 14:51 ` Jan Kiszka
2011-02-09 14:51 ` [Qemu-devel] " Jan Kiszka
2011-02-09 15:29 ` [PATCH v2 " Jan Kiszka
2011-02-09 15:29 ` [Qemu-devel] " Jan Kiszka
2011-02-07 11:19 ` [PATCH 05/15] Refactor debug and vmstop request interface Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-07 11:19 ` [PATCH 06/15] Move debug exception handling out of cpu_exec Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-07 11:19 ` [PATCH 07/15] kvm: Separate TCG from KVM cpu execution Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-08 23:39 ` Marcelo Tosatti
2011-02-08 23:39 ` [Qemu-devel] " Marcelo Tosatti
2011-02-09 7:59 ` Jan Kiszka
2011-02-09 7:59 ` [Qemu-devel] " Jan Kiszka
2011-02-09 14:44 ` Marcelo Tosatti
2011-02-09 14:44 ` [Qemu-devel] " Marcelo Tosatti
2011-02-09 14:53 ` Jan Kiszka
2011-02-09 14:53 ` [Qemu-devel] " Jan Kiszka
2011-02-07 11:19 ` [PATCH 08/15] kvm: x86: Prepare VCPU loop for in-kernel irqchip Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-07 11:19 ` [PATCH 09/15] kvm: Drop return values from kvm_arch_pre/post_run Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-07 12:54 ` Alexander Graf
2011-02-07 12:54 ` [Qemu-devel] " Alexander Graf
2011-02-17 21:01 ` [PATCH] kvm: ppc: Fix breakage of kvm_arch_pre_run/process_irqchip_events Jan Kiszka
2011-02-17 21:01 ` [Qemu-devel] " Jan Kiszka
2011-03-11 5:55 ` Alexander Graf
2011-03-11 5:55 ` [Qemu-devel] " Alexander Graf
2011-03-11 6:26 ` Stefan Hajnoczi
2011-03-11 6:26 ` [Qemu-devel] " Stefan Hajnoczi
2011-03-11 7:02 ` Alexander Graf
2011-03-11 7:02 ` [Qemu-devel] " Alexander Graf
2011-02-07 11:19 ` [PATCH 10/15] kvm: x86: Catch and report failing IRQ and NMI injections Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-07 11:19 ` [PATCH 11/15] kvm: Remove unneeded memory slot reservation Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-07 15:26 ` Alex Williamson
2011-02-07 15:26 ` [Qemu-devel] " Alex Williamson
2011-02-07 11:19 ` [PATCH 12/15] Introduce log_start/log_stop in CPUPhysMemoryClient Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-07 11:19 ` [PATCH 13/15] cirrus: Remove obsolete kvm.h include Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-07 11:19 ` [PATCH 14/15] kvm: Make kvm_state globally available Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-07 11:19 ` [PATCH 15/15] kvm: x86: Introduce kvmclock device to save/restore its state Jan Kiszka
2011-02-07 11:19 ` [Qemu-devel] " Jan Kiszka
2011-02-07 12:27 ` Glauber Costa
2011-02-07 12:27 ` [Qemu-devel] " Glauber Costa
2011-02-07 12:36 ` Jan Kiszka
2011-02-07 12:36 ` [Qemu-devel] " Jan Kiszka
2011-02-07 13:40 ` Glauber Costa
2011-02-07 13:40 ` [Qemu-devel] " Glauber Costa
2011-02-07 14:03 ` Jan Kiszka
2011-02-07 14:03 ` [Qemu-devel] " Jan Kiszka
2011-02-07 18:04 ` Glauber Costa
2011-02-07 18:04 ` [Qemu-devel] " Glauber Costa
2011-02-07 18:12 ` Jan Kiszka
2011-02-07 18:12 ` [Qemu-devel] " Jan Kiszka
2011-02-07 18:26 ` Glauber Costa
2011-02-07 18:26 ` [Qemu-devel] " Glauber Costa
2011-02-07 12:44 ` Avi Kivity
2011-02-07 12:44 ` [Qemu-devel] " Avi Kivity
2011-02-07 19:39 ` [Qemu-devel] " Blue Swirl
2011-02-07 19:39 ` Blue Swirl
2011-02-07 21:48 ` Jan Kiszka
2011-02-07 21:48 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110209135416.GA32689@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.