All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm: dts: fix NTC thermistor device nodes for cros5250
@ 2013-08-22 11:48 ` Naveen Krishna Chatradhi
  0 siblings, 0 replies; 6+ messages in thread
From: Naveen Krishna Chatradhi @ 2013-08-22 11:48 UTC (permalink / raw)
  To: kgene.kim, ben-linux, linux-samsung-soc, linux-arm-kernel
  Cc: naveenkrishna.ch

This patch fixes NTC devices nodes connected to ADC channel 3, 4, 5 and 6
on exynos5250 based snow device.

Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
 arch/arm/boot/dts/cros5250-common.dtsi |   33 ++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/arch/arm/boot/dts/cros5250-common.dtsi b/arch/arm/boot/dts/cros5250-common.dtsi
index dc259e8b..26bc25a 100644
--- a/arch/arm/boot/dts/cros5250-common.dtsi
+++ b/arch/arm/boot/dts/cros5250-common.dtsi
@@ -313,4 +313,37 @@
 			gpio-key,wakeup;
 		};
 	};
+
+	adc@12D10000 {
+		vdd-supply = <&buck5_reg>;
+
+		ncp15wb473@3 {
+			compatible = "ntc,ncp15wb473";
+			pullup-uv = <1800000>;
+			pullup-ohm = <47000>;
+			pulldown-ohm = <0>;
+			io-channels = <&adc 3>;
+		};
+		ncp15wb473@4 {
+			compatible = "ntc,ncp15wb473";
+			pullup-uv = <1800000>;
+			pullup-ohm = <47000>;
+			pulldown-ohm = <0>;
+			io-channels = <&adc 4>;
+		};
+		ncp15wb473@5 {
+			compatible = "ntc,ncp15wb473";
+			pullup-uv = <1800000>;
+			pullup-ohm = <47000>;
+			pulldown-ohm = <0>;
+			io-channels = <&adc 5>;
+		};
+		ncp15wb473@6 {
+			compatible = "ntc,ncp15wb473";
+			pullup-uv = <1800000>;
+			pullup-ohm = <47000>;
+			pulldown-ohm = <0>;
+			io-channels = <&adc 6>;
+		};
+	};
 };
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] arm: dts: fix NTC thermistor device nodes for cros5250
@ 2013-08-22 11:48 ` Naveen Krishna Chatradhi
  0 siblings, 0 replies; 6+ messages in thread
From: Naveen Krishna Chatradhi @ 2013-08-22 11:48 UTC (permalink / raw)
  To: linux-arm-kernel

This patch fixes NTC devices nodes connected to ADC channel 3, 4, 5 and 6
on exynos5250 based snow device.

Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
 arch/arm/boot/dts/cros5250-common.dtsi |   33 ++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/arch/arm/boot/dts/cros5250-common.dtsi b/arch/arm/boot/dts/cros5250-common.dtsi
index dc259e8b..26bc25a 100644
--- a/arch/arm/boot/dts/cros5250-common.dtsi
+++ b/arch/arm/boot/dts/cros5250-common.dtsi
@@ -313,4 +313,37 @@
 			gpio-key,wakeup;
 		};
 	};
+
+	adc at 12D10000 {
+		vdd-supply = <&buck5_reg>;
+
+		ncp15wb473 at 3 {
+			compatible = "ntc,ncp15wb473";
+			pullup-uv = <1800000>;
+			pullup-ohm = <47000>;
+			pulldown-ohm = <0>;
+			io-channels = <&adc 3>;
+		};
+		ncp15wb473 at 4 {
+			compatible = "ntc,ncp15wb473";
+			pullup-uv = <1800000>;
+			pullup-ohm = <47000>;
+			pulldown-ohm = <0>;
+			io-channels = <&adc 4>;
+		};
+		ncp15wb473 at 5 {
+			compatible = "ntc,ncp15wb473";
+			pullup-uv = <1800000>;
+			pullup-ohm = <47000>;
+			pulldown-ohm = <0>;
+			io-channels = <&adc 5>;
+		};
+		ncp15wb473 at 6 {
+			compatible = "ntc,ncp15wb473";
+			pullup-uv = <1800000>;
+			pullup-ohm = <47000>;
+			pulldown-ohm = <0>;
+			io-channels = <&adc 6>;
+		};
+	};
 };
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] arm: dts: fix NTC thermistor device nodes for cros5250
  2013-08-22 11:48 ` Naveen Krishna Chatradhi
@ 2013-08-22 23:00   ` Tomasz Figa
  -1 siblings, 0 replies; 6+ messages in thread
From: Tomasz Figa @ 2013-08-22 23:00 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Naveen Krishna Chatradhi, kgene.kim, ben-linux, linux-samsung-soc,
	naveenkrishna.ch

Hi Naveen,

On Thursday 22 of August 2013 17:18:34 Naveen Krishna Chatradhi wrote:
> This patch fixes NTC devices nodes connected to ADC channel 3, 4, 5 and
> 6 on exynos5250 based snow device.
> 
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> ---
>  arch/arm/boot/dts/cros5250-common.dtsi |   33
> ++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+)

This patch does not look like fixing anything. Instead it adds board 
specific data to adc node to cros5250 common dtsi file.

Also please resend this patch with all the recipients added according to 
MAINTAINERS file.

Best regards,
Tomasz

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] arm: dts: fix NTC thermistor device nodes for cros5250
@ 2013-08-22 23:00   ` Tomasz Figa
  0 siblings, 0 replies; 6+ messages in thread
From: Tomasz Figa @ 2013-08-22 23:00 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Naveen,

On Thursday 22 of August 2013 17:18:34 Naveen Krishna Chatradhi wrote:
> This patch fixes NTC devices nodes connected to ADC channel 3, 4, 5 and
> 6 on exynos5250 based snow device.
> 
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> ---
>  arch/arm/boot/dts/cros5250-common.dtsi |   33
> ++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+)

This patch does not look like fixing anything. Instead it adds board 
specific data to adc node to cros5250 common dtsi file.

Also please resend this patch with all the recipients added according to 
MAINTAINERS file.

Best regards,
Tomasz

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2] arm: dts: fix NTC thermistor device nodes for cros5250
  2013-08-22 11:48 ` Naveen Krishna Chatradhi
@ 2013-08-23  8:03   ` Naveen Krishna Chatradhi
  -1 siblings, 0 replies; 6+ messages in thread
From: Naveen Krishna Chatradhi @ 2013-08-23  8:03 UTC (permalink / raw)
  To: kgene.kim, linux-samsung-soc, linux-arm-kernel, devicetree,
	linux-kernel
  Cc: rob.herring, naveenkrishna.ch

This patch fixes NTC devices nodes connected to ADC channel 3, 4, 5 and 6
on exynos5250 based snow device.

Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Signed-off-by: Doug Anderson <dianders@chromium.org>
---

Added recipients accordingly,
./scripts/get_maintainer.pl  -f of the modified files

 arch/arm/boot/dts/cros5250-common.dtsi |   33 ++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/arch/arm/boot/dts/cros5250-common.dtsi b/arch/arm/boot/dts/cros5250-common.dtsi
index dc259e8b..26bc25a 100644
--- a/arch/arm/boot/dts/cros5250-common.dtsi
+++ b/arch/arm/boot/dts/cros5250-common.dtsi
@@ -313,4 +313,37 @@
 			gpio-key,wakeup;
 		};
 	};
+
+	adc@12D10000 {
+		vdd-supply = <&buck5_reg>;
+
+		ncp15wb473@3 {
+			compatible = "ntc,ncp15wb473";
+			pullup-uv = <1800000>;
+			pullup-ohm = <47000>;
+			pulldown-ohm = <0>;
+			io-channels = <&adc 3>;
+		};
+		ncp15wb473@4 {
+			compatible = "ntc,ncp15wb473";
+			pullup-uv = <1800000>;
+			pullup-ohm = <47000>;
+			pulldown-ohm = <0>;
+			io-channels = <&adc 4>;
+		};
+		ncp15wb473@5 {
+			compatible = "ntc,ncp15wb473";
+			pullup-uv = <1800000>;
+			pullup-ohm = <47000>;
+			pulldown-ohm = <0>;
+			io-channels = <&adc 5>;
+		};
+		ncp15wb473@6 {
+			compatible = "ntc,ncp15wb473";
+			pullup-uv = <1800000>;
+			pullup-ohm = <47000>;
+			pulldown-ohm = <0>;
+			io-channels = <&adc 6>;
+		};
+	};
 };
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v2] arm: dts: fix NTC thermistor device nodes for cros5250
@ 2013-08-23  8:03   ` Naveen Krishna Chatradhi
  0 siblings, 0 replies; 6+ messages in thread
From: Naveen Krishna Chatradhi @ 2013-08-23  8:03 UTC (permalink / raw)
  To: linux-arm-kernel

This patch fixes NTC devices nodes connected to ADC channel 3, 4, 5 and 6
on exynos5250 based snow device.

Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Signed-off-by: Doug Anderson <dianders@chromium.org>
---

Added recipients accordingly,
./scripts/get_maintainer.pl  -f of the modified files

 arch/arm/boot/dts/cros5250-common.dtsi |   33 ++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/arch/arm/boot/dts/cros5250-common.dtsi b/arch/arm/boot/dts/cros5250-common.dtsi
index dc259e8b..26bc25a 100644
--- a/arch/arm/boot/dts/cros5250-common.dtsi
+++ b/arch/arm/boot/dts/cros5250-common.dtsi
@@ -313,4 +313,37 @@
 			gpio-key,wakeup;
 		};
 	};
+
+	adc at 12D10000 {
+		vdd-supply = <&buck5_reg>;
+
+		ncp15wb473 at 3 {
+			compatible = "ntc,ncp15wb473";
+			pullup-uv = <1800000>;
+			pullup-ohm = <47000>;
+			pulldown-ohm = <0>;
+			io-channels = <&adc 3>;
+		};
+		ncp15wb473 at 4 {
+			compatible = "ntc,ncp15wb473";
+			pullup-uv = <1800000>;
+			pullup-ohm = <47000>;
+			pulldown-ohm = <0>;
+			io-channels = <&adc 4>;
+		};
+		ncp15wb473 at 5 {
+			compatible = "ntc,ncp15wb473";
+			pullup-uv = <1800000>;
+			pullup-ohm = <47000>;
+			pulldown-ohm = <0>;
+			io-channels = <&adc 5>;
+		};
+		ncp15wb473 at 6 {
+			compatible = "ntc,ncp15wb473";
+			pullup-uv = <1800000>;
+			pullup-ohm = <47000>;
+			pulldown-ohm = <0>;
+			io-channels = <&adc 6>;
+		};
+	};
 };
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-08-23  8:03 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-22 11:48 [PATCH] arm: dts: fix NTC thermistor device nodes for cros5250 Naveen Krishna Chatradhi
2013-08-22 11:48 ` Naveen Krishna Chatradhi
2013-08-22 23:00 ` Tomasz Figa
2013-08-22 23:00   ` Tomasz Figa
2013-08-23  8:03 ` [PATCH v2] " Naveen Krishna Chatradhi
2013-08-23  8:03   ` Naveen Krishna Chatradhi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.