From: Wolfram Sang <w.sang@pengutronix.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] video: Add i.MX23/28 framebuffer driver
Date: Thu, 10 Feb 2011 10:47:25 +0000 [thread overview]
Message-ID: <20110210104725.GC2206@pengutronix.de> (raw)
In-Reply-To: <201102101046.33994.jbe@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 517 bytes --]
> But I would prefer:
> #define SET 4
> #define CLEAR 8
> [...]
> writel(CTRL_DOTCLK_MODE, host->base + CTRL + SET)
NACK.
This will indeed not be caught by the compiler.
And while I like the shorter macros better as well, an MXSFB_ prefix
should be added IMO. Macros like CTRL and TIMING are not too well
protected.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] video: Add i.MX23/28 framebuffer driver
Date: Thu, 10 Feb 2011 11:47:25 +0100 [thread overview]
Message-ID: <20110210104725.GC2206@pengutronix.de> (raw)
In-Reply-To: <201102101046.33994.jbe@pengutronix.de>
> But I would prefer:
> #define SET 4
> #define CLEAR 8
> [...]
> writel(CTRL_DOTCLK_MODE, host->base + CTRL + SET)
NACK.
This will indeed not be caught by the compiler.
And while I like the shorter macros better as well, an MXSFB_ prefix
should be added IMO. Macros like CTRL and TIMING are not too well
protected.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110210/d36ddd33/attachment.sig>
next prev parent reply other threads:[~2011-02-10 10:47 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 13:20 [PATCH] i.MX23/28 framebuffer driver Sascha Hauer
2011-02-09 13:20 ` [PATCH 1/2] video: Add " Sascha Hauer
2011-02-09 13:20 ` Sascha Hauer
2011-02-09 13:35 ` Lothar Waßmann
2011-02-09 13:35 ` Lothar Waßmann
2011-02-10 3:16 ` Li Frank-B20596
2011-02-10 3:16 ` Li Frank-B20596
2011-02-10 8:51 ` Juergen Beisert
2011-02-10 8:51 ` Juergen Beisert
2011-02-10 9:15 ` Li Frank-B20596
2011-02-10 9:15 ` Li Frank-B20596
2011-02-10 9:52 ` Juergen Beisert
2011-02-10 9:52 ` Juergen Beisert
2011-02-10 10:37 ` Li Frank-B20596
2011-02-10 10:37 ` Li Frank-B20596
2011-02-10 11:12 ` Juergen Beisert
2011-02-10 11:12 ` Juergen Beisert
2011-02-10 12:23 ` Li Frank-B20596
2011-02-10 12:23 ` Li Frank-B20596
2011-02-10 9:23 ` Li Frank-B20596
2011-02-10 9:23 ` Li Frank-B20596
2011-02-10 9:46 ` Juergen Beisert
2011-02-10 9:46 ` Juergen Beisert
2011-02-10 10:08 ` Li Frank-B20596
2011-02-10 10:08 ` Li Frank-B20596
2011-02-10 10:47 ` Wolfram Sang [this message]
2011-02-10 10:47 ` Wolfram Sang
2011-02-10 11:51 ` Sascha Hauer
2011-02-10 11:51 ` Sascha Hauer
2011-02-10 12:32 ` Li Frank-B20596
2011-02-10 12:32 ` Li Frank-B20596
2011-02-09 13:20 ` [PATCH 2/2] ARM i.MX23/28: Add framebuffer device support Sascha Hauer
2011-02-09 14:33 ` Fabio Estevam
2011-02-10 3:23 ` Li Frank-B20596
2011-02-09 14:47 ` [PATCH] i.MX23/28 framebuffer driver Arnd Bergmann
2011-02-09 15:37 ` Sascha Hauer
2011-02-09 16:31 ` Arnd Bergmann
2011-02-09 16:31 ` Arnd Bergmann
2011-02-10 17:09 ` Robert Schwebel
2011-02-10 17:09 ` Robert Schwebel
2011-02-15 14:13 ` Clark, Rob
2011-02-15 14:13 ` Clark, Rob
2011-02-16 12:22 ` Arnd Bergmann
2011-02-16 12:22 ` Arnd Bergmann
2011-02-16 14:42 ` Jesse Barker
2011-02-17 1:08 ` Clark, Rob
2011-02-17 1:08 ` Clark, Rob
2011-02-17 1:24 ` Jammy Zhou
2011-02-17 15:25 ` Clark, Rob
2011-02-17 15:25 ` Clark, Rob
2011-02-18 2:25 ` Jammy Zhou
2011-02-18 4:34 ` Clark, Rob
2011-02-18 4:34 ` Clark, Rob
2011-02-17 16:14 ` James Simmons
2011-02-17 16:14 ` James Simmons
2011-02-17 16:14 ` James Simmons
2011-02-18 2:19 ` Jammy Zhou
2011-02-18 2:19 ` Jammy Zhou
[not found] ` <AANLkTimcwr4vpycSQCH9vMaB+umh+yHD_+WD2MJNqMOB-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-02-18 4:32 ` Clark, Rob
2011-02-18 4:32 ` Clark, Rob
2011-02-18 4:32 ` Clark, Rob
2011-02-21 3:12 ` Dave Airlie
2011-02-21 3:12 ` Dave Airlie
2011-02-21 3:12 ` Dave Airlie
2011-02-10 9:22 ` Domenico Andreoli
-- strict thread matches above, loose matches on Subject: below --
2011-02-16 9:56 [PATCH v2] i.MX23/28 Framebuffer driver Sascha Hauer
2011-02-16 9:56 ` [PATCH 1/2] video: Add i.MX23/28 framebuffer driver Sascha Hauer
2011-02-16 9:56 ` Sascha Hauer
2011-02-18 5:24 ` Shawn Guo
2011-02-18 5:24 ` Shawn Guo
2011-02-18 8:30 ` Sascha Hauer
2011-02-18 8:30 ` Sascha Hauer
2011-02-18 8:57 ` Shawn Guo
2011-02-18 8:57 ` Shawn Guo
2011-02-18 12:29 ` Shawn Guo
2011-02-18 12:29 ` Shawn Guo
2011-02-21 14:17 ` Sascha Hauer
2011-02-21 14:17 ` Sascha Hauer
2011-02-28 8:02 [PATCH v3] i.MX23/28 Framebuffer support Sascha Hauer
2011-02-28 8:02 ` [PATCH 1/2] video: Add i.MX23/28 framebuffer driver Sascha Hauer
2011-02-28 8:02 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110210104725.GC2206@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.