* [RFC PATCH 02/13] Intel(R) MEI Driver
@ 2011-02-10 9:55 Oren Weil
2011-02-10 18:01 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Oren Weil @ 2011-02-10 9:55 UTC (permalink / raw)
To: gregkh, akpm, linux-kernel; +Cc: david, david.woodhouse
diff --git a/drivers/char/Makefile b/drivers/char/Makefile
index 5bc765d..e43ea27 100644
--- a/drivers/char/Makefile
+++ b/drivers/char/Makefile
@@ -84,4 +84,5 @@ obj-$(CONFIG_PS3_FLASH) += ps3flash.o
obj-$(CONFIG_RAMOOPS) += ramoops.o
obj-$(CONFIG_JS_RTC) += js-rtc.o
+obj-$(CONFIG_INTEL_MEI) += mei/
js-rtc-y = rtc.o
---------------------------------------------------------------------
Intel Israel (74) Limited
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RFC PATCH 02/13] Intel(R) MEI Driver
2011-02-10 9:55 [RFC PATCH 02/13] Intel(R) MEI Driver Oren Weil
@ 2011-02-10 18:01 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2011-02-10 18:01 UTC (permalink / raw)
To: Oren Weil; +Cc: akpm, linux-kernel, david, david.woodhouse
On Thu, Feb 10, 2011 at 01:55:00AM -0800, Oren Weil wrote:
> diff --git a/drivers/char/Makefile b/drivers/char/Makefile
No description, or signed-off-by lines. Have you read how to properly
create and submit a patch? If so, why did you ignore those rules?
> index 5bc765d..e43ea27 100644
> --- a/drivers/char/Makefile
> +++ b/drivers/char/Makefile
> @@ -84,4 +84,5 @@ obj-$(CONFIG_PS3_FLASH) += ps3flash.o
> obj-$(CONFIG_RAMOOPS) += ramoops.o
>
> obj-$(CONFIG_JS_RTC) += js-rtc.o
> +obj-$(CONFIG_INTEL_MEI) += mei/
You just broke the build.
I'm not going to review farther, it's a waste of my, and every one
else's time.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-10 18:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-10 9:55 [RFC PATCH 02/13] Intel(R) MEI Driver Oren Weil
2011-02-10 18:01 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.