All of lore.kernel.org
 help / color / mirror / Atom feed
From: akpm@linux-foundation.org (Andrew Morton)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 1/1] ST SPEAr: PCIE gadget suppport
Date: Thu, 10 Feb 2011 23:31:00 -0800	[thread overview]
Message-ID: <20110210233100.e12e8f6a.akpm@linux-foundation.org> (raw)
In-Reply-To: <4D54E39C.6070306@st.com>

On Fri, 11 Feb 2011 12:52:04 +0530 pratyush <pratyush.anand@st.com> wrote:

> >>> This interface implies that there will only ever be one device in the
> >>> machine, yes?  Seems a bit short-sighted?
> >>>
> >>
> >> This device supports only one BAR in EP mode.
> > 
> > I don't understand that.
> > 
> > What happens if someone builds a computer with three of these devices
> > in it?
> > 
> 
> I understood it. I will modify the code to work with multiple instances of
> pcie device.

I don't think you need to go that far, unless you see a significant
likelihood think that such a computer might be created one day.  This
depends on how hard and risky such a change is, of course.

But the current driver's userspace interface should at least
anticipate the possibility, so you aren't trapped into a weird or
non-back-compatible interface in the future.

So for now you might choose to do something as simple as renaming
/config/pcie-gadget to /config/pcie-gadget0 and leave it at that.

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: pratyush <pratyush.anand@st.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>, Greg KH <gregkh@suse.de>,
	Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH V3 1/1] ST SPEAr: PCIE gadget suppport
Date: Thu, 10 Feb 2011 23:31:00 -0800	[thread overview]
Message-ID: <20110210233100.e12e8f6a.akpm@linux-foundation.org> (raw)
In-Reply-To: <4D54E39C.6070306@st.com>

On Fri, 11 Feb 2011 12:52:04 +0530 pratyush <pratyush.anand@st.com> wrote:

> >>> This interface implies that there will only ever be one device in the
> >>> machine, yes?  Seems a bit short-sighted?
> >>>
> >>
> >> This device supports only one BAR in EP mode.
> > 
> > I don't understand that.
> > 
> > What happens if someone builds a computer with three of these devices
> > in it?
> > 
> 
> I understood it. I will modify the code to work with multiple instances of
> pcie device.

I don't think you need to go that far, unless you see a significant
likelihood think that such a computer might be created one day.  This
depends on how hard and risky such a change is, of course.

But the current driver's userspace interface should at least
anticipate the possibility, so you aren't trapped into a weird or
non-back-compatible interface in the future.

So for now you might choose to do something as simple as renaming
/config/pcie-gadget to /config/pcie-gadget0 and leave it at that.


  reply	other threads:[~2011-02-11  7:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-03 14:09 [PATCH V3 1/1] ST SPEAr: PCIE gadget suppport Pratyush Anand
2011-02-03 14:09 ` Pratyush Anand
2011-02-09 23:29 ` Andrew Morton
2011-02-09 23:29   ` Andrew Morton
2011-02-10  9:49   ` pratyush
2011-02-10  9:49     ` pratyush
2011-02-10 20:52     ` Andrew Morton
2011-02-10 20:52       ` Andrew Morton
2011-02-11  7:22       ` pratyush
2011-02-11  7:22         ` pratyush
2011-02-11  7:31         ` Andrew Morton [this message]
2011-02-11  7:31           ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110210233100.e12e8f6a.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.