All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH v3 7/7] hwmon: (w83627ehf) Use 16 bit fan
Date: Sat, 12 Feb 2011 03:45:16 +0000	[thread overview]
Message-ID: <20110212034516.GA6734@ericsson.com> (raw)
In-Reply-To: <1297444832-10874-8-git-send-email-guenter.roeck@ericsson.com>

On Fri, Feb 11, 2011 at 10:09:23PM -0500, Andrew Lutomirski wrote:
> On Fri, Feb 11, 2011 at 12:20 PM, Guenter Roeck
> <guenter.roeck@ericsson.com> wrote:
> > Some of the chips supported by this driver have 13 bit or 16 bit fan count
> > registers. This patch improves support for those registers, specifically for
> > NCT6775F. With the changes in this patch, fan speed is reported correctly even
> > if the fan divider is set to a low value, which results in a fan speed reading
> > above 0xff.
> 
> I'm not convinced this works.  I have an NCT6775F (or at least the
> driver says I do) and, with fan2_min = 0 or 100, I get fan2_div = 128.
>  If I set fan2_min\x1000, I get fan2_div = 8 but fan2_input reads 0.
> Presumably a low divider should have worked if I really had 16 bits to
> play with.
> 
Yes, you are right. Can you dump the raw contents of the registers at 0x28..0x2a
as well as 0x630..0x637 ?

According to the datasheet, register 0x28 and 0x631 should match, 0x29 should
match 0x633, 0x2a should match 0x635, and 0x3f should match 0x637.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2011-02-12  3:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-11 17:20 [lm-sensors] [PATCH v3 7/7] hwmon: (w83627ehf) Use 16 bit fan count Guenter Roeck
2011-02-12  3:09 ` [lm-sensors] [PATCH v3 7/7] hwmon: (w83627ehf) Use 16 bit fan Andrew Lutomirski
2011-02-12  3:45 ` Guenter Roeck [this message]
2011-02-12  4:08 ` Andrew Lutomirski
2011-02-12  5:08 ` Guenter Roeck
2011-02-12 13:53 ` Andrew Lutomirski
2011-02-12 15:48 ` Guenter Roeck
2011-02-12 16:01 ` Andrew Lutomirski
2011-02-12 17:47 ` Guenter Roeck
2011-02-12 17:55 ` Guenter Roeck
2011-02-12 18:56 ` Andrew Lutomirski
2011-02-12 21:26 ` Guenter Roeck
2011-02-14  6:03 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110212034516.GA6734@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.