From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH v3 7/7] hwmon: (w83627ehf) Use 16 bit fan
Date: Sat, 12 Feb 2011 15:48:48 +0000 [thread overview]
Message-ID: <20110212154848.GA8994@ericsson.com> (raw)
In-Reply-To: <1297444832-10874-8-git-send-email-guenter.roeck@ericsson.com>
On Sat, Feb 12, 2011 at 08:53:51AM -0500, Andrew Lutomirski wrote:
[ ...]
>
> With fan2_div = 32 (b/c fan2_min = 502), I get:
>
> [48429.734521] w83627ehf: Found NCT6775F chip at 0x290
> [48429.734818] Reg 0028 = 47
> [48429.734832] Reg 0029 = 00
> [48429.734843] Reg 002a = 00
> [48429.734855] Reg 003f = 00
> [48429.734884] Reg 0630 = 0047
> [48429.734905] Reg 0631 = 4700
> [48429.734925] Reg 0632 = 0000
> [48429.734945] Reg 0633 = 0000
> [48429.734965] Reg 0634 = 0000
> [48429.734986] Reg 0635 = 0000
> [48429.735006] Reg 0636 = 0000
> [48429.735026] Reg 0637 = 0000
> [48437.765900] nr=1, fan=0, fan_div=4, fan_from_reg=0 <<< reading fan2_input
>
> With fan2_min = 100 (i.e. fan2_div = 128) I get:
>
> [48525.613069] w83627ehf: Found NCT6775F chip at 0x290
> [48525.613686] Reg 0028 = 47
> [48525.613698] Reg 0029 = 4c
> [48525.613708] Reg 002a = 00
> [48525.613719] Reg 003f = 00
> [48525.613754] Reg 0630 = 0047
> [48525.613772] Reg 0631 = 4700
> [48525.613796] Reg 0632 = 004c
> [48525.613813] Reg 0633 = 4c00
> [48525.613829] Reg 0634 = 0000
> [48525.613846] Reg 0635 = 0000
> [48525.613863] Reg 0636 = 0000
> [48525.613880] Reg 0637 = 0000
> [48533.156472] nr=1, fanw, fan_div=7, fan_from_reg\x136
>
> Maybe those 8 high bits just don't work? Is there some flag to set to
> put the chip in 16-bit mode?
>
16 bit mode is always active.
Register 0x29 and 0x632/0x0633 are in sync, though. What is odd is that
the value is 0x0 in both registers when it should be 0xff or above.
This is a problem, because if it returns 0x0 in register 0x29 if the divisor
value is too low, we can not detect that it is too low, and the code
to automatically increase the divisor does not work.
Can you check what you get for other fan_min values, specifically for 200 ?
Also, can you check the return values of registers 0x656..0x65d ?
That should be the direct RPM values. Maybe we have to use the RPM registers
for the new chips instead of using the fan count.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2011-02-12 15:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-11 17:20 [lm-sensors] [PATCH v3 7/7] hwmon: (w83627ehf) Use 16 bit fan count Guenter Roeck
2011-02-12 3:09 ` [lm-sensors] [PATCH v3 7/7] hwmon: (w83627ehf) Use 16 bit fan Andrew Lutomirski
2011-02-12 3:45 ` Guenter Roeck
2011-02-12 4:08 ` Andrew Lutomirski
2011-02-12 5:08 ` Guenter Roeck
2011-02-12 13:53 ` Andrew Lutomirski
2011-02-12 15:48 ` Guenter Roeck [this message]
2011-02-12 16:01 ` Andrew Lutomirski
2011-02-12 17:47 ` Guenter Roeck
2011-02-12 17:55 ` Guenter Roeck
2011-02-12 18:56 ` Andrew Lutomirski
2011-02-12 21:26 ` Guenter Roeck
2011-02-14 6:03 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110212154848.GA8994@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.