From: Arnd Bergmann <arnd@arndb.de>
To: Shawn Guo <shawn.guo@freescale.com>
Cc: s.hauer@pengutronix.de, cjb@laptop.org,
linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
u.kleine-koenig@pengutronix.de
Subject: Re: [PATCH 1/7] mmc: mxs-mmc: add mmc host driver for i.MX23/28
Date: Sun, 13 Feb 2011 17:10:32 +0100 [thread overview]
Message-ID: <201102131710.33041.arnd@arndb.de> (raw)
In-Reply-To: <20110213235207.GA10397@S2100-06.ap.freescale.net>
On Monday 14 February 2011 00:52:08 Shawn Guo wrote:
> I rewriting the code to use mmc core card detect polling framework.
>
> static int mxs_mmc_get_cd(struct mmc_host *mmc)
> {
> struct mxs_mmc_host *host = mmc_priv(mmc);
>
> return !(readl(host->base + HW_SSP_STATUS) &
> BM_SSP_STATUS_CARD_DETECT);
> }
>
> static const struct mmc_host_ops mxs_mmc_ops = {
> ...
> .get_cd = mxs_mmc_get_cd,
> };
>
> static int mxs_mmc_probe(struct platform_device *pdev)
> {
> ...
> mmc_caps |= MMC_CAP_NEEDS_POLL;
> ...
> }
>
> It looks pretty simple and mmc core code has taken care of the case
> of power management. So if this looks fine to you, I will go for it
> in v2 of the patch set.
Yes, that looks very good.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] mmc: mxs-mmc: add mmc host driver for i.MX23/28
Date: Sun, 13 Feb 2011 17:10:32 +0100 [thread overview]
Message-ID: <201102131710.33041.arnd@arndb.de> (raw)
In-Reply-To: <20110213235207.GA10397@S2100-06.ap.freescale.net>
On Monday 14 February 2011 00:52:08 Shawn Guo wrote:
> I rewriting the code to use mmc core card detect polling framework.
>
> static int mxs_mmc_get_cd(struct mmc_host *mmc)
> {
> struct mxs_mmc_host *host = mmc_priv(mmc);
>
> return !(readl(host->base + HW_SSP_STATUS) &
> BM_SSP_STATUS_CARD_DETECT);
> }
>
> static const struct mmc_host_ops mxs_mmc_ops = {
> ...
> .get_cd = mxs_mmc_get_cd,
> };
>
> static int mxs_mmc_probe(struct platform_device *pdev)
> {
> ...
> mmc_caps |= MMC_CAP_NEEDS_POLL;
> ...
> }
>
> It looks pretty simple and mmc core code has taken care of the case
> of power management. So if this looks fine to you, I will go for it
> in v2 of the patch set.
Yes, that looks very good.
Arnd
next prev parent reply other threads:[~2011-02-13 16:10 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-05 2:18 [PATCH 0/7] Add mmc driver for i.MX23/28 Shawn Guo
2011-02-05 2:18 ` Shawn Guo
2011-02-05 2:18 ` [PATCH 1/7] mmc: mxs-mmc: add mmc host " Shawn Guo
2011-02-05 2:18 ` Shawn Guo
2011-02-04 20:26 ` Arnd Bergmann
2011-02-04 20:26 ` Arnd Bergmann
2011-02-11 0:35 ` Shawn Guo
2011-02-11 0:35 ` Shawn Guo
2011-02-10 17:17 ` Arnd Bergmann
2011-02-10 17:17 ` Arnd Bergmann
2011-02-11 23:14 ` Shawn Guo
2011-02-11 23:14 ` Shawn Guo
2011-02-11 15:51 ` Arnd Bergmann
2011-02-11 15:51 ` Arnd Bergmann
2011-02-12 0:55 ` Shawn Guo
2011-02-12 0:55 ` Shawn Guo
2011-02-11 20:04 ` Arnd Bergmann
2011-02-11 20:04 ` Arnd Bergmann
2011-02-12 14:04 ` Shawn Guo
2011-02-12 14:04 ` Shawn Guo
2011-02-12 8:59 ` Arnd Bergmann
2011-02-12 8:59 ` Arnd Bergmann
2011-02-12 17:23 ` Shawn Guo
2011-02-12 17:23 ` Shawn Guo
2011-02-12 10:07 ` Arnd Bergmann
2011-02-12 10:07 ` Arnd Bergmann
2011-02-12 18:37 ` Shawn Guo
2011-02-12 18:37 ` Shawn Guo
2011-02-12 17:30 ` Arnd Bergmann
2011-02-12 17:30 ` Arnd Bergmann
2011-02-13 17:53 ` Shawn Guo
2011-02-13 17:53 ` Shawn Guo
2011-02-13 15:34 ` Arnd Bergmann
2011-02-13 15:34 ` Arnd Bergmann
2011-02-13 23:52 ` Shawn Guo
2011-02-13 23:52 ` Shawn Guo
2011-02-13 16:10 ` Arnd Bergmann [this message]
2011-02-13 16:10 ` Arnd Bergmann
2011-02-08 11:41 ` Lothar Waßmann
2011-02-08 11:41 ` Lothar Waßmann
2011-02-11 22:11 ` Shawn Guo
2011-02-11 22:11 ` Shawn Guo
2011-02-11 14:40 ` Lothar Waßmann
2011-02-11 14:40 ` Lothar Waßmann
2011-02-12 1:08 ` Shawn Guo
2011-02-12 1:08 ` Shawn Guo
2011-02-09 7:46 ` Lothar Waßmann
2011-02-09 7:46 ` Lothar Waßmann
2011-02-11 22:08 ` Shawn Guo
2011-02-11 22:08 ` Shawn Guo
2011-02-11 14:52 ` Lothar Waßmann
2011-02-11 14:52 ` Lothar Waßmann
2011-02-11 23:48 ` Shawn Guo
2011-02-11 23:48 ` Shawn Guo
2011-02-05 2:18 ` [PATCH 2/7] ARM: mxs/clock: fix base address missing in name##_set_parent Shawn Guo
2011-02-05 2:18 ` Shawn Guo
2011-02-05 2:18 ` [PATCH 3/7] ARM: mxs: make ssp error irq definition consistent Shawn Guo
2011-02-05 2:18 ` Shawn Guo
2011-02-05 2:18 ` [PATCH 4/7] ARM: mxs: dynamically allocate mmc device Shawn Guo
2011-02-05 2:18 ` Shawn Guo
2011-02-05 2:18 ` [PATCH 5/7] ARM: mxs: fix typo "GPO" in iomux-mx23.h Shawn Guo
2011-02-05 2:18 ` Shawn Guo
2011-02-05 2:18 ` [PATCH 6/7] ARM: mxs/mx23evk: add mmc device Shawn Guo
2011-02-05 2:18 ` Shawn Guo
2011-02-05 2:18 ` [PATCH 7/7] ARM: mxs/mx28evk: " Shawn Guo
2011-02-05 2:18 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102131710.33041.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=cjb@laptop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@freescale.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.