Re: [LTP] [PATCH] unshare01.c: TEST_RETURN is used wrong

["Serge E. Hallyn" <serge.hallyn@canonical.com>]

Quoting Peng Haitao (penght@cn.fujitsu.com):
> Hi Garrett,
> 
> Signed-off-by: Peng Haitao <penght@cn.fujitsu.com>
> ---
>  testcases/kernel/syscalls/unshare/unshare01.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/testcases/kernel/syscalls/unshare/unshare01.c b/testcases/kernel/syscalls/unshare/unshare01.c
> index e19d73d..9ae5e8f 100644
> --- a/testcases/kernel/syscalls/unshare/unshare01.c
> +++ b/testcases/kernel/syscalls/unshare/unshare01.c
> @@ -206,7 +206,7 @@ int main(int ac, char **av) {
>  			}
>  
>  			pid1 = fork();
> -			if (TEST_RETURN == -1) {
> +			if (pid1 == -1) {

Looking at the rest of that file, isn't the right fix to
wrap 'pid1 = fork();' in a TEST() macro?

-serge

------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list