All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peng Haitao <penght@cn.fujitsu.com>
To: Garrett Cooper <yanegomi@gmail.com>
Cc: ltp-list@lists.sourceforge.net
Subject: [LTP]  [PATCH] unshare01.c: TEST_RETURN is used wrong
Date: Tue, 15 Feb 2011 17:31:17 +0800	[thread overview]
Message-ID: <4D5A47E5.3060108@cn.fujitsu.com> (raw)

Hi Garrett,

Signed-off-by: Peng Haitao <penght@cn.fujitsu.com>
---
 testcases/kernel/syscalls/unshare/unshare01.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/testcases/kernel/syscalls/unshare/unshare01.c b/testcases/kernel/syscalls/unshare/unshare01.c
index e19d73d..9ae5e8f 100644
--- a/testcases/kernel/syscalls/unshare/unshare01.c
+++ b/testcases/kernel/syscalls/unshare/unshare01.c
@@ -206,7 +206,7 @@ int main(int ac, char **av) {
 			}
 
 			pid1 = fork();
-			if (TEST_RETURN == -1) {
+			if (pid1 == -1) {
 				tst_brkm(TFAIL|TERRNO, cleanup,
 				    "fork failed");
 			} else if (pid1 == 0) {
@@ -249,7 +249,7 @@ int main(int ac, char **av) {
 			if (pid1 == -1) {
 				tst_brkm(TFAIL|TERRNO, cleanup,
 				    "fork() failed.");
-			} else if (TEST_RETURN == 0) {
+			} else if (pid1 == 0) {
 				TEST(unshare(CLONE_NEWNS));
 				if (TEST_RETURN == 0) {
 					printf("unshare call with CLONE_NEWNS "
@@ -299,4 +299,4 @@ int main(void)
 	tst_resm(TCONF, "unshare is undefined.");
 	tst_exit();
 }
-#endif
\ No newline at end of file
+#endif
-- 
1.7.3.1

-- 
Best Regards,
Peng Haitao


------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

             reply	other threads:[~2011-02-15  9:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-15  9:31 Peng Haitao [this message]
2011-02-15 13:26 ` [LTP] [PATCH] unshare01.c: TEST_RETURN is used wrong Serge E. Hallyn
2011-02-15 14:30   ` Garrett Cooper
2011-02-15 15:43     ` Serge E. Hallyn
2011-02-15 14:29 ` Garrett Cooper
2011-02-16  3:58   ` Peng Haitao
2011-02-16  5:35     ` Garrett Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D5A47E5.3060108@cn.fujitsu.com \
    --to=penght@cn.fujitsu.com \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=yanegomi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.