From: Jarkko Nikula <jhnikula@gmail.com>
To: David Cohen <dacohen@gmail.com>
Cc: Sergei Shtylyov <sshtylyov@mvista.com>,
tony@atomide.com, linux-omap@vger.kernel.org,
Hiroshi.DOYU@nokia.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] OMAP2+: IOMMU: change OMAP2+ error message to dev_dbg()
Date: Tue, 15 Feb 2011 15:59:48 +0200 [thread overview]
Message-ID: <20110215155948.32b564d5.jhnikula@gmail.com> (raw)
In-Reply-To: <AANLkTinQX59iyX1La=99Urgh5_JF0iZacBDqQz1VQfhi@mail.gmail.com>
On Tue, 15 Feb 2011 15:44:27 +0200
David Cohen <dacohen@gmail.com> wrote:
> >> @@ -163,13 +163,13 @@ static u32 omap2_iommu_fault_isr(struct iommu *obj,
> >> u32 *ra)
> >> da = iommu_read_reg(obj, MMU_FAULT_AD);
> >> *ra = da;
> >>
> >> - dev_err(obj->dev, "%s:\tda:%08x ", __func__, da);
> >> + dev_dbg(obj->dev, "%s:\tda:%08x ", __func__, da);
> >
> > Note that dev_dbg() will only print something if either DEBUG or
> > CONFIG_DYNAMIC_DEBUG are defined...
>
> That's my plan.
>
So it's sure that a developer won't need these error dumps when
receiving an error report? I.e. IOMMU upper level errors give enough
information to start doing own debugging?
Just my 2 cents.
--
Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: jhnikula@gmail.com (Jarkko Nikula)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] OMAP2+: IOMMU: change OMAP2+ error message to dev_dbg()
Date: Tue, 15 Feb 2011 15:59:48 +0200 [thread overview]
Message-ID: <20110215155948.32b564d5.jhnikula@gmail.com> (raw)
In-Reply-To: <AANLkTinQX59iyX1La=99Urgh5_JF0iZacBDqQz1VQfhi@mail.gmail.com>
On Tue, 15 Feb 2011 15:44:27 +0200
David Cohen <dacohen@gmail.com> wrote:
> >> @@ -163,13 +163,13 @@ static u32 omap2_iommu_fault_isr(struct iommu *obj,
> >> u32 *ra)
> >> ? ? ? ?da = iommu_read_reg(obj, MMU_FAULT_AD);
> >> ? ? ? ?*ra = da;
> >>
> >> - ? ? ? dev_err(obj->dev, "%s:\tda:%08x ", __func__, da);
> >> + ? ? ? dev_dbg(obj->dev, "%s:\tda:%08x ", __func__, da);
> >
> > ? Note that dev_dbg() will only print something if either DEBUG or
> > CONFIG_DYNAMIC_DEBUG are defined...
>
> That's my plan.
>
So it's sure that a developer won't need these error dumps when
receiving an error report? I.e. IOMMU upper level errors give enough
information to start doing own debugging?
Just my 2 cents.
--
Jarkko
next prev parent reply other threads:[~2011-02-15 13:59 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 13:20 [PATCH 0/2] IOMMU fault callback support David Cohen
2011-02-15 13:20 ` David Cohen
2011-02-15 13:20 ` [PATCH 1/2] OMAP2+: IOMMU: change OMAP2+ error message to dev_dbg() David Cohen
2011-02-15 13:20 ` David Cohen
2011-02-15 13:38 ` Sergei Shtylyov
2011-02-15 13:38 ` Sergei Shtylyov
2011-02-15 13:44 ` David Cohen
2011-02-15 13:44 ` David Cohen
2011-02-15 13:56 ` Sergei Shtylyov
2011-02-15 13:56 ` Sergei Shtylyov
2011-02-15 14:01 ` David Cohen
2011-02-15 14:01 ` David Cohen
2011-02-15 13:59 ` Jarkko Nikula [this message]
2011-02-15 13:59 ` Jarkko Nikula
2011-02-15 14:08 ` David Cohen
2011-02-15 14:08 ` David Cohen
2011-02-15 14:21 ` David Cohen
2011-02-15 14:21 ` David Cohen
2011-02-15 14:30 ` Jarkko Nikula
2011-02-15 14:30 ` Jarkko Nikula
2011-02-15 14:29 ` Russell King - ARM Linux
2011-02-15 14:29 ` Russell King - ARM Linux
2011-02-15 14:36 ` David Cohen
2011-02-15 14:36 ` David Cohen
2011-02-15 14:44 ` Russell King - ARM Linux
2011-02-15 14:44 ` Russell King - ARM Linux
2011-02-15 14:50 ` David Cohen
2011-02-15 14:50 ` David Cohen
2011-02-15 15:51 ` Russell King - ARM Linux
2011-02-15 15:51 ` Russell King - ARM Linux
2011-02-15 13:20 ` [PATCH 2/2] OMAP: IOMMU: add support to callback during fault handling David Cohen
2011-02-15 13:20 ` David Cohen
2011-02-15 13:32 ` [PATCH 0/2] IOMMU fault callback support David Cohen
2011-02-15 13:32 ` David Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110215155948.32b564d5.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=Hiroshi.DOYU@nokia.com \
--cc=dacohen@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=sshtylyov@mvista.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.