From: Ralf Baechle <ralf@linux-mips.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Nikolay Ledovskikh <nledovskikh@gmail.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, lrodriguez@atheros.com,
mickflemm@gmail.com, me@bobcopeland.com,
linux-mips@linux-mips.org
Subject: Re: [PATCH] ath5k: Use mips generic dma-mapping functions to avoid seqfault on AHB chips
Date: Wed, 16 Feb 2011 02:12:03 +0100 [thread overview]
Message-ID: <20110216011203.GA5773@linux-mips.org> (raw)
In-Reply-To: <4D5AFBCB.1090907@gmail.com>
On Tue, Feb 15, 2011 at 11:18:51PM +0100, Jiri Slaby wrote:
> > There, the res->start may be either of the following:
> > AR531X_WLAN0 .. 0x18000000
> > AR531X_WLAN1 .. 0x18500000
>
>
> > AR2315_WLAN0 .. 0xB0000000
>
> Or maybe this should be 0x10000000 in openwrt in the first place? Then
> ioremap should do the right thing, right?
Yes - 0xb0000000 looks like it's a virtual address which is wrong.
Rule #1: Put physical addresses in headers and code only.
Rule #2: If using one of the KSEG address and address conversion macros,
get rid of them, use ioremap. The KSEG macros are for use by arch core
code only; for use anywhere else I reject patches these days.
Ralf
next prev parent reply other threads:[~2011-02-16 1:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 19:09 [PATCH] ath5k: Use mips generic dma-mapping functions to avoid seqfault on AHB chips Nikolay Ledovskikh
2011-02-15 19:40 ` Jiri Slaby
[not found] ` <AANLkTiks9rG2CzM2LabNerK3zgJ+R+weytQgvXxDbNe7@mail.gmail.com>
2011-02-15 20:42 ` Jiri Slaby
2011-02-15 20:57 ` Nikolay Ledovskikh
2011-02-15 21:03 ` Jiri Slaby
2011-02-15 21:18 ` Nikolay Ledovskikh
2011-02-15 21:39 ` Nikolay Ledovskikh
2011-02-15 22:16 ` Jiri Slaby
2011-02-15 22:18 ` Jiri Slaby
2011-02-16 1:12 ` Ralf Baechle [this message]
2011-02-16 10:26 ` Nikolay Ledovskikh
2011-02-23 10:18 ` Wojciech Dubowik
[not found] <AANLkTi=6jVGZx0oQdMQmndCB9k_xPywfntsB1LS_4ekM@mail.gmail.com>
2011-02-15 18:58 ` John W. Linville
[not found] <AANLkTinqN4MjWz4y5D195f9J8vob42GsG9u39xX-RuJf@mail.gmail.com>
2011-02-15 14:44 ` me
2011-02-15 14:49 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110216011203.GA5773@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=jirislaby@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=me@bobcopeland.com \
--cc=mickflemm@gmail.com \
--cc=nledovskikh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.