All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@gmail.com>
To: me@bobcopeland.com
Cc: "Николай Ледовских" <nledovskikh@gmail.com>,
	linville@tuxdriver.com, ath5k-devel@lists.ath5k.org,
	linux-wireless@vger.kernel.org, lrodriguez@atheros.com,
	mickflemm@gmail.com
Subject: Re: [PATCH] ath5k: Use mips generic dma-mapping functions to avoid seqfault on AHB chips
Date: Tue, 15 Feb 2011 15:49:30 +0100	[thread overview]
Message-ID: <4D5A927A.7060208@gmail.com> (raw)
In-Reply-To: <20110215144445.GA6066@hash.localnet>

On 02/15/2011 03:44 PM, me@bobcopeland.com wrote:
> On Tue, Feb 15, 2011 at 02:29:13PM +0000, Николай Ледовских wrote:
>> -    mem = ioremap_nocache(res->start, res->end - res->start + 1);
>> +    mem = res->start;
> 
> Won't this break iommu platforms?

And not only those. This is incorrect on _all_ platforms. You try to
dereference a physical address.

regards,
-- 
js

  reply	other threads:[~2011-02-15 14:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <AANLkTinqN4MjWz4y5D195f9J8vob42GsG9u39xX-RuJf@mail.gmail.com>
2011-02-15 14:44 ` [PATCH] ath5k: Use mips generic dma-mapping functions to avoid seqfault on AHB chips me
2011-02-15 14:49   ` Jiri Slaby [this message]
2011-02-15 22:05 ` [ath5k-devel] " Hugh Davenport
     [not found] <AANLkTi=6jVGZx0oQdMQmndCB9k_xPywfntsB1LS_4ekM@mail.gmail.com>
2011-02-15 18:58 ` John W. Linville
2011-02-15 19:09 Nikolay Ledovskikh
2011-02-15 19:40 ` Jiri Slaby
     [not found]   ` <AANLkTiks9rG2CzM2LabNerK3zgJ+R+weytQgvXxDbNe7@mail.gmail.com>
2011-02-15 20:42     ` Jiri Slaby
2011-02-15 20:57       ` Nikolay Ledovskikh
2011-02-15 21:03         ` Jiri Slaby
2011-02-15 21:18           ` Nikolay Ledovskikh
2011-02-15 21:39       ` Nikolay Ledovskikh
2011-02-15 22:16         ` Jiri Slaby
2011-02-15 22:18           ` Jiri Slaby
2011-02-16  1:12             ` Ralf Baechle
2011-02-16 10:26               ` Nikolay Ledovskikh
2011-02-23 10:18                 ` Wojciech Dubowik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D5A927A.7060208@gmail.com \
    --to=jirislaby@gmail.com \
    --cc=ath5k-devel@lists.ath5k.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=lrodriguez@atheros.com \
    --cc=me@bobcopeland.com \
    --cc=mickflemm@gmail.com \
    --cc=nledovskikh@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.