From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Matti J. Aaltonen" <matti.j.aaltonen@nokia.com>
Cc: alsa-devel@alsa-project.org, sameo@linux.intel.com,
mchehab@redhat.com, hverkuil@xs4all.nl, lrg@slimlogic.co.uk,
linux-media@vger.kernel.org
Subject: Re: [PATCH v19 3/3] ASoC: WL1273 FM radio: Access I2C IO functions through pointers.
Date: Tue, 15 Feb 2011 18:02:18 -0800 [thread overview]
Message-ID: <20110216020217.GB3021@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1297757626-3281-4-git-send-email-matti.j.aaltonen@nokia.com>
On Tue, Feb 15, 2011 at 10:13:46AM +0200, Matti J. Aaltonen wrote:
> if (core->i2s_mode != mode) {
> - r = wl1273_fm_write_cmd(core, WL1273_I2S_MODE_CONFIG_SET, mode);
> + r = core->write(core, WL1273_I2S_MODE_CONFIG_SET, mode);
I'm having a hard time loving the replacement of the function with the
direct dereference from the struct but overall this is a good win so:
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Matti J. Aaltonen" <matti.j.aaltonen@nokia.com>
Cc: alsa-devel@alsa-project.org, lrg@slimlogic.co.uk,
mchehab@redhat.com, hverkuil@xs4all.nl, sameo@linux.intel.com,
linux-media@vger.kernel.org
Subject: Re: [PATCH v19 3/3] ASoC: WL1273 FM radio: Access I2C IO functions through pointers.
Date: Tue, 15 Feb 2011 18:02:18 -0800 [thread overview]
Message-ID: <20110216020217.GB3021@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1297757626-3281-4-git-send-email-matti.j.aaltonen@nokia.com>
On Tue, Feb 15, 2011 at 10:13:46AM +0200, Matti J. Aaltonen wrote:
> if (core->i2s_mode != mode) {
> - r = wl1273_fm_write_cmd(core, WL1273_I2S_MODE_CONFIG_SET, mode);
> + r = core->write(core, WL1273_I2S_MODE_CONFIG_SET, mode);
I'm having a hard time loving the replacement of the function with the
direct dereference from the struct but overall this is a good win so:
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
next prev parent reply other threads:[~2011-02-16 2:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 8:13 [PATCH v19 0/3] TI Wl1273 FM radio driver Matti J. Aaltonen
2011-02-15 8:13 ` [PATCH v19 1/3] MFD: WL1273 FM Radio: MFD driver for the FM radio Matti J. Aaltonen
2011-02-15 8:13 ` [PATCH v19 2/3] V4L2: WL1273 FM Radio: TI WL1273 FM radio driver Matti J. Aaltonen
2011-02-15 8:13 ` [PATCH v19 3/3] ASoC: WL1273 FM radio: Access I2C IO functions through pointers Matti J. Aaltonen
2011-02-16 2:02 ` Mark Brown [this message]
2011-02-16 2:02 ` Mark Brown
2011-02-28 0:11 ` [PATCH v19 1/3] MFD: WL1273 FM Radio: MFD driver for the FM radio Samuel Ortiz
2011-02-15 19:59 ` [PATCH v19 0/3] TI Wl1273 FM radio driver Mauro Carvalho Chehab
2011-02-28 0:13 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110216020217.GB3021@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=matti.j.aaltonen@nokia.com \
--cc=mchehab@redhat.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.