* [PATCH] MIPS: Loongson: Kconfig: add MACH_LOONGSON dependency
@ 2011-02-17 8:26 Antony Pavlov
2011-02-17 9:46 ` Антон Павлов
0 siblings, 1 reply; 4+ messages in thread
From: Antony Pavlov @ 2011-02-17 8:26 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips, Antony Pavlov, Antony Pavlov
From: Antony Pavlov <antony@niisi.msk.ru>
The options LOONGSON_SUSPEND, LOONGSON_UART_BASE et al. don't depend
on MACH_LOONGSON option.
So my configuration file (.config) for MIPS Malta board contains
# CONFIG_MACH_LOONGSON is not set
CONFIG_MIPS_MALTA=y
...
CONFIG_LOONGSON_UART_BASE=y
Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
arch/mips/loongson/Kconfig | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/mips/loongson/Kconfig b/arch/mips/loongson/Kconfig
index 6e1b77f..4f2cf08 100644
--- a/arch/mips/loongson/Kconfig
+++ b/arch/mips/loongson/Kconfig
@@ -61,6 +61,7 @@ endchoice
config CS5536
bool
+ depends on MACH_LOONGSON
config CS5536_MFGPT
bool "CS5536 MFGPT Timer"
@@ -77,13 +78,14 @@ config CS5536_MFGPT
config LOONGSON_SUSPEND
bool
default y
- depends on CPU_SUPPORTS_CPUFREQ && SUSPEND
+ depends on MACH_LOONGSON && CPU_SUPPORTS_CPUFREQ && SUSPEND
config LOONGSON_UART_BASE
bool
default y
- depends on EARLY_PRINTK || SERIAL_8250
+ depends on MACH_LOONGSON && (EARLY_PRINTK || SERIAL_8250)
config LOONGSON_MC146818
bool
default n
+ depends on MACH_LOONGSON
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: Loongson: Kconfig: add MACH_LOONGSON dependency
2011-02-17 8:26 Antony Pavlov
@ 2011-02-17 9:46 ` Антон Павлов
0 siblings, 0 replies; 4+ messages in thread
From: Антон Павлов @ 2011-02-17 9:46 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips
Sorry, the mail adresses in fields "From" and "Signed-off-by" are different.
I shall resend the patch in a few minutes.
2011/2/17, Antony Pavlov <antonynpavlov@gmail.com>:
> From: Antony Pavlov <antony@niisi.msk.ru>
>
> The options LOONGSON_SUSPEND, LOONGSON_UART_BASE et al. don't depend
> on MACH_LOONGSON option.
> So my configuration file (.config) for MIPS Malta board contains
>
> # CONFIG_MACH_LOONGSON is not set
> CONFIG_MIPS_MALTA=y
>
> ...
>
> CONFIG_LOONGSON_UART_BASE=y
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
> arch/mips/loongson/Kconfig | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/mips/loongson/Kconfig b/arch/mips/loongson/Kconfig
> index 6e1b77f..4f2cf08 100644
> --- a/arch/mips/loongson/Kconfig
> +++ b/arch/mips/loongson/Kconfig
> @@ -61,6 +61,7 @@ endchoice
>
> config CS5536
> bool
> + depends on MACH_LOONGSON
>
> config CS5536_MFGPT
> bool "CS5536 MFGPT Timer"
> @@ -77,13 +78,14 @@ config CS5536_MFGPT
> config LOONGSON_SUSPEND
> bool
> default y
> - depends on CPU_SUPPORTS_CPUFREQ && SUSPEND
> + depends on MACH_LOONGSON && CPU_SUPPORTS_CPUFREQ && SUSPEND
>
> config LOONGSON_UART_BASE
> bool
> default y
> - depends on EARLY_PRINTK || SERIAL_8250
> + depends on MACH_LOONGSON && (EARLY_PRINTK || SERIAL_8250)
>
> config LOONGSON_MC146818
> bool
> default n
> + depends on MACH_LOONGSON
> --
> 1.7.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] MIPS: Loongson: Kconfig: add MACH_LOONGSON dependency
@ 2011-02-17 9:55 Antony Pavlov
2011-02-17 11:38 ` Ralf Baechle
0 siblings, 1 reply; 4+ messages in thread
From: Antony Pavlov @ 2011-02-17 9:55 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips, Antony Pavlov
The options LOONGSON_SUSPEND, LOONGSON_UART_BASE et al. don't depend
on MACH_LOONGSON option.
So my configuration file (.config) for MIPS Malta board contains
# CONFIG_MACH_LOONGSON is not set
CONFIG_MIPS_MALTA=y
...
CONFIG_LOONGSON_UART_BASE=y
Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
arch/mips/loongson/Kconfig | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/mips/loongson/Kconfig b/arch/mips/loongson/Kconfig
index 6e1b77f..4f2cf08 100644
--- a/arch/mips/loongson/Kconfig
+++ b/arch/mips/loongson/Kconfig
@@ -61,6 +61,7 @@ endchoice
config CS5536
bool
+ depends on MACH_LOONGSON
config CS5536_MFGPT
bool "CS5536 MFGPT Timer"
@@ -77,13 +78,14 @@ config CS5536_MFGPT
config LOONGSON_SUSPEND
bool
default y
- depends on CPU_SUPPORTS_CPUFREQ && SUSPEND
+ depends on MACH_LOONGSON && CPU_SUPPORTS_CPUFREQ && SUSPEND
config LOONGSON_UART_BASE
bool
default y
- depends on EARLY_PRINTK || SERIAL_8250
+ depends on MACH_LOONGSON && (EARLY_PRINTK || SERIAL_8250)
config LOONGSON_MC146818
bool
default n
+ depends on MACH_LOONGSON
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: Loongson: Kconfig: add MACH_LOONGSON dependency
2011-02-17 9:55 [PATCH] MIPS: Loongson: Kconfig: add MACH_LOONGSON dependency Antony Pavlov
@ 2011-02-17 11:38 ` Ralf Baechle
0 siblings, 0 replies; 4+ messages in thread
From: Ralf Baechle @ 2011-02-17 11:38 UTC (permalink / raw)
To: Antony Pavlov; +Cc: linux-mips
On Thu, Feb 17, 2011 at 12:55:44PM +0300, Antony Pavlov wrote:
> The options LOONGSON_SUSPEND, LOONGSON_UART_BASE et al. don't depend
> on MACH_LOONGSON option.
> So my configuration file (.config) for MIPS Malta board contains
>
> # CONFIG_MACH_LOONGSON is not set
> CONFIG_MIPS_MALTA=y
>
> ...
>
> CONFIG_LOONGSON_UART_BASE=y
Patch is looking good but commit 3a1f2f05e1759dd6a0876a7998408438d59d4a39
[ MIPS: Fix always CONFIG_LOONGSON_UART_BASE=y ] already fixes the issue.
Thanks!
Ralf
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-02-17 11:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-17 9:55 [PATCH] MIPS: Loongson: Kconfig: add MACH_LOONGSON dependency Antony Pavlov
2011-02-17 11:38 ` Ralf Baechle
-- strict thread matches above, loose matches on Subject: below --
2011-02-17 8:26 Antony Pavlov
2011-02-17 9:46 ` Антон Павлов
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.