From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Konrad Rzeszutek Wilk <konrad@kernel.org>,
Jeremy Fitzhardinge <jeremy@goop.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: [Xen-devel] [PATCH 1/3] pci/xen: Use xen_allocate_pirq_msi
Date: Thu, 17 Feb 2011 09:52:55 -0500 [thread overview]
Message-ID: <20110217145255.GA32341@dumpdata.com> (raw)
In-Reply-To: <1297932091.16356.1292.camel@zakaz.uk.xensource.com>
> All callers have this (type == MSIX) ? "msi-x" : "msi" construct,
> differing only in their use of a "pcifront-" prefix. Something which
> could be hoisted into the function perhaps?
I was thinking to defer this for a cleanup patch.
>
> Another aside: I think there are other cleanups which could be made to
> the various pirq allocation/mapping interfaces (of which there seem to
> be too many, or at least their individual unique qualities are
> indistinguishable by their names), I made a start on this at one point
> since I wanted to get rid of the pirq_to_irq[nr_irqs] array, for obvious
> reasons, but didn't finish it off. I'll hopefully revisit this soon.
Excellent. Looking forward to it.
next prev parent reply other threads:[~2011-02-17 14:53 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-16 22:17 [PATCH] Xen PCI fronted fixes for 2.6.39 Konrad Rzeszutek Wilk
2011-02-16 22:17 ` [PATCH 1/3] pci/xen: Use xen_allocate_pirq_msi Konrad Rzeszutek Wilk
2011-02-17 8:41 ` [Xen-devel] " Ian Campbell
2011-02-17 8:41 ` Ian Campbell
2011-02-17 14:30 ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-02-18 14:07 ` Konrad Rzeszutek Wilk
2011-02-18 14:11 ` Ian Campbell
2011-02-18 14:13 ` Stefano Stabellini
2011-02-18 14:13 ` Stefano Stabellini
2011-02-17 14:52 ` Konrad Rzeszutek Wilk [this message]
2011-02-18 16:43 ` [PATCH 0/12] xen: MSI managment cleanups (Was: Re: [PATCH 1/3] pci/xen: Use xen_allocate_pirq_msi) Ian Campbell
2011-02-18 16:43 ` [PATCH 01/12] xen: pci: only define xen_initdom_setup_msi_irqs if CONFIG_XEN_DOM0 Ian Campbell
2011-02-18 16:43 ` [PATCH 02/12] xen: events: do not leak IRQ from xen_allocate_pirq_msi when no pirq available Ian Campbell
2011-02-21 12:50 ` Stefano Stabellini
2011-02-21 13:40 ` Ian Campbell
2011-02-18 16:43 ` [PATCH 03/12] xen: events: drop XEN_ALLOC_IRQ flag to xen_allocate_pirq_msi Ian Campbell
2011-02-18 16:43 ` [PATCH 04/12] xen: events: return irq from xen_allocate_pirq_msi Ian Campbell
2011-02-18 16:43 ` [PATCH 05/12] xen: pci: collapse apic_register_gsi_xen_hvm and xen_hvm_register_pirq Ian Campbell
2011-02-18 16:43 ` [PATCH 06/12] xen: events: assume PHYSDEVOP_get_free_pirq exists Ian Campbell
2011-02-18 16:43 ` [PATCH 07/12] xen: events: separate MSI PIRQ allocation from PIRQ binding to IRQ Ian Campbell
2011-02-21 12:50 ` Stefano Stabellini
2011-02-21 13:39 ` Ian Campbell
2011-02-18 16:43 ` [PATCH 08/12] xen: events: refactor xen_create_msi_irq slightly Ian Campbell
2011-02-18 16:43 ` [PATCH 09/12] xen: events: update pirq_to_irq in xen_create_msi_irq Ian Campbell
2011-02-22 20:35 ` Konrad Rzeszutek Wilk
2011-02-23 13:20 ` Ian Campbell
2011-02-23 15:08 ` Konrad Rzeszutek Wilk
2011-02-23 15:57 ` Ian Campbell
2011-02-18 16:43 ` [PATCH 10/12] xen: events: push set_irq_msi down into xen_create_msi_irq Ian Campbell
2011-02-18 16:43 ` [PATCH 11/12] xen: events: use xen_bind_pirq_msi_to_irq from xen_create_msi_irq Ian Campbell
2011-02-18 16:43 ` [PATCH 12/12] xen: events: remove dom0 specific xen_create_msi_irq Ian Campbell
2011-02-18 17:00 ` Ian Campbell
2011-02-18 17:06 ` Ian Campbell
2011-02-16 22:17 ` [PATCH 2/3] xen-pcifront: Sanity check the MSI/MSI-X values Konrad Rzeszutek Wilk
2011-02-16 22:17 ` Konrad Rzeszutek Wilk
2011-02-17 8:53 ` [Xen-devel] " Ian Campbell
2011-02-18 14:08 ` Konrad Rzeszutek Wilk
2011-02-18 14:15 ` Ian Campbell
2011-02-18 14:20 ` Konrad Rzeszutek Wilk
2011-02-16 22:17 ` [PATCH 3/3] xen-pcifront: don't use flush_scheduled_work() Konrad Rzeszutek Wilk
2011-02-17 8:29 ` [Xen-devel] [PATCH] Xen PCI fronted fixes for 2.6.39 Ian Campbell
2011-02-17 14:28 ` Konrad Rzeszutek Wilk
2011-02-17 14:38 ` Ian Campbell
2011-02-17 14:38 ` Ian Campbell
2011-02-18 14:22 ` Konrad Rzeszutek Wilk
2011-02-18 14:22 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110217145255.GA32341@dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=Ian.Campbell@citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=jeremy@goop.org \
--cc=konrad@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.