From: Dmitry Torokhov <dtor@vmware.com>
To: David Miller <davem@davemloft.net>
Cc: "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"geert@linux-m68k.org" <geert@linux-m68k.org>,
"rusty@rustcorp.com.au" <rusty@rustcorp.com.au>,
"linux-m68k@vger.kernel.org" <linux-m68k@vger.kernel.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>
Subject: Re: [PATCH 1/3] module: deal with alignment issues in built-in module versions
Date: Thu, 17 Feb 2011 14:19:57 -0800 [thread overview]
Message-ID: <20110217221957.GA11244@dtor-ws.eng.vmware.com> (raw)
In-Reply-To: <20110217.140119.39175251.davem@davemloft.net>
On Thu, Feb 17, 2011 at 02:01:19PM -0800, David Miller wrote:
> From: Linus Torvalds <torvalds@linux-foundation.org>
> Date: Thu, 17 Feb 2011 13:54:57 -0800
>
> > Is there a -fdata-align or something? Or would __attribute__((packed))
> > help? Something that explicitly tells gcc "don't do this", instead of
> > "let's add indirection and hope gcc doesn't add alignment for _that_".
> > Especially as the extra pointer makes the code even uglier.
>
> The tracing folks went down the path of trying to use packed in
> various ways, to no avail, because no matter what they tried it broke
> other things.
>
> > And if we do have to use the pointer thing, let's at least then do the
> > pointer with asms, so that gcc _really_ can't screw it up. Rather than
> > just move the potential bug around.
>
> That's fine with me.
Any pointers as to how to emit these pointers with asm?
--
Dmitry
next prev parent reply other threads:[~2011-02-17 22:21 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-08 0:02 [PATCH 1/3] module: deal with alignment issues in built-in module versions Dmitry Torokhov
2011-02-08 0:02 ` [PATCH 2/3] module: deal with alignment issues in built-in module parameters Dmitry Torokhov
2011-02-08 0:02 ` [PATCH 3/3] module: do not hide __modver_version_show declaration behind ifdef Dmitry Torokhov
2011-02-08 21:12 ` [PATCH 1/3] module: deal with alignment issues in built-in module versions Geert Uytterhoeven
2011-02-08 21:12 ` Geert Uytterhoeven
2011-02-17 12:43 ` Geert Uytterhoeven
2011-02-17 12:43 ` Geert Uytterhoeven
2011-02-11 22:03 ` [PATCH v2] module: deal with alignment issues in built-in module parameters Dmitry Torokhov
2011-02-11 22:03 ` Dmitry Torokhov
2011-02-13 23:04 ` Rusty Russell
2011-02-17 17:24 ` [PATCH 1/3] module: deal with alignment issues in built-in module versions Linus Torvalds
2011-02-17 17:31 ` Dmitry Torokhov
2011-02-17 17:31 ` Dmitry Torokhov
2011-02-17 17:45 ` Linus Torvalds
2011-02-17 18:00 ` Dmitry Torokhov
2011-02-17 18:06 ` Linus Torvalds
2011-02-17 21:01 ` David Miller
2011-02-17 21:11 ` Linus Torvalds
2011-02-17 21:17 ` David Miller
2011-02-17 21:54 ` Linus Torvalds
2011-02-17 22:01 ` David Miller
2011-02-17 22:19 ` Dmitry Torokhov [this message]
2011-02-17 22:23 ` David Miller
2011-02-17 22:48 ` Linus Torvalds
2011-02-17 23:08 ` Linus Torvalds
2011-02-17 23:19 ` David Miller
2011-02-19 0:14 ` Benjamin Herrenschmidt
2011-02-21 4:00 ` Rusty Russell
2011-02-21 7:38 ` Geert Uytterhoeven
2011-02-21 7:49 ` Dmitry Torokhov
2011-02-21 7:49 ` Dmitry Torokhov
2011-02-21 13:25 ` Geert Uytterhoeven
2011-02-22 1:58 ` Benjamin Herrenschmidt
2011-02-22 2:03 ` Linus Torvalds
2011-02-22 7:02 ` Dmitry Torokhov
2011-02-22 7:02 ` Dmitry Torokhov
2011-02-22 17:08 ` Jesper Nilsson
2011-02-22 20:47 ` Linus Torvalds
2011-02-23 15:00 ` Jesper Nilsson
2011-02-23 15:00 ` Jesper Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110217221957.GA11244@dtor-ws.eng.vmware.com \
--to=dtor@vmware.com \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.