From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 4/4] hp_accel: Fix driver name
Date: Sat, 19 Feb 2011 18:20:16 +0000 [thread overview]
Message-ID: <20110219182016.GA1038@ericsson.com> (raw)
In-Reply-To: <20110219142832.1516d1ee@endymion.delvare>
On Sat, Feb 19, 2011 at 08:28:32AM -0500, Jean Delvare wrote:
> I suspect that the "lis3lv02d" driver name is a legacy from before
> the split into several modules. Use a specific name for the hp_accel
> driver, for better error messages and easier investigation of issues.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Eric Piel <eric.piel@tremplin-utc.net>
> Cc: Guenter Roeck <guenter.roeck@ericsson.com>
> ---
> Not tested due to lack of hardware.
>
> drivers/platform/x86/hp_accel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.38-rc5.orig/drivers/platform/x86/hp_accel.c 2011-02-19 13:28:46.000000000 +0100
> +++ linux-2.6.38-rc5/drivers/platform/x86/hp_accel.c 2011-02-19 13:39:49.000000000 +0100
> @@ -39,7 +39,7 @@
> #include <acpi/acpi_drivers.h>
> #include "../../misc/lis3lv02d/lis3lv02d.h"
>
> -#define DRIVER_NAME "lis3lv02d"
> +#define DRIVER_NAME "hp_accel"
> #define ACPI_MDPS_CLASS "accelerometer"
>
Not sure if you can do that, given the close interrelation with lis3lv02d.c.
That really asks for testing on a real system.
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2011-02-19 18:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-19 13:28 [lm-sensors] [PATCH 4/4] hp_accel: Fix driver name Jean Delvare
2011-02-19 18:20 ` Guenter Roeck [this message]
2011-02-19 20:11 ` Jean Delvare
2011-02-19 20:48 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110219182016.GA1038@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.