From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 4/4] hp_accel: Fix driver name
Date: Sat, 19 Feb 2011 20:48:31 +0000 [thread overview]
Message-ID: <20110219204831.GC1728@ericsson.com> (raw)
In-Reply-To: <20110219142832.1516d1ee@endymion.delvare>
On Sat, Feb 19, 2011 at 03:11:14PM -0500, Jean Delvare wrote:
[ ... ]
> >
> > Not sure if you can do that, given the close interrelation with lis3lv02d.c.
>
> I was a little worried about this at first, but then noticed that the
> string is (almost) only used as the name of the acpi driver and device.
> The lis3lv02d core driver doesn't deal with ACPI at all, so it
> shouldn't make a difference. Also, the lis3lv02d_i2c and lis3lv02d_spi
> drivers do have different driver name strings, which implies that there
> is no requirement for a common driver name string.
>
> > That really asks for testing on a real system.
>
> I agree still. The only problem I can think of is if user-space expects
> a specific ACPI driver and/or device name. Note that, in the event this
> one patch causes trouble, I'll simply drop it. I noticed what I think
> is an improper driver name while working on the driver, but what I
> really care about is moving these drivers out of drivers/hwmon, i.e.
> the first 3 patches of the set.
>
Makes sense.
Still,
Acked-by: Guenter Roeck <guenter.roeck@ericsson.com>
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2011-02-19 20:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-19 13:28 [lm-sensors] [PATCH 4/4] hp_accel: Fix driver name Jean Delvare
2011-02-19 18:20 ` Guenter Roeck
2011-02-19 20:11 ` Jean Delvare
2011-02-19 20:48 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110219204831.GC1728@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.