All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] i2c-eg20t: fix sparse warnings
@ 2011-02-20 21:40 Stephen Hemminger
  0 siblings, 0 replies; only message in thread
From: Stephen Hemminger @ 2011-02-20 21:40 UTC (permalink / raw)
  To: Jean Delvare (PC drivers, core); +Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA


drivers/i2c/busses/i2c-eg20t.c:477:5: warning: symbol 'pch_i2c_readbytes' was not declared. Should it be static?
drivers/i2c/busses/i2c-eg20t.c:804:42: warning: Using plain integer as NULL pointer

Signed-off-by: Stephen Hemminger <shemminger-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>


--- a/drivers/i2c/busses/i2c-eg20t.c	2011-02-20 13:24:43.445948555 -0800
+++ b/drivers/i2c/busses/i2c-eg20t.c	2011-02-20 13:25:14.915448908 -0800
@@ -474,8 +474,8 @@ static void pch_i2c_sendnack(struct i2c_
  * @last:	specifies whether last message or not.
  * @first:	specifies whether first message or not.
  */
-s32 pch_i2c_readbytes(struct i2c_adapter *i2c_adap, struct i2c_msg *msgs,
-		  u32 last, u32 first)
+static s32 pch_i2c_readbytes(struct i2c_adapter *i2c_adap, struct i2c_msg *msgs,
+			     u32 last, u32 first)
 {
 	struct i2c_algo_pch_data *adap = i2c_adap->algo_data;
 
@@ -801,7 +801,7 @@ static void __devexit pch_i2c_remove(str
 
 	if (adap_info->pch_data.pch_base_address) {
 		pci_iounmap(pdev, adap_info->pch_data.pch_base_address);
-		adap_info->pch_data.pch_base_address = 0;
+		adap_info->pch_data.pch_base_address = NULL;
 	}
 
 	pci_set_drvdata(pdev, NULL);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-02-20 21:40 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-20 21:40 [PATCH] i2c-eg20t: fix sparse warnings Stephen Hemminger

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.