From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
Alan Cox <alan@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging/et131x: fix et131x_rx_dma_disable halt_status usage
Date: Sun, 20 Feb 2011 19:13:07 +0000 [thread overview]
Message-ID: <20110220191307.07faacda@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20110220190334.GA3825@joi.lan>
On Sun, 20 Feb 2011 20:03:34 +0100
Marcin Slusarz <marcin.slusarz@gmail.com> wrote:
> Commit 1bd751c1abc1029e8a0ae63ef4f19357c735a2a3
> ("Staging: et131x: Clean up rxdma_csr") changed csr from bitfield to
> u32, but failed to convert 2 uses of halt_status bit. It did:
>
> - if (csr.bits.halt_status != 1)
> + if ((csr & 0x00020000) != 1)
>
> which is wrong, because second version is always true.
> Fix it.
>
> This bug was found by coccinelle (http://coccinelle.lip6.fr/).
>
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> Cc: Alan Cox <alan@linux.intel.com>
> Cc: Greg Kroah-Hartman <gregkh@suse.de>
Acked-by: Alan Cox <alan@linux.intel.com>
prev parent reply other threads:[~2011-02-20 19:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-20 19:03 [PATCH] staging/et131x: fix et131x_rx_dma_disable halt_status usage Marcin Slusarz
2011-02-20 19:13 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110220191307.07faacda@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=alan@linux.intel.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.