From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 3/4] ARM: Xilinx: base header files and assembly macros
Date: Sun, 20 Feb 2011 22:37:47 +0100 [thread overview]
Message-ID: <201102202237.47327.arnd@arndb.de> (raw)
In-Reply-To: <42efee69-aca1-446b-a997-f0063e113877@VA3EHSMHS009.ehs.local>
On Friday 18 February 2011, John Linn wrote:
> +
> +/* IO address mapping macros, nothing special at this time but required */
> +
> +#ifdef __ASSEMBLER__
> +#define IOMEM(x) (x)
> +#else
> +#define IOMEM(x) ((void __force __iomem *)(x))
> +#endif
> +
> +#define __io(a) __typesafe_io(a)
> +#define __mem_pci(a) (a)
Are you planning to support PCI or PCMCIA? If so, the __io definition will have to
change so it points to the PIO register window.
> diff --git a/arch/arm/mach-xilinx/include/mach/timex.h b/arch/arm/mach-xilinx/include/mach/timex.h
> new file mode 100644
> index 0000000..4ebc0a6
> --- /dev/null
> +++ b/arch/arm/mach-xilinx/include/mach/timex.h
> +#ifndef __MACH_TIMEX_H__
> +#define __MACH_TIMEX_H__
> +
> +#define PERIPHERAL_CLOCK_RATE 2500000
> +
> +#define CLOCK_TICK_RATE (PERIPHERAL_CLOCK_RATE / 32)
> +
> +#endif
I thought we were at the point where CLOCK_TICK_RATE is no longer used.
Did the patches not make it in yet?
The rest looks fine to me.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: John Linn <john.linn@xilinx.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux@arm.linux.org.uk,
catalin.marinas@arm.com, glikely@secretlab.ca,
jamie@jamieiles.com
Subject: Re: [PATCH V4 3/4] ARM: Xilinx: base header files and assembly macros
Date: Sun, 20 Feb 2011 22:37:47 +0100 [thread overview]
Message-ID: <201102202237.47327.arnd@arndb.de> (raw)
In-Reply-To: <42efee69-aca1-446b-a997-f0063e113877@VA3EHSMHS009.ehs.local>
On Friday 18 February 2011, John Linn wrote:
> +
> +/* IO address mapping macros, nothing special at this time but required */
> +
> +#ifdef __ASSEMBLER__
> +#define IOMEM(x) (x)
> +#else
> +#define IOMEM(x) ((void __force __iomem *)(x))
> +#endif
> +
> +#define __io(a) __typesafe_io(a)
> +#define __mem_pci(a) (a)
Are you planning to support PCI or PCMCIA? If so, the __io definition will have to
change so it points to the PIO register window.
> diff --git a/arch/arm/mach-xilinx/include/mach/timex.h b/arch/arm/mach-xilinx/include/mach/timex.h
> new file mode 100644
> index 0000000..4ebc0a6
> --- /dev/null
> +++ b/arch/arm/mach-xilinx/include/mach/timex.h
> +#ifndef __MACH_TIMEX_H__
> +#define __MACH_TIMEX_H__
> +
> +#define PERIPHERAL_CLOCK_RATE 2500000
> +
> +#define CLOCK_TICK_RATE (PERIPHERAL_CLOCK_RATE / 32)
> +
> +#endif
I thought we were at the point where CLOCK_TICK_RATE is no longer used.
Did the patches not make it in yet?
The rest looks fine to me.
Arnd
next prev parent reply other threads:[~2011-02-20 21:37 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1298052881-14591-1-git-send-email-john.linn@xilinx.com>
2011-02-18 18:14 ` [PATCH V4 1/4] ARM: Xilinx: Adding Xilinx board support John Linn
2011-02-18 18:14 ` John Linn
2011-02-28 11:06 ` Jamie Iles
2011-02-28 11:06 ` Jamie Iles
2011-02-28 14:13 ` John Linn
2011-02-28 14:13 ` John Linn
[not found] ` <1298052881-14591-2-git-send-email-john.linn@xilinx.com>
2011-02-18 18:14 ` [PATCH V4 2/4] ARM: Xilinx: Adding timer support to the platform John Linn
2011-02-18 18:14 ` John Linn
2011-02-28 11:11 ` Jamie Iles
2011-02-28 11:11 ` Jamie Iles
2011-02-28 14:14 ` John Linn
2011-02-28 14:14 ` John Linn
[not found] ` <1298052881-14591-3-git-send-email-john.linn@xilinx.com>
2011-02-18 18:14 ` [PATCH V4 3/4] ARM: Xilinx: base header files and assembly macros John Linn
2011-02-18 18:14 ` John Linn
2011-02-20 21:37 ` Arnd Bergmann [this message]
2011-02-20 21:37 ` Arnd Bergmann
2011-02-21 0:18 ` John Linn
2011-02-21 0:18 ` John Linn
2011-02-21 8:36 ` Arnd Bergmann
2011-02-21 8:36 ` Arnd Bergmann
2011-02-21 14:36 ` John Linn
2011-02-21 14:36 ` John Linn
2011-02-21 14:48 ` Arnd Bergmann
2011-02-21 14:48 ` Arnd Bergmann
2011-02-21 15:04 ` John Linn
2011-02-21 15:04 ` John Linn
2011-02-21 15:17 ` Russell King - ARM Linux
2011-02-21 15:17 ` Russell King - ARM Linux
2011-02-21 21:08 ` CLOCK_TICK_RATE, was: " Arnd Bergmann
2011-02-21 21:08 ` Arnd Bergmann
2011-02-21 21:51 ` Thomas Gleixner
2011-02-21 21:51 ` Thomas Gleixner
2011-02-28 11:18 ` Jamie Iles
2011-02-28 11:18 ` Jamie Iles
2011-02-28 14:20 ` John Linn
2011-02-28 14:20 ` John Linn
2011-02-28 15:01 ` Jamie Iles
2011-02-28 15:01 ` Jamie Iles
2011-02-28 11:20 ` Russell King - ARM Linux
2011-02-28 11:20 ` Russell King - ARM Linux
2011-02-28 14:22 ` [PATCH V4 3/4] ARM: Xilinx: base header files and assemblymacros John Linn
2011-02-28 14:22 ` John Linn
[not found] ` <1298052881-14591-4-git-send-email-john.linn@xilinx.com>
2011-02-18 18:14 ` [PATCH V4 4/4] ARM: Xilinx: Adding Xilinx platform infrastructure support John Linn
2011-02-18 18:14 ` John Linn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102202237.47327.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.