* [PATCH 16/23] ath9k_htc: Disable powersave if an AP interface is present
@ 2011-02-21 2:19 Sujith
2011-02-21 5:17 ` Vasanthakumar Thiagarajan
0 siblings, 1 reply; 3+ messages in thread
From: Sujith @ 2011-02-21 2:19 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Sujith.Manoharan
From: Sujith Manoharan <Sujith.Manoharan@atheros.com>
Signed-off-by: Sujith Manoharan <Sujith.Manoharan@atheros.com>
---
drivers/net/wireless/ath/ath9k/htc_drv_main.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
index f384b35..4779bb1 100644
--- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c
+++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
@@ -1393,7 +1393,8 @@ static int ath9k_htc_config(struct ieee80211_hw *hw, u32 changed)
}
- if (changed & IEEE80211_CONF_CHANGE_PS) {
+ if ((priv->ah->opmode != NL80211_IFTYPE_AP) &&
+ (changed & IEEE80211_CONF_CHANGE_PS)) {
if (conf->flags & IEEE80211_CONF_PS) {
ath9k_htc_setpower(priv, ATH9K_PM_NETWORK_SLEEP);
priv->ps_enabled = true;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 16/23] ath9k_htc: Disable powersave if an AP interface is present
2011-02-21 2:19 [PATCH 16/23] ath9k_htc: Disable powersave if an AP interface is present Sujith
@ 2011-02-21 5:17 ` Vasanthakumar Thiagarajan
2011-02-21 7:42 ` Sujith
0 siblings, 1 reply; 3+ messages in thread
From: Vasanthakumar Thiagarajan @ 2011-02-21 5:17 UTC (permalink / raw)
To: Sujith
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
Sujith Manoharan
On Mon, Feb 21, 2011 at 07:49:46AM +0530, Sujith wrote:
> From: Sujith Manoharan <Sujith.Manoharan@atheros.com>
>
> Signed-off-by: Sujith Manoharan <Sujith.Manoharan@atheros.com>
> ---
> drivers/net/wireless/ath/ath9k/htc_drv_main.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> index f384b35..4779bb1 100644
> --- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> @@ -1393,7 +1393,8 @@ static int ath9k_htc_config(struct ieee80211_hw *hw, u32 changed)
>
> }
>
> - if (changed & IEEE80211_CONF_CHANGE_PS) {
> + if ((priv->ah->opmode != NL80211_IFTYPE_AP) &&
> + (changed & IEEE80211_CONF_CHANGE_PS)) {
> if (conf->flags & IEEE80211_CONF_PS) {
> ath9k_htc_setpower(priv, ATH9K_PM_NETWORK_SLEEP);
> priv->ps_enabled = true;
Is it not that mac80211 already takes care of that?.
Vasanth
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 16/23] ath9k_htc: Disable powersave if an AP interface is present
2011-02-21 5:17 ` Vasanthakumar Thiagarajan
@ 2011-02-21 7:42 ` Sujith
0 siblings, 0 replies; 3+ messages in thread
From: Sujith @ 2011-02-21 7:42 UTC (permalink / raw)
To: Vasanthakumar Thiagarajan
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Vasanthakumar Thiagarajan wrote:
> On Mon, Feb 21, 2011 at 07:49:46AM +0530, Sujith wrote:
> > From: Sujith Manoharan <Sujith.Manoharan@atheros.com>
> >
> > Signed-off-by: Sujith Manoharan <Sujith.Manoharan@atheros.com>
> > ---
> > drivers/net/wireless/ath/ath9k/htc_drv_main.c | 3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> > index f384b35..4779bb1 100644
> > --- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> > +++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> > @@ -1393,7 +1393,8 @@ static int ath9k_htc_config(struct ieee80211_hw *hw, u32 changed)
> >
> > }
> >
> > - if (changed & IEEE80211_CONF_CHANGE_PS) {
> > + if ((priv->ah->opmode != NL80211_IFTYPE_AP) &&
> > + (changed & IEEE80211_CONF_CHANGE_PS)) {
> > if (conf->flags & IEEE80211_CONF_PS) {
> > ath9k_htc_setpower(priv, ATH9K_PM_NETWORK_SLEEP);
> > priv->ps_enabled = true;
>
> Is it not that mac80211 already takes care of that?.
Yeah, it appears to have been fixed recently in mac80211.
So this patch can be dropped.
Sujith
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-02-21 7:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-21 2:19 [PATCH 16/23] ath9k_htc: Disable powersave if an AP interface is present Sujith
2011-02-21 5:17 ` Vasanthakumar Thiagarajan
2011-02-21 7:42 ` Sujith
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.