All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wu Fengguang <fengguang.wu@intel.com>
To: "Lu, Guanqun" <guanqun.lu@intel.com>
Cc: "tiwai@suse.de" <tiwai@suse.de>, "tj@kernel.org" <tj@kernel.org>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"broonie@opensource.wolfsonmicro.com"
	<broonie@opensource.wolfsonmicro.com>,
	"mranostay@embeddedalley.com" <mranostay@embeddedalley.com>
Subject: Re: [PATCH] fix one memory leak in sound jack
Date: Mon, 21 Feb 2011 13:56:45 +0800	[thread overview]
Message-ID: <20110221055645.GA7972@localhost> (raw)
In-Reply-To: <1298267104-28697-1-git-send-email-guanqun.lu@intel.com>

Guanqun, it helps to point out the commit that first introduced the
problem.

Reviewed-by: Wu Fengguang <fengguang.wu@intel.com>

On Mon, Feb 21, 2011 at 01:45:04PM +0800, Lu Guanqun wrote:
> Signed-off-by: Lu Guanqun <guanqun.lu@intel.com>
> ---
>  sound/core/jack.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/core/jack.c b/sound/core/jack.c
> index 4902ae5..53b53e9 100644
> --- a/sound/core/jack.c
> +++ b/sound/core/jack.c
> @@ -141,6 +141,7 @@ int snd_jack_new(struct snd_card *card, const char *id, int type,
>  
>  fail_input:
>  	input_free_device(jack->input_dev);
> +	kfree(jack->id);
>  	kfree(jack);
>  	return err;
>  }
> -- 
> 1.7.2.3

  reply	other threads:[~2011-02-21  5:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-21  5:45 [PATCH] fix one memory leak in sound jack Lu Guanqun
2011-02-21  5:56 ` Wu Fengguang [this message]
2011-02-21  8:35 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110221055645.GA7972@localhost \
    --to=fengguang.wu@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=guanqun.lu@intel.com \
    --cc=mranostay@embeddedalley.com \
    --cc=tiwai@suse.de \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.