* [PATCH] fix one memory leak in sound jack
@ 2011-02-21 5:45 Lu Guanqun
2011-02-21 5:56 ` Wu Fengguang
2011-02-21 8:35 ` Takashi Iwai
0 siblings, 2 replies; 3+ messages in thread
From: Lu Guanqun @ 2011-02-21 5:45 UTC (permalink / raw)
To: alsa-devel; +Cc: Lu Guanqun, tiwai, broonie, mranostay, tj, fengguang.wu
Signed-off-by: Lu Guanqun <guanqun.lu@intel.com>
---
sound/core/jack.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/core/jack.c b/sound/core/jack.c
index 4902ae5..53b53e9 100644
--- a/sound/core/jack.c
+++ b/sound/core/jack.c
@@ -141,6 +141,7 @@ int snd_jack_new(struct snd_card *card, const char *id, int type,
fail_input:
input_free_device(jack->input_dev);
+ kfree(jack->id);
kfree(jack);
return err;
}
--
1.7.2.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fix one memory leak in sound jack
2011-02-21 5:45 [PATCH] fix one memory leak in sound jack Lu Guanqun
@ 2011-02-21 5:56 ` Wu Fengguang
2011-02-21 8:35 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Wu Fengguang @ 2011-02-21 5:56 UTC (permalink / raw)
To: Lu, Guanqun
Cc: tiwai@suse.de, tj@kernel.org, alsa-devel@alsa-project.org,
broonie@opensource.wolfsonmicro.com, mranostay@embeddedalley.com
Guanqun, it helps to point out the commit that first introduced the
problem.
Reviewed-by: Wu Fengguang <fengguang.wu@intel.com>
On Mon, Feb 21, 2011 at 01:45:04PM +0800, Lu Guanqun wrote:
> Signed-off-by: Lu Guanqun <guanqun.lu@intel.com>
> ---
> sound/core/jack.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/core/jack.c b/sound/core/jack.c
> index 4902ae5..53b53e9 100644
> --- a/sound/core/jack.c
> +++ b/sound/core/jack.c
> @@ -141,6 +141,7 @@ int snd_jack_new(struct snd_card *card, const char *id, int type,
>
> fail_input:
> input_free_device(jack->input_dev);
> + kfree(jack->id);
> kfree(jack);
> return err;
> }
> --
> 1.7.2.3
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fix one memory leak in sound jack
2011-02-21 5:45 [PATCH] fix one memory leak in sound jack Lu Guanqun
2011-02-21 5:56 ` Wu Fengguang
@ 2011-02-21 8:35 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2011-02-21 8:35 UTC (permalink / raw)
To: Lu Guanqun; +Cc: tj, fengguang.wu, alsa-devel, broonie, mranostay
At Mon, 21 Feb 2011 13:45:04 +0800,
Lu Guanqun wrote:
>
> Signed-off-by: Lu Guanqun <guanqun.lu@intel.com>
Applied now. Thanks.
Takashi
> ---
> sound/core/jack.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/core/jack.c b/sound/core/jack.c
> index 4902ae5..53b53e9 100644
> --- a/sound/core/jack.c
> +++ b/sound/core/jack.c
> @@ -141,6 +141,7 @@ int snd_jack_new(struct snd_card *card, const char *id, int type,
>
> fail_input:
> input_free_device(jack->input_dev);
> + kfree(jack->id);
> kfree(jack);
> return err;
> }
> --
> 1.7.2.3
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-02-21 8:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-21 5:45 [PATCH] fix one memory leak in sound jack Lu Guanqun
2011-02-21 5:56 ` Wu Fengguang
2011-02-21 8:35 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.