From: Jarkko Nikula <jhnikula@gmail.com>
To: "Varadarajan, Charulatha" <charu@ti.com>
Cc: linux-omap@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH resend] omap: rx51: Add SI4713 FM transmitter
Date: Mon, 21 Feb 2011 09:54:21 +0200 [thread overview]
Message-ID: <20110221095421.6576a98d.jhnikula@gmail.com> (raw)
In-Reply-To: <AANLkTikR5v9_G3oyRjVP1oCcBo=hU+ikywximd=VDbDd@mail.gmail.com>
On Mon, 21 Feb 2011 13:10:59 +0530
"Varadarajan, Charulatha" <charu@ti.com> wrote:
> > + err = gpio_request_one(RX51_FMTX_IRQ, GPIOF_DIR_IN, "si4713 irq");
> > + if (err) {
> > + printk(KERN_ERR "Cannot request si4713 irq gpio. %d\n", err);
>
> use pr_err instead of printk.
>
Thanks, I was obviously blind, will send an update :-)
--
Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: jhnikula@gmail.com (Jarkko Nikula)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH resend] omap: rx51: Add SI4713 FM transmitter
Date: Mon, 21 Feb 2011 09:54:21 +0200 [thread overview]
Message-ID: <20110221095421.6576a98d.jhnikula@gmail.com> (raw)
In-Reply-To: <AANLkTikR5v9_G3oyRjVP1oCcBo=hU+ikywximd=VDbDd@mail.gmail.com>
On Mon, 21 Feb 2011 13:10:59 +0530
"Varadarajan, Charulatha" <charu@ti.com> wrote:
> > + ? ? ? err = gpio_request_one(RX51_FMTX_IRQ, GPIOF_DIR_IN, "si4713 irq");
> > + ? ? ? if (err) {
> > + ? ? ? ? ? ? ? printk(KERN_ERR "Cannot request si4713 irq gpio. %d\n", err);
>
> use pr_err instead of printk.
>
Thanks, I was obviously blind, will send an update :-)
--
Jarkko
next prev parent reply other threads:[~2011-02-21 7:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-18 14:45 [PATCH] omap: rx51: Add SI4713 FM transmitter Jarkko Nikula
2011-02-21 6:42 ` [PATCH resend] " Jarkko Nikula
2011-02-21 6:42 ` Jarkko Nikula
2011-02-21 7:40 ` Varadarajan, Charulatha
2011-02-21 7:40 ` Varadarajan, Charulatha
2011-02-21 7:54 ` Jarkko Nikula [this message]
2011-02-21 7:54 ` Jarkko Nikula
2011-02-21 8:09 ` [PATCHv2] " Jarkko Nikula
2011-02-21 8:09 ` Jarkko Nikula
2011-02-24 21:28 ` [PATCH resend] " Tony Lindgren
2011-02-24 21:28 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110221095421.6576a98d.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=charu@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.