All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Zhao <linuxzsc@gmail.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Richard Zhao <richard.zhao@freescale.com>,
	r65037@freescale.com, avorontsov@ru.mvista.com, eric@eukrea.com,
	Richard Zhu <Hong-Xing.Zhu@freescale.com>,
	linux-mmc@vger.kernel.org, w.sang@pengutronix.de,
	kernel@pengutronix.de, cjb@laptop.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/5] mmc: sdhci: add quirk SDHCI_QUIRK_FIX_NO_INT_IN_MULTI_BLK_IO
Date: Mon, 21 Feb 2011 20:26:27 +0800	[thread overview]
Message-ID: <20110221122627.GA2043@richard-laptop> (raw)
In-Reply-To: <20110221110624.GK14495@n2100.arm.linux.org.uk>

On Mon, Feb 21, 2011 at 11:06:24AM +0000, Russell King - ARM Linux wrote:
> On Mon, Feb 21, 2011 at 05:54:55PM +0800, Richard Zhao wrote:
> > +	if (host->quirks & SDHCI_QUIRK_FIX_NO_INT_IN_MULTI_BLK_IO) {
> > +		if (readl(host->ioaddr + SDHCI_VENDOR_SPEC) & 0x2)
> > +			writel(readl(host->ioaddr + SDHCI_VENDOR_SPEC) & ~0x2,
> > +					host->ioaddr + SDHCI_VENDOR_SPEC);
> 
> Is it necessary to read the register twice, or would:
> 
> 		u32 val = readl(host->ioaddr + SDHCI_VENDOR_SPEC);
> 		if (val & 0x02)
> 			writel(val & ~0x02, host->ioaddr + SDHCI_VENDOR_SPEC);
> 
> be clearer and more obvious?
correct. Thanks.

Richard
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: linuxzsc@gmail.com (Richard Zhao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] mmc: sdhci: add quirk SDHCI_QUIRK_FIX_NO_INT_IN_MULTI_BLK_IO
Date: Mon, 21 Feb 2011 20:26:27 +0800	[thread overview]
Message-ID: <20110221122627.GA2043@richard-laptop> (raw)
In-Reply-To: <20110221110624.GK14495@n2100.arm.linux.org.uk>

On Mon, Feb 21, 2011 at 11:06:24AM +0000, Russell King - ARM Linux wrote:
> On Mon, Feb 21, 2011 at 05:54:55PM +0800, Richard Zhao wrote:
> > +	if (host->quirks & SDHCI_QUIRK_FIX_NO_INT_IN_MULTI_BLK_IO) {
> > +		if (readl(host->ioaddr + SDHCI_VENDOR_SPEC) & 0x2)
> > +			writel(readl(host->ioaddr + SDHCI_VENDOR_SPEC) & ~0x2,
> > +					host->ioaddr + SDHCI_VENDOR_SPEC);
> 
> Is it necessary to read the register twice, or would:
> 
> 		u32 val = readl(host->ioaddr + SDHCI_VENDOR_SPEC);
> 		if (val & 0x02)
> 			writel(val & ~0x02, host->ioaddr + SDHCI_VENDOR_SPEC);
> 
> be clearer and more obvious?
correct. Thanks.

Richard
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2011-02-21 12:26 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-21  9:54 [PATCH 1/5] ARM: imx53: add sdhc pad settings Richard Zhao
2011-02-21  9:54 ` Richard Zhao
2011-02-21  9:54 ` [PATCH 2/5] ARM: imx51/53: add sdhc3/4 clock Richard Zhao
2011-02-21  9:54   ` Richard Zhao
2011-02-21 16:21   ` Sascha Hauer
2011-02-21 16:21     ` Sascha Hauer
2011-02-22  2:16     ` Richard Zhao
2011-02-22  2:16       ` Richard Zhao
2011-02-21  9:54 ` [PATCH 3/5] ARM: imx53_loco: add esdhc device support Richard Zhao
2011-02-21  9:54   ` Richard Zhao
2011-02-21  9:54 ` [PATCH 4/5] mm: sdhci-esdhc: remove SDHCI_QUIRK_NO_CARD_NO_RESET from ESDHC_DEFAULT_QUIRKS Richard Zhao
2011-02-21  9:54   ` Richard Zhao
2011-02-21 10:02   ` Wolfram Sang
2011-02-21 10:02     ` Wolfram Sang
2011-02-21  9:54 ` [PATCH 5/5] mmc: sdhci: add quirk SDHCI_QUIRK_FIX_NO_INT_IN_MULTI_BLK_IO Richard Zhao
2011-02-21  9:54   ` Richard Zhao
2011-02-21 10:04   ` Wolfram Sang
2011-02-21 10:04     ` Wolfram Sang
2011-02-21 10:18     ` Zhu Richard-R65037
2011-02-21 10:18       ` Zhu Richard-R65037
2011-02-21 10:46       ` Wolfram Sang
2011-02-21 10:46         ` Wolfram Sang
2011-02-21 11:09         ` Russell King - ARM Linux
2011-02-21 11:09           ` Russell King - ARM Linux
2011-02-21 11:15           ` Wolfram Sang
2011-02-21 11:15             ` Wolfram Sang
2011-02-22  2:21             ` Zhu Richard-R65037
2011-02-22  2:21               ` Zhu Richard-R65037
2011-02-22  5:56             ` Zhu Richard-R65037
2011-02-22  5:56               ` Zhu Richard-R65037
2011-02-22  2:26           ` Zhu Richard-R65037
2011-02-22  2:26             ` Zhu Richard-R65037
2011-02-21 11:06   ` Russell King - ARM Linux
2011-02-21 11:06     ` Russell King - ARM Linux
2011-02-21 12:26     ` Richard Zhao [this message]
2011-02-21 12:26       ` Richard Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110221122627.GA2043@richard-laptop \
    --to=linuxzsc@gmail.com \
    --cc=Hong-Xing.Zhu@freescale.com \
    --cc=avorontsov@ru.mvista.com \
    --cc=cjb@laptop.org \
    --cc=eric@eukrea.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=r65037@freescale.com \
    --cc=richard.zhao@freescale.com \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.