Re: [libvirt] [PATCH] libxenlight driver

["Daniel P. Berrange" <berrange@redhat.com>]

On Thu, Feb 17, 2011 at 06:28:36PM -0700, Jim Fehlig wrote:
> Here's the latest version of a libxenlight driver for libvirt.
> 
> I've added a per-domain libxl_ctx in addition to the driver wide
> context.  The former is stored in virDomainObject privateData and used
> for operations on the domain.  The latter is stored in driver private
> data and is used for non-domain related libxl calls, e.g. getVersion,
> getNodeInfo, etc.  This approach was suggested by Ian Jackson and
> Stefano Stabellini and appears to be working much better than a single,
> driver wide libxl_ctx.  I no longer have the restart issues described in
> the first patch posting [1].
> 
> Your review and comments are much appreciated!

I've not had a chance todo a proper review yet, but after skimming
the patch I think your impl / architecture looks pretty good.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|