From: Arnd Bergmann <arnd@arndb.de>
To: Guan Xuetao <gxt@mprc.pku.edu.cn>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
'Greg KH' <greg@kroah.com>
Subject: Re: [PATCH 09/12] unicore32 machine related files: hardware registers
Date: Tue, 22 Feb 2011 15:19:03 +0100 [thread overview]
Message-ID: <201102221519.03423.arnd@arndb.de> (raw)
In-Reply-To: <018601cbd29a$118b27c0$34a17740$@mprc.pku.edu.cn>
On Tuesday 22 February 2011, Guan Xuetao wrote:
> > > diff --git a/arch/unicore32/include/mach/hardware.h b/arch/unicore32/include/mach/hardware.h
> > > index 3fb7236..ebce7de 100644
> > > --- a/arch/unicore32/include/mach/hardware.h
> > > +++ b/arch/unicore32/include/mach/hardware.h
> > > @@ -17,19 +17,14 @@
> > >
> > > #include "PKUnity.h"
> > >
> > > -#define io_p2v(x) ((x) - PKUNITY_IOSPACE_BASE)
> > > -#define io_v2p(x) ((x) + PKUNITY_IOSPACE_BASE)
> > > +#define io_p2v(x) ((x) - PKUNITY_MMIO_BASE)
> > > +#define io_v2p(x) ((x) + PKUNITY_MMIO_BASE)
> > >
> I apply the patch as following:
>
> @@ -22,8 +22,7 @@
>
> #ifndef __ASSEMBLY__
>
> -# define __REG(x) (*((volatile unsigned long *)io_p2v(x)))
> -# define __PREG(x) (io_v2p((unsigned long)&(x)))
> +# define __REG(x) (void __iomem *)io_p2v(x)
The patch looks correct, but if you make the the definition for
PKUNITY_MMIO_BASE contain the cast to (void __iomem *), you no
longer need another cast.
> __REG reserved only for all registers prefix.
> And all using for __REG converted to readl/writel.
Fair enough.
Arnd
next prev parent reply other threads:[~2011-02-22 14:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-16 7:51 [PATCH 09/12] unicore32 machine related files: hardware registers Guan Xuetao
2011-02-16 7:51 ` Guan Xuetao
2011-02-17 16:59 ` Arnd Bergmann
2011-02-18 9:52 ` Guan Xuetao
2011-02-18 9:52 ` Guan Xuetao
2011-02-18 10:42 ` Arnd Bergmann
2011-02-22 14:09 ` Guan Xuetao
2011-02-22 14:09 ` Guan Xuetao
2011-02-22 14:19 ` Arnd Bergmann [this message]
2011-02-26 12:23 ` Guan Xuetao
2011-02-26 12:23 ` Guan Xuetao
2011-02-26 13:16 ` Arnd Bergmann
2011-02-27 3:35 ` Guan Xuetao
2011-02-27 3:35 ` Guan Xuetao
2011-02-27 17:15 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102221519.03423.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=greg@kroah.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.