From: Arnd Bergmann <arnd@arndb.de>
To: Guan Xuetao <gxt@mprc.pku.edu.cn>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
'Greg KH' <greg@kroah.com>
Subject: Re: [PATCH 09/12] unicore32 machine related files: hardware registers
Date: Sun, 27 Feb 2011 18:15:42 +0100 [thread overview]
Message-ID: <201102271815.42395.arnd@arndb.de> (raw)
In-Reply-To: <017d01cbd62f$53af8590$fb0e90b0$@mprc.pku.edu.cn>
On Sunday 27 February 2011, Guan Xuetao wrote:
> Please see following patch, __REG removed and __iomem added to io_p2v:
>
> diff --git a/arch/unicore32/include/mach/hardware.h b/arch/unicore32/include/mach/hardware.h
> index b71405a..b197b0b 100644
> --- a/arch/unicore32/include/mach/hardware.h
> +++ b/arch/unicore32/include/mach/hardware.h
> @@ -17,13 +17,10 @@
>
> #include "PKUnity.h"
>
> -#define io_p2v(x) ((x) - PKUNITY_MMIO_BASE)
> -#define io_v2p(x) ((x) + PKUNITY_MMIO_BASE)
> -
> #ifndef __ASSEMBLY__
> -
> -# define __REG(x) (void __iomem *)io_p2v(x)
> -
> +#define io_p2v(x) (void __iomem *)((x) - PKUNITY_MMIO_BASE)
> +#else
> +#define io_p2v(x) ((x) - PKUNITY_MMIO_BASE)
> #endif
>
> #define PCIBIOS_MIN_IO 0x4000 /* should lower than 64KB */
Yes, looks good!
Acked-by: Arnd Bergmann <arnd@arndb.de>
prev parent reply other threads:[~2011-02-27 17:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-16 7:51 [PATCH 09/12] unicore32 machine related files: hardware registers Guan Xuetao
2011-02-16 7:51 ` Guan Xuetao
2011-02-17 16:59 ` Arnd Bergmann
2011-02-18 9:52 ` Guan Xuetao
2011-02-18 9:52 ` Guan Xuetao
2011-02-18 10:42 ` Arnd Bergmann
2011-02-22 14:09 ` Guan Xuetao
2011-02-22 14:09 ` Guan Xuetao
2011-02-22 14:19 ` Arnd Bergmann
2011-02-26 12:23 ` Guan Xuetao
2011-02-26 12:23 ` Guan Xuetao
2011-02-26 13:16 ` Arnd Bergmann
2011-02-27 3:35 ` Guan Xuetao
2011-02-27 3:35 ` Guan Xuetao
2011-02-27 17:15 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102271815.42395.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=greg@kroah.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.