From: Tony Lindgren <tony@atomide.com>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] ARM: Fix compile after delay page freeing patch
Date: Tue, 22 Feb 2011 11:59:39 -0800 [thread overview]
Message-ID: <20110222195938.GR15225@atomide.com> (raw)
In-Reply-To: <4D6413D9.7080906@ru.mvista.com>
* Sergei Shtylyov <sshtylyov@mvista.com> [110222 11:51]:
> Hello.
>
> Tony Lindgren wrote:
>
> >Commit 06824ba824b3e9f2fedb38bee79af0643198ed7f
> >(ARM: tlb: delay page freeing for SMP and ARMv7 CPUs) causes
> >the following compile error for at least omap1_defconfig:
>
> >In file included from arch/arm/mm/init.c:27:
> >arch/arm/include/asm/tlb.h: In function 'tlb_flush_mmu':
> >arch/arm/include/asm/tlb.h:101: error: implicit declaration of function 'release_pages'
> >arch/arm/include/asm/tlb.h: In function 'tlb_remove_page':
> >arch/arm/include/asm/tlb.h:165: error: implicit declaration of function 'page_cache_release'
> >
> >Fix this by including pagemap.h.
> >
> >Signed-off-by: Tony Lindgren <tony@atomide.com>
> >
> >--- a/arch/arm/mm/init.c
> >+++ b/arch/arm/mm/init.c
> >@@ -19,6 +19,7 @@
> > #include <linux/gfp.h>
> > #include <linux/memblock.h>
> > #include <linux/sort.h>
> >+#include <linux/pagemap.h>
> > #include <asm/mach-types.h>
> > #include <asm/sections.h>
>
> Shouldn't you be #including it into tlb.h instead?
Hmm, pagemap.h actually seems to be there in tlb.h,
but in #ifndef CONFIG_MMU.
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Fix compile after delay page freeing patch
Date: Tue, 22 Feb 2011 11:59:39 -0800 [thread overview]
Message-ID: <20110222195938.GR15225@atomide.com> (raw)
In-Reply-To: <4D6413D9.7080906@ru.mvista.com>
* Sergei Shtylyov <sshtylyov@mvista.com> [110222 11:51]:
> Hello.
>
> Tony Lindgren wrote:
>
> >Commit 06824ba824b3e9f2fedb38bee79af0643198ed7f
> >(ARM: tlb: delay page freeing for SMP and ARMv7 CPUs) causes
> >the following compile error for at least omap1_defconfig:
>
> >In file included from arch/arm/mm/init.c:27:
> >arch/arm/include/asm/tlb.h: In function 'tlb_flush_mmu':
> >arch/arm/include/asm/tlb.h:101: error: implicit declaration of function 'release_pages'
> >arch/arm/include/asm/tlb.h: In function 'tlb_remove_page':
> >arch/arm/include/asm/tlb.h:165: error: implicit declaration of function 'page_cache_release'
> >
> >Fix this by including pagemap.h.
> >
> >Signed-off-by: Tony Lindgren <tony@atomide.com>
> >
> >--- a/arch/arm/mm/init.c
> >+++ b/arch/arm/mm/init.c
> >@@ -19,6 +19,7 @@
> > #include <linux/gfp.h>
> > #include <linux/memblock.h>
> > #include <linux/sort.h>
> >+#include <linux/pagemap.h>
> > #include <asm/mach-types.h>
> > #include <asm/sections.h>
>
> Shouldn't you be #including it into tlb.h instead?
Hmm, pagemap.h actually seems to be there in tlb.h,
but in #ifndef CONFIG_MMU.
Tony
next prev parent reply other threads:[~2011-02-22 19:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 19:43 [PATCH] ARM: Fix compile after delay page freeing patch Tony Lindgren
2011-02-22 19:43 ` Tony Lindgren
2011-02-22 19:51 ` Sergei Shtylyov
2011-02-22 19:51 ` Sergei Shtylyov
2011-02-22 19:59 ` Tony Lindgren [this message]
2011-02-22 19:59 ` Tony Lindgren
2011-02-22 20:01 ` Uwe Kleine-König
2011-02-22 20:01 ` Uwe Kleine-König
2011-02-22 19:59 ` Russell King - ARM Linux
2011-02-22 19:59 ` Russell King - ARM Linux
2011-02-22 20:10 ` Uwe Kleine-König
2011-02-22 20:10 ` Uwe Kleine-König
2011-02-22 20:18 ` Russell King - ARM Linux
2011-02-22 20:18 ` Russell King - ARM Linux
2011-02-22 20:26 ` [PATCH] ARM: fix build failure Uwe Kleine-König
2011-02-22 20:26 ` Uwe Kleine-König
2011-02-22 21:57 ` Tony Lindgren
2011-02-22 21:57 ` Tony Lindgren
2011-02-22 22:26 ` Russell King - ARM Linux
2011-02-22 22:26 ` Russell King - ARM Linux
2011-02-22 22:46 ` Uwe Kleine-König
2011-02-22 22:46 ` Uwe Kleine-König
2011-02-22 20:20 ` [PATCH] ARM: Fix compile after delay page freeing patch Tony Lindgren
2011-02-22 20:20 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110222195938.GR15225@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.