All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	"Kevin Hilman" <khilman@ti.com>,
	"Santosh Shilimkar" <santosh.shilimkar@ti.com>,
	"Benoît Cousson" <b-cousson@ti.com>
Subject: Re: [PATCH 7/8] OMAP2+: hwmod: add ability to late-init individual hwmods
Date: Wed, 23 Feb 2011 11:12:12 -0800	[thread overview]
Message-ID: <20110223191212.GA15225@atomide.com> (raw)
In-Reply-To: <20110223071152.5874.54222.stgit@twilight.localdomain>

Hi,

* Paul Walmsley <paul@pwsan.com> [110222 23:11]:
> --- a/arch/arm/mach-omap2/omap_hwmod.c
> +++ b/arch/arm/mach-omap2/omap_hwmod.c
> +int __init omap_hwmod_late_init_one(const char *oh_name)

How about the following naming changes to avoid confusion:

omap_hwmod_init			-> omap_hwmod_register
omap_hwmod_late_init		-> omap_hwmod_init
omap_hwmod_late_init_one	-> omap_hwmod_init_one

This is because "late_init" gets actually called very early
during the boot.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/8] OMAP2+: hwmod: add ability to late-init individual hwmods
Date: Wed, 23 Feb 2011 11:12:12 -0800	[thread overview]
Message-ID: <20110223191212.GA15225@atomide.com> (raw)
In-Reply-To: <20110223071152.5874.54222.stgit@twilight.localdomain>

Hi,

* Paul Walmsley <paul@pwsan.com> [110222 23:11]:
> --- a/arch/arm/mach-omap2/omap_hwmod.c
> +++ b/arch/arm/mach-omap2/omap_hwmod.c
> +int __init omap_hwmod_late_init_one(const char *oh_name)

How about the following naming changes to avoid confusion:

omap_hwmod_init			-> omap_hwmod_register
omap_hwmod_late_init		-> omap_hwmod_init
omap_hwmod_late_init_one	-> omap_hwmod_init_one

This is because "late_init" gets actually called very early
during the boot.

Regards,

Tony

  reply	other threads:[~2011-02-23 19:12 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-23  7:11 [PATCH 0/8] OMAP2+: hwmod/clockevent: allow late-init of individual hwmods Paul Walmsley
2011-02-23  7:11 ` Paul Walmsley
2011-02-23  7:11 ` [PATCH 1/8] OMAP2420: hwmod data: add dmtimer Paul Walmsley
2011-02-23  7:11   ` Paul Walmsley
2011-02-23  7:11 ` [PATCH 2/8] OMAP2430: " Paul Walmsley
2011-02-23  7:11   ` Paul Walmsley
2011-02-23  7:11 ` [PATCH 3/8] OMAP3: " Paul Walmsley
2011-02-23  7:11   ` Paul Walmsley
2011-02-23  7:11 ` [PATCH 4/8] OMAP2+: hwmod: find MPU initiator hwmod during in _register() Paul Walmsley
2011-02-23  7:11   ` Paul Walmsley
2011-02-23 14:38   ` Cousson, Benoit
2011-02-23 14:38     ` Cousson, Benoit
2011-02-24  9:16     ` Paul Walmsley
2011-02-24  9:16       ` Paul Walmsley
2011-02-23  7:11 ` [PATCH 5/8] OMAP2+: hwmod: allow multiple calls to omap_hwmod_init() Paul Walmsley
2011-02-23  7:11   ` Paul Walmsley
2011-02-23 14:46   ` Cousson, Benoit
2011-02-23 14:46     ` Cousson, Benoit
2011-02-23  7:11 ` [PATCH 6/8] OMAP2+: hwmod: ignore attempts to re-late-init a hwmod Paul Walmsley
2011-02-23  7:11   ` Paul Walmsley
2011-02-23  7:11 ` [PATCH 7/8] OMAP2+: hwmod: add ability to late-init individual hwmods Paul Walmsley
2011-02-23  7:11   ` Paul Walmsley
2011-02-23 19:12   ` Tony Lindgren [this message]
2011-02-23 19:12     ` Tony Lindgren
2011-02-24  9:06     ` Paul Walmsley
2011-02-24  9:06       ` Paul Walmsley
2011-02-23  7:11 ` [PATCH 8/8] OMAP2+: clockevent: late-init GPTIMER clockevent hwmod right before timer init Paul Walmsley
2011-02-23  7:11   ` Paul Walmsley
2011-02-23  8:53   ` [PATCH 8/8] OMAP2+: clockevent: late-init GPTIMER clockevent hwmodright " Santosh Shilimkar
2011-02-23  8:53     ` Santosh Shilimkar
2011-02-23 11:48     ` DebBarma, Tarun Kanti
2011-02-23 11:48       ` DebBarma, Tarun Kanti
2011-02-24  8:13     ` Paul Walmsley
2011-02-24  8:13       ` Paul Walmsley
2011-02-24  8:15       ` Paul Walmsley
2011-02-24  8:15         ` Paul Walmsley
2011-02-24  8:29         ` DebBarma, Tarun Kanti
2011-02-24  8:29           ` DebBarma, Tarun Kanti
2011-02-24  9:00           ` Paul Walmsley
2011-02-24  9:00             ` Paul Walmsley
2011-02-24 15:41           ` Tony Lindgren
2011-02-24 15:41             ` Tony Lindgren
2011-02-25 14:07             ` DebBarma, Tarun Kanti
2011-02-25 14:07               ` DebBarma, Tarun Kanti
2011-02-24  8:57         ` Santosh Shilimkar
2011-02-24  8:57           ` Santosh Shilimkar
2011-02-23  9:13   ` [PATCH 8/8] OMAP2+: clockevent: late-init GPTIMER clockevent hwmod right " DebBarma, Tarun Kanti
2011-02-23  9:13     ` DebBarma, Tarun Kanti
2011-02-24  8:18     ` Paul Walmsley
2011-02-24  8:18       ` Paul Walmsley
2011-02-23 14:28 ` [PATCH 0/8] OMAP2+: hwmod/clockevent: allow late-init of individual hwmods Cousson, Benoit
2011-02-23 14:28   ` Cousson, Benoit
2011-02-28  2:31   ` Paul Walmsley
2011-02-28  2:31     ` Paul Walmsley
2011-02-28 11:17     ` Cousson, Benoit
2011-02-28 11:17       ` Cousson, Benoit
2011-03-02 17:54       ` Tony Lindgren
2011-03-02 17:54         ` Tony Lindgren
2011-03-03 11:10         ` Cousson, Benoit
2011-03-03 11:10           ` Cousson, Benoit
2011-03-04 14:51           ` Cousson, Benoit
2011-03-04 14:51             ` Cousson, Benoit
2011-03-04 16:19             ` Tony Lindgren
2011-03-04 16:19               ` Tony Lindgren
2011-03-04 16:39               ` Cousson, Benoit
2011-03-04 16:39                 ` Cousson, Benoit
2011-03-04 16:42                 ` Paul Walmsley
2011-03-04 16:42                   ` Paul Walmsley
2011-03-04 16:48                 ` Santosh Shilimkar
2011-03-04 16:48                   ` Santosh Shilimkar
2011-02-23 19:12 ` Tony Lindgren
2011-02-23 19:12   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110223191212.GA15225@atomide.com \
    --to=tony@atomide.com \
    --cc=b-cousson@ti.com \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=santosh.shilimkar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.