From: Stanislaw Gruszka <sgruszka@redhat.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH] ath9k: correct ath9k_hw_set_interrupts
Date: Thu, 24 Feb 2011 10:39:13 +0100 [thread overview]
Message-ID: <20110224093912.GA2222@redhat.com> (raw)
In-Reply-To: <20110223212132.GC2729@tuxdriver.com>
On Wed, Feb 23, 2011 at 04:21:32PM -0500, John W. Linville wrote:
> On Mon, Feb 21, 2011 at 03:02:41PM +0100, Stanislaw Gruszka wrote:
> > Commit 4df3071ebd92ef7115b409da64d0eb405d24a631 "ath9k_hw: optimize
> > interrupt mask changes", changed ath9k_hw_set_interrupts function to
> > enable interrupts regardless of function argument, what could possibly
> > be wrong. Correct that behaviour and check "ints" arguments before
> > enabling interrupts, also disable interrupts if ints do not have
> > ATH9K_INT_GLOBAL flag set.
> >
> > Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
>
> Should this be Cc: stable at kernel.org?
I think no. 4df3071ebd92e is from .38-rc1 , this patch should
go to 38 if possible. If not, I'm still not sure about stable.
It does not fix any pratical issues for me, my ath9k device
work good with and without patch.
Stanislaw
WARNING: multiple messages have this Message-ID (diff)
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: "Luis R. Rodriguez" <lrodriguez@atheros.com>,
ath9k-devel@venema.h4ckr.net, linux-wireless@vger.kernel.org,
Felix Fietkau <nbd@openwrt.org>
Subject: Re: [PATCH] ath9k: correct ath9k_hw_set_interrupts
Date: Thu, 24 Feb 2011 10:39:13 +0100 [thread overview]
Message-ID: <20110224093912.GA2222@redhat.com> (raw)
In-Reply-To: <20110223212132.GC2729@tuxdriver.com>
On Wed, Feb 23, 2011 at 04:21:32PM -0500, John W. Linville wrote:
> On Mon, Feb 21, 2011 at 03:02:41PM +0100, Stanislaw Gruszka wrote:
> > Commit 4df3071ebd92ef7115b409da64d0eb405d24a631 "ath9k_hw: optimize
> > interrupt mask changes", changed ath9k_hw_set_interrupts function to
> > enable interrupts regardless of function argument, what could possibly
> > be wrong. Correct that behaviour and check "ints" arguments before
> > enabling interrupts, also disable interrupts if ints do not have
> > ATH9K_INT_GLOBAL flag set.
> >
> > Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
>
> Should this be Cc: stable@kernel.org?
I think no. 4df3071ebd92e is from .38-rc1 , this patch should
go to 38 if possible. If not, I'm still not sure about stable.
It does not fix any pratical issues for me, my ath9k device
work good with and without patch.
Stanislaw
next prev parent reply other threads:[~2011-02-24 9:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 14:02 [ath9k-devel] [PATCH] ath9k: correct ath9k_hw_set_interrupts Stanislaw Gruszka
2011-02-21 14:02 ` Stanislaw Gruszka
2011-02-23 21:21 ` [ath9k-devel] " John W. Linville
2011-02-23 21:21 ` John W. Linville
2011-02-24 9:39 ` Stanislaw Gruszka [this message]
2011-02-24 9:39 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110224093912.GA2222@redhat.com \
--to=sgruszka@redhat.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.