From: Andrew Morton <akpm@linux-foundation.org>
To: Petr Holasek <pholasek@redhat.com>,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Mel Gorman <mel@csn.ul.ie>, Wu Fengguang <fengguang.wu@intel.com>,
linux-mm@kvack.org
Subject: Re: [PATCH v2] hugetlbfs: correct handling of negative input to /proc/sys/vm/nr_hugepages
Date: Thu, 24 Feb 2011 14:13:35 -0800 [thread overview]
Message-ID: <20110224141335.978066c5.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110224141034.d2dfb7de.akpm@linux-foundation.org>
On Thu, 24 Feb 2011 14:10:34 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:
> On Tue, 22 Feb 2011 21:17:04 +0100
> Petr Holasek <pholasek@redhat.com> wrote:
>
> > When user insert negative value into /proc/sys/vm/nr_hugepages it will
> > result
> > in the setting a random number of HugePages in system
>
> Is this true? afacit the kernel will allocate as many pages as it can
> and will then set /proc/sys/vm/nr_hugepages to reflect the result.
> That's not random.
>
Assuming the above to be correct, I altered the changelog thusly:
: When the user inserts a negative value into /proc/sys/vm/nr_hugepages it
: will cause the kernel to allocate as many hugepages as possible and to
: then update /proc/meminfo to reflect this.
:
: This changes the behavior so that the negative input will result in
: nr_hugepages value being unchanged.
and given that, I don't really see why we should change the existing behaviour.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Petr Holasek <pholasek@redhat.com>,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Mel Gorman <mel@csn.ul.ie>, Wu Fengguang <fengguang.wu@intel.com>,
linux-mm@kvack.org
Subject: Re: [PATCH v2] hugetlbfs: correct handling of negative input to /proc/sys/vm/nr_hugepages
Date: Thu, 24 Feb 2011 14:13:35 -0800 [thread overview]
Message-ID: <20110224141335.978066c5.akpm@linux-foundation.org> (raw)
In-Reply-To: <20110224141034.d2dfb7de.akpm@linux-foundation.org>
On Thu, 24 Feb 2011 14:10:34 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:
> On Tue, 22 Feb 2011 21:17:04 +0100
> Petr Holasek <pholasek@redhat.com> wrote:
>
> > When user insert negative value into /proc/sys/vm/nr_hugepages it will
> > result
> > in the setting a random number of HugePages in system
>
> Is this true? afacit the kernel will allocate as many pages as it can
> and will then set /proc/sys/vm/nr_hugepages to reflect the result.
> That's not random.
>
Assuming the above to be correct, I altered the changelog thusly:
: When the user inserts a negative value into /proc/sys/vm/nr_hugepages it
: will cause the kernel to allocate as many hugepages as possible and to
: then update /proc/meminfo to reflect this.
:
: This changes the behavior so that the negative input will result in
: nr_hugepages value being unchanged.
and given that, I don't really see why we should change the existing behaviour.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-02-24 22:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 20:17 [PATCH v2] hugetlbfs: correct handling of negative input to /proc/sys/vm/nr_hugepages Petr Holasek
2011-02-22 20:17 ` Petr Holasek
2011-02-22 20:32 ` David Rientjes
2011-02-22 20:32 ` David Rientjes
2011-02-23 9:01 ` Mel Gorman
2011-02-23 9:01 ` Mel Gorman
2011-02-23 15:33 ` Eric B Munson
2011-02-24 8:16 ` Anton Arapov
2011-02-24 8:16 ` Anton Arapov
2011-02-24 17:02 ` Petr Holasek
2011-02-24 17:02 ` Petr Holasek
2011-02-24 22:10 ` Andrew Morton
2011-02-24 22:10 ` Andrew Morton
2011-02-24 22:13 ` Andrew Morton [this message]
2011-02-24 22:13 ` Andrew Morton
2011-02-25 17:30 ` Mel Gorman
2011-02-25 17:30 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110224141335.978066c5.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ak@linux.intel.com \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=pholasek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.