From: Andi Kleen <andi@firstfloor.org>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: Dave Hansen <dave@linux.vnet.ibm.com>,
Andi Kleen <andi@firstfloor.org>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 8/8] Add VM counters for transparent hugepages
Date: Fri, 25 Feb 2011 02:36:08 +0100 [thread overview]
Message-ID: <20110225013608.GL5818@one.firstfloor.org> (raw)
In-Reply-To: <20110224231449.GE23252@random.random>
> I've a micropreference in having it in split_huge_page succeeding path
> after __split_huge_page returns, as the __ function is where the
> brainer code is and statcode to me is annoying to read mixed in the
> more complex code. Not that it makes any practical difference though.
Thanks for the improvements.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Andrea Arcangeli <aarcange@redhat.com>
Cc: Dave Hansen <dave@linux.vnet.ibm.com>,
Andi Kleen <andi@firstfloor.org>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 8/8] Add VM counters for transparent hugepages
Date: Fri, 25 Feb 2011 02:36:08 +0100 [thread overview]
Message-ID: <20110225013608.GL5818@one.firstfloor.org> (raw)
In-Reply-To: <20110224231449.GE23252@random.random>
> I've a micropreference in having it in split_huge_page succeeding path
> after __split_huge_page returns, as the __ function is where the
> brainer code is and statcode to me is annoying to read mixed in the
> more complex code. Not that it makes any practical difference though.
Thanks for the improvements.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-02-25 1:36 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 1:51 Fix NUMA problems in transparent hugepages v2 Andi Kleen
2011-02-23 1:51 ` Andi Kleen
2011-02-23 1:51 ` [PATCH 1/8] Fix interleaving for " Andi Kleen
2011-02-23 1:51 ` Andi Kleen
2011-02-23 19:26 ` Christoph Lameter
2011-02-23 19:26 ` Christoph Lameter
2011-02-24 23:23 ` Andrea Arcangeli
2011-02-24 23:23 ` Andrea Arcangeli
2011-02-23 1:51 ` [PATCH 2/8] Change alloc_pages_vma to pass down the policy node for local policy Andi Kleen
2011-02-23 1:51 ` Andi Kleen
2011-02-23 1:51 ` [PATCH 3/8] Add alloc_page_vma_node Andi Kleen
2011-02-23 1:51 ` Andi Kleen
2011-02-23 1:51 ` [PATCH 4/8] Preserve original node for transparent huge page copies Andi Kleen
2011-02-23 1:51 ` Andi Kleen
2011-02-23 1:51 ` [PATCH 5/8] Use correct numa policy node for transparent hugepages Andi Kleen
2011-02-23 1:51 ` Andi Kleen
2011-02-23 1:52 ` [PATCH 6/8] Add __GFP_OTHER_NODE flag Andi Kleen
2011-02-23 1:52 ` Andi Kleen
2011-02-23 1:52 ` [PATCH 7/8] Use GFP_OTHER_NODE for transparent huge pages Andi Kleen
2011-02-23 1:52 ` Andi Kleen
2011-02-24 4:56 ` Andrea Arcangeli
2011-02-24 4:56 ` Andrea Arcangeli
2011-02-23 1:52 ` [PATCH 8/8] Add VM counters for transparent hugepages Andi Kleen
2011-02-23 1:52 ` Andi Kleen
2011-02-24 4:18 ` Andrea Arcangeli
2011-02-24 4:18 ` Andrea Arcangeli
2011-02-24 22:43 ` Dave Hansen
2011-02-24 22:43 ` Dave Hansen
2011-02-24 23:15 ` Andrea Arcangeli
2011-02-24 23:15 ` Andrea Arcangeli
2011-02-24 22:43 ` Dave Hansen
2011-02-24 22:43 ` Dave Hansen
2011-02-24 23:14 ` Andrea Arcangeli
2011-02-24 23:14 ` Andrea Arcangeli
2011-02-25 1:36 ` Andi Kleen [this message]
2011-02-25 1:36 ` Andi Kleen
2011-02-25 0:51 ` Andrea Arcangeli
2011-02-25 0:51 ` Andrea Arcangeli
2011-02-25 1:12 ` Andi Kleen
2011-02-25 1:12 ` Andi Kleen
2011-02-25 1:34 ` Andrea Arcangeli
2011-02-25 1:34 ` Andrea Arcangeli
-- strict thread matches above, loose matches on Subject: below --
2011-03-03 19:59 Fix NUMA problems in transparent hugepages and KSM Andi Kleen
2011-03-03 19:59 ` [PATCH 8/8] Add VM counters for transparent hugepages Andi Kleen
2011-03-03 19:59 ` Andi Kleen
2011-03-07 8:28 ` KOSAKI Motohiro
2011-03-07 8:28 ` KOSAKI Motohiro
2011-03-07 16:35 ` Andi Kleen
2011-03-07 16:35 ` Andi Kleen
2011-03-08 2:43 ` KOSAKI Motohiro
2011-03-08 2:43 ` KOSAKI Motohiro
2011-03-30 21:45 ` Andrew Morton
2011-03-30 21:45 ` Andrew Morton
2011-03-30 23:30 ` Andi Kleen
2011-03-30 23:30 ` Andi Kleen
2011-03-31 0:52 ` KOSAKI Motohiro
2011-03-31 0:52 ` KOSAKI Motohiro
2011-03-31 0:56 ` Andi Kleen
2011-03-31 0:56 ` Andi Kleen
2011-03-03 0:45 Fix NUMA problems in transparent hugepages and KSM Andi Kleen
2011-03-03 0:45 ` [PATCH 8/8] Add VM counters for transparent hugepages Andi Kleen
2011-03-03 0:45 ` Andi Kleen
2011-03-03 9:18 ` Johannes Weiner
2011-03-03 9:18 ` Johannes Weiner
2011-03-03 18:09 ` Andi Kleen
2011-03-03 18:09 ` Andi Kleen
2011-02-21 19:07 Fix NUMA problems in transparent hugepages and KSM Andi Kleen
2011-02-21 19:07 ` [PATCH 8/8] Add VM counters for transparent hugepages Andi Kleen
2011-02-21 19:07 ` Andi Kleen
2011-02-22 16:36 ` Dave Hansen
2011-02-22 16:36 ` Dave Hansen
2011-02-22 16:43 ` Andrea Arcangeli
2011-02-22 16:43 ` Andrea Arcangeli
2011-02-22 18:02 ` Andi Kleen
2011-02-22 18:02 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110225013608.GL5818@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.