From: Steffen Klassert <steffen.klassert@secunet.com>
To: Eric Paris <eparis@parisplace.org>
Cc: Paul Moore <paul.moore@hp.com>, James Morris <jmorris@namei.org>,
Eric Paris <eparis@redhat.com>,
linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov
Subject: Re: [PATCH 4/4 v2] selinux: xfrm - notify users on dropped packets
Date: Fri, 25 Feb 2011 10:56:48 +0100 [thread overview]
Message-ID: <20110225095648.GA6653@secunet.com> (raw)
In-Reply-To: <AANLkTimVMykzZDE07C4zxW=o+1_cWkrzDEHFOi5jAA0S@mail.gmail.com>
On Thu, Feb 24, 2011 at 09:51:04AM -0500, Eric Paris wrote:
> All printk() statement require a KERN_*. I've often heard upstream
> people say that every printk should only be printed if you expect the
> user to do something with it. If it doesn't give the user enough
> information to fix whatever the problem is, or know how to fix
> whatever the problem is, it's a bad printk. I don't know this code at
> all, but I'm pretty sure if I got those printk's I'd just feel
> dumb....
>
The problem with this patch is, that it was one of my debugging patches
when I tried to find out why my packets are dropped. It was not
contemplated to push it upstream when I wrote it. Then I thought it
would be good to print out a message if these packets are dropped
and I picked the patch from my debugging branch, which was a bad idea.
I think we should drop this patch entirely and focus on the remaining
3 paches for now, as they are real fixes. So I could resend the remaining
patches for another round of review, or does anybody want to thake them
as they are?
Steffen
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2011-02-25 9:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110223115343.GH20852@secunet.com>
[not found] ` <20110223115715.GL20852@secunet.com>
2011-02-23 14:56 ` [PATCH 4/4] selinux: xfrm - notify users on dropped packets Paul Moore
2011-02-24 7:33 ` Steffen Klassert
2011-02-24 8:22 ` [PATCH 4/4 v2] " Steffen Klassert
2011-02-24 14:51 ` Eric Paris
2011-02-25 9:56 ` Steffen Klassert [this message]
2011-02-25 20:07 ` Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110225095648.GA6653@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=eparis@parisplace.org \
--cc=eparis@redhat.com \
--cc=jmorris@namei.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul.moore@hp.com \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.