* [PATCH 2.6.37.2 1/1] crypto: Uninitialized variable fix.
@ 2011-02-25 17:58 Atul Sowani
2011-02-25 18:09 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Atul Sowani @ 2011-02-25 17:58 UTC (permalink / raw)
To: herbert, davem; +Cc: linux-crypto, gregkh
Array inter[4] was uninitialized in anubis_crypt() and was causing
compiler warning. Added the array initialization.
Signed-off-by: Atul Sowani <sowani@gmail.com>
---
diff a/crypto/anubis.c b/crypto/anubis.c
--- a/crypto/anubis.c 2011-02-25 04:39:00.000000000 +0530
+++ b/crypto/anubis.c 2011-02-25 23:07:12.000000000 +0530
@@ -578,7 +578,7 @@ static void anubis_crypt(u32 roundKey[AN
__be32 *dst = (__be32 *)ciphertext;
int i, r;
u32 state[4];
- u32 inter[4];
+ u32 inter[4] = { 0, 0, 0, 0 };
/*
* map plaintext block to cipher state (mu)
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 2.6.37.2 1/1] crypto: Uninitialized variable fix.
2011-02-25 17:58 [PATCH 2.6.37.2 1/1] crypto: Uninitialized variable fix Atul Sowani
@ 2011-02-25 18:09 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2011-02-25 18:09 UTC (permalink / raw)
To: Atul Sowani; +Cc: herbert, davem, linux-crypto
On Fri, Feb 25, 2011 at 11:28:28PM +0530, Atul Sowani wrote:
> Array inter[4] was uninitialized in anubis_crypt() and was causing
> compiler warning. Added the array initialization.
>
> Signed-off-by: Atul Sowani <sowani@gmail.com>
> ---
>
> diff a/crypto/anubis.c b/crypto/anubis.c
> --- a/crypto/anubis.c 2011-02-25 04:39:00.000000000 +0530
> +++ b/crypto/anubis.c 2011-02-25 23:07:12.000000000 +0530
> @@ -578,7 +578,7 @@ static void anubis_crypt(u32 roundKey[AN
> __be32 *dst = (__be32 *)ciphertext;
> int i, r;
> u32 state[4];
> - u32 inter[4];
> + u32 inter[4] = { 0, 0, 0, 0 };
That's nice, it looks like a bug in the compiler, preinitializing this
variable doesn't fix any real bug.
sorry,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-25 18:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-25 17:58 [PATCH 2.6.37.2 1/1] crypto: Uninitialized variable fix Atul Sowani
2011-02-25 18:09 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.