[PATCH 1/2] micro-uclibc: add xattr to distro features to fix build failure of libcap2

[PATCH 1/2] micro-uclibc: add xattr to distro features to fix build failure of libcap2

[Petr Štetiar]

cap_file.c:8:23: fatal error: sys/xattr.h: No such file or directory

Signed-off-by: Petr Štetiar <ynezz@true.cz>
---
 conf/distro/micro-uclibc.conf |    1 +
 conf/distro/micro.conf        |    2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/conf/distro/micro-uclibc.conf b/conf/distro/micro-uclibc.conf
index 85ea9b3..55b4ebd 100644
--- a/conf/distro/micro-uclibc.conf
+++ b/conf/distro/micro-uclibc.conf
@@ -12,6 +12,7 @@
 #############################################################################
 
 DISTRO_NAME = "micro-uclibc"
+DISTRO_FEATURES = "xattr"
 
 #############################################################################
 # TOOLCHAIN
diff --git a/conf/distro/micro.conf b/conf/distro/micro.conf
index b1f8f1e..bb417b1 100644
--- a/conf/distro/micro.conf
+++ b/conf/distro/micro.conf
@@ -19,7 +19,7 @@ DISTRO_VERSION = "${SRCDATE}"
 # DISTRO FEATURE SELECTION
 #############################################################################
 # No features selected
-DISTRO_FEATURES = "eabi"
+DISTRO_FEATURES += "eabi"
 
 #############################################################################
 # LIBRARY NAMES
-- 
1.7.0.4

[PATCH] minimal-uclibc: add xattr to distro features to fix build failure of libcap2

[Petr Štetiar]

cap_file.c:8:23: fatal error: sys/xattr.h: No such file or directory

Signed-off-by: Petr Štetiar <ynezz@true.cz>
---
 conf/distro/minimal-uclibc.conf |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/conf/distro/minimal-uclibc.conf b/conf/distro/minimal-uclibc.conf
index bc9615b..ca4253a 100644
--- a/conf/distro/minimal-uclibc.conf
+++ b/conf/distro/minimal-uclibc.conf
@@ -35,7 +35,7 @@ require conf/distro/minimal.conf
 # FEATURE SELECTION
 #############################################################################
 # We want images supporting the following features (for task-base)
-DISTRO_FEATURES = "nfs smbfs wifi ppp alsa ext2 vfat pcmcia usbgadget usbhost pci"
+DISTRO_FEATURES = "nfs smbfs wifi ppp alsa ext2 vfat pcmcia usbgadget usbhost pci xattr"
 # Following feature is for ARM and E500 based machines
 DISTRO_FEATURES += "eabi"
 # pam is needed on uclibc if using shadow 
-- 
1.7.0.4

Re: [PATCH] minimal-uclibc: add xattr to distro features to fix build failure of libcap2

[Petr Štetiar]

Petr Štetiar <ynezz@true.cz> [2011-02-26 18:44:14]:

> cap_file.c:8:23: fatal error: sys/xattr.h: No such file or directory
> 
> Signed-off-by: Petr Štetiar <ynezz@true.cz>

Sent this one accidentaly twice, sorry.

-- ynezz

[PATCH 2/2] minimal-uclibc: add xattr to distro features to fix build failure of libcap2

[Petr Štetiar]

cap_file.c:8:23: fatal error: sys/xattr.h: No such file or directory

Signed-off-by: Petr Štetiar <ynezz@true.cz>
---
 conf/distro/minimal-uclibc.conf |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/conf/distro/minimal-uclibc.conf b/conf/distro/minimal-uclibc.conf
index bc9615b..ca4253a 100644
--- a/conf/distro/minimal-uclibc.conf
+++ b/conf/distro/minimal-uclibc.conf
@@ -35,7 +35,7 @@ require conf/distro/minimal.conf
 # FEATURE SELECTION
 #############################################################################
 # We want images supporting the following features (for task-base)
-DISTRO_FEATURES = "nfs smbfs wifi ppp alsa ext2 vfat pcmcia usbgadget usbhost pci"
+DISTRO_FEATURES = "nfs smbfs wifi ppp alsa ext2 vfat pcmcia usbgadget usbhost pci xattr"
 # Following feature is for ARM and E500 based machines
 DISTRO_FEATURES += "eabi"
 # pam is needed on uclibc if using shadow 
-- 
1.7.0.4

Re: [PATCH 2/2] minimal-uclibc: add xattr to distro features to fix build failure of libcap2

[Khem Raj]

On Sat, Feb 26, 2011 at 9:44 AM, Petr Štetiar <ynezz@true.cz> wrote:
> cap_file.c:8:23: fatal error: sys/xattr.h: No such file or directory
>
> Signed-off-by: Petr Štetiar <ynezz@true.cz>

Acked-by: Khem Raj <raj.khem@gmail.com>
> ---
>  conf/distro/minimal-uclibc.conf |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/conf/distro/minimal-uclibc.conf b/conf/distro/minimal-uclibc.conf
> index bc9615b..ca4253a 100644
> --- a/conf/distro/minimal-uclibc.conf
> +++ b/conf/distro/minimal-uclibc.conf
> @@ -35,7 +35,7 @@ require conf/distro/minimal.conf
>  # FEATURE SELECTION
>  #############################################################################
>  # We want images supporting the following features (for task-base)
> -DISTRO_FEATURES = "nfs smbfs wifi ppp alsa ext2 vfat pcmcia usbgadget usbhost pci"
> +DISTRO_FEATURES = "nfs smbfs wifi ppp alsa ext2 vfat pcmcia usbgadget usbhost pci xattr"
>  # Following feature is for ARM and E500 based machines
>  DISTRO_FEATURES += "eabi"
>  # pam is needed on uclibc if using shadow
> --
> 1.7.0.4
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Re: [PATCH 1/2] micro-uclibc: add xattr to distro features to fix build failure of libcap2

[Khem Raj]

On Sat, Feb 26, 2011 at 9:44 AM, Petr Štetiar <ynezz@true.cz> wrote:
> cap_file.c:8:23: fatal error: sys/xattr.h: No such file or directory
>
> Signed-off-by: Petr Štetiar <ynezz@true.cz>


looks good although I dont know if enabling this is intended as micro
should be small

> ---
>  conf/distro/micro-uclibc.conf |    1 +
>  conf/distro/micro.conf        |    2 +-
>  2 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/conf/distro/micro-uclibc.conf b/conf/distro/micro-uclibc.conf
> index 85ea9b3..55b4ebd 100644
> --- a/conf/distro/micro-uclibc.conf
> +++ b/conf/distro/micro-uclibc.conf
> @@ -12,6 +12,7 @@
>  #############################################################################
>
>  DISTRO_NAME = "micro-uclibc"
> +DISTRO_FEATURES = "xattr"
>
>  #############################################################################
>  # TOOLCHAIN
> diff --git a/conf/distro/micro.conf b/conf/distro/micro.conf
> index b1f8f1e..bb417b1 100644
> --- a/conf/distro/micro.conf
> +++ b/conf/distro/micro.conf
> @@ -19,7 +19,7 @@ DISTRO_VERSION = "${SRCDATE}"
>  # DISTRO FEATURE SELECTION
>  #############################################################################
>  # No features selected
> -DISTRO_FEATURES = "eabi"
> +DISTRO_FEATURES += "eabi"
>
>  #############################################################################
>  # LIBRARY NAMES
> --
> 1.7.0.4
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Re: [PATCH 1/2] micro-uclibc: add xattr to distro features to fix build failure of libcap2

[Petr Štetiar]

Khem Raj <raj.khem@gmail.com> [2011-02-26 10:06:31]:

> On Sat, Feb 26, 2011 at 9:44 AM, Petr Štetiar <ynezz@true.cz> wrote:
> > cap_file.c:8:23: fatal error: sys/xattr.h: No such file or directory
> >
> > Signed-off-by: Petr Štetiar <ynezz@true.cz>
> 
> looks good although I dont know if enabling this is intended as micro
> should be small

I see and agree, but what do you propose as the way to fix the libcap2 build
failure with uclibc? Thanks.

-- ynezz

Re: [PATCH 1/2] micro-uclibc: add xattr to distro features to fix build failure of libcap2

[Phil Blundell]

On Sat, 2011-02-26 at 18:44 +0100, Petr Štetiar wrote:
> cap_file.c:8:23: fatal error: sys/xattr.h: No such file or directory

Are you really using POSIX.1e caps on micro?  If yes then I guess this
is fine, though it would be interesting to know what the code size
impact is.

p.

Re: [PATCH 1/2] micro-uclibc: add xattr to distro features to fix build failure of libcap2

[Petr Štetiar]

Phil Blundell <philb@gnu.org> [2011-02-26 18:39:38]:

> On Sat, 2011-02-26 at 18:44 +0100, Petr Štetiar wrote:
> > cap_file.c:8:23: fatal error: sys/xattr.h: No such file or directory
> 
> Are you really using POSIX.1e caps on micro?  If yes then I guess this
> is fine, though it would be interesting to know what the code size
> impact is.

I don't use micro at all, I've just added it as another test target for
2011.03 release and the build of console-image failed on libcap2 so I've tried
to fix it. That's all behind it.

-- ynezz

Re: [PATCH 1/2] micro-uclibc: add xattr to distro features to fix build failure of libcap2

[Phil Blundell]

On Sat, 2011-02-26 at 19:59 +0100, Petr Štetiar wrote:
> Phil Blundell <philb@gnu.org> [2011-02-26 18:39:38]:
> 
> > On Sat, 2011-02-26 at 18:44 +0100, Petr Štetiar wrote:
> > > cap_file.c:8:23: fatal error: sys/xattr.h: No such file or directory
> > 
> > Are you really using POSIX.1e caps on micro?  If yes then I guess this
> > is fine, though it would be interesting to know what the code size
> > impact is.
> 
> I don't use micro at all, I've just added it as another test target for
> 2011.03 release and the build of console-image failed on libcap2 so I've tried
> to fix it. That's all behind it.

Which package in console-image depends on libcap2?  It might be worth
exploring whether there is a way to avoid that dependency.

It's worth noting that being able to build console-image is not really a
primary goal for micro.  It'd be nice if it worked but I don't want to
add any extra binary bloat in the base system purely for the sake of
getting a clean console-image build that may end up never being used.

So, absent a compelling usage scenario for libcap2 on micro, please
don't commit this patch.

p.

Re: [PATCH 1/2] micro-uclibc: add xattr to distro features to fix build failure of libcap2

[Petr Štetiar]

Phil Blundell <philb@gnu.org> [2011-02-26 19:20:41]:

> So, absent a compelling usage scenario for libcap2 on micro, please
> don't commit this patch.

Ok, please revert it then and sorry for the noise...

-- ynezz

Re: [PATCH 1/2] micro-uclibc: add xattr to distro features to fix build failure of libcap2

[Tom Rini]

On 02/26/2011 12:20 PM, Phil Blundell wrote:
> On Sat, 2011-02-26 at 19:59 +0100, Petr Štetiar wrote:
>> Phil Blundell<philb@gnu.org>  [2011-02-26 18:39:38]:
>>
>>> On Sat, 2011-02-26 at 18:44 +0100, Petr Štetiar wrote:
>>>> cap_file.c:8:23: fatal error: sys/xattr.h: No such file or directory
>>>
>>> Are you really using POSIX.1e caps on micro?  If yes then I guess this
>>> is fine, though it would be interesting to know what the code size
>>> impact is.
>>
>> I don't use micro at all, I've just added it as another test target for
>> 2011.03 release and the build of console-image failed on libcap2 so I've tried
>> to fix it. That's all behind it.
>
> Which package in console-image depends on libcap2?  It might be worth
> exploring whether there is a way to avoid that dependency.

avahi brings in libcap2 now.  I suppose it's possible to make that xattr 
DISTRO_FEATURE spell that part out and update all of the distros.  But 
maybe that can wait until post release?

-- 
Tom Rini
Mentor Graphics Corporation

Re: [PATCH 1/2] micro-uclibc: add xattr to distro features to fix build failure of libcap2

[Phil Blundell]

On Sat, 2011-02-26 at 15:26 -0700, Tom Rini wrote:
> On 02/26/2011 12:20 PM, Phil Blundell wrote:
> > Which package in console-image depends on libcap2?  It might be worth
> > exploring whether there is a way to avoid that dependency.
> 
> avahi brings in libcap2 now.  I suppose it's possible to make that xattr 
> DISTRO_FEATURE spell that part out and update all of the distros.  But 
> maybe that can wait until post release?

Sure, waiting until post release for that sounds fine to me.  Though
judging from the recent checkins it seems as though most of the DISTROs
are declaring xattr now in any case.

Unless you have a particular objection, I'm going to revert Petr
Štetiar's original micro-uclibc.conf patch and just take the view of
"don't do that, then" for the resulting console-image failure.  If it
turns out that someone actually wants console-image on micro then I
guess we can apply some distro-specific hack to suppress the avahi
behaviour.

p.