From: Jarkko Nikula <jhnikula@gmail.com>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>
Subject: Re: [PATCH resend] omap: Fix linker error in drivers/video/omap/lcd_2430sdp.c
Date: Mon, 28 Feb 2011 16:47:15 +0200 [thread overview]
Message-ID: <20110228164715.e34a965e.jhnikula@gmail.com> (raw)
In-Reply-To: <20110224212644.GN20560@atomide.com>
On Thu, 24 Feb 2011 13:26:44 -0800
Tony Lindgren <tony@atomide.com> wrote:
> We should avoid selecting driver related things, otherwise we can never
> build a tiny kernel with initramfs with everything as modules.
>
> Can you see if adding depends to the LCD panel option does the trick
> instead?
>
True and as lcd_2430sdp.c is not compiled without CONFIG_FB_OMAP a hack
below should work a bit better.
What would you think Tomi?
diff --git a/drivers/video/omap/Kconfig b/drivers/video/omap/Kconfig
index 083c8fe..c981249 100644
--- a/drivers/video/omap/Kconfig
+++ b/drivers/video/omap/Kconfig
@@ -5,6 +5,7 @@ config FB_OMAP
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
+ select TWL4030_CORE if MACH_OMAP_2430SDP
help
Frame buffer driver for OMAP based boards.
--
Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: jhnikula@gmail.com (Jarkko Nikula)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH resend] omap: Fix linker error in drivers/video/omap/lcd_2430sdp.c
Date: Mon, 28 Feb 2011 16:47:15 +0200 [thread overview]
Message-ID: <20110228164715.e34a965e.jhnikula@gmail.com> (raw)
In-Reply-To: <20110224212644.GN20560@atomide.com>
On Thu, 24 Feb 2011 13:26:44 -0800
Tony Lindgren <tony@atomide.com> wrote:
> We should avoid selecting driver related things, otherwise we can never
> build a tiny kernel with initramfs with everything as modules.
>
> Can you see if adding depends to the LCD panel option does the trick
> instead?
>
True and as lcd_2430sdp.c is not compiled without CONFIG_FB_OMAP a hack
below should work a bit better.
What would you think Tomi?
diff --git a/drivers/video/omap/Kconfig b/drivers/video/omap/Kconfig
index 083c8fe..c981249 100644
--- a/drivers/video/omap/Kconfig
+++ b/drivers/video/omap/Kconfig
@@ -5,6 +5,7 @@ config FB_OMAP
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
+ select TWL4030_CORE if MACH_OMAP_2430SDP
help
Frame buffer driver for OMAP based boards.
--
Jarkko
next prev parent reply other threads:[~2011-02-28 14:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-20 9:17 [PATCH] omap: Fix linker error in drivers/video/omap/lcd_2430sdp.c Jarkko Nikula
2011-02-20 20:04 ` [PATCH resend] " Jarkko Nikula
2011-02-20 20:04 ` Jarkko Nikula
2011-02-24 21:26 ` Tony Lindgren
2011-02-24 21:26 ` Tony Lindgren
2011-02-28 14:47 ` Jarkko Nikula [this message]
2011-02-28 14:47 ` Jarkko Nikula
2011-02-28 15:09 ` Tomi Valkeinen
2011-02-28 15:09 ` Tomi Valkeinen
2011-03-01 1:39 ` Tony Lindgren
2011-03-01 1:39 ` Tony Lindgren
2011-03-01 6:29 ` Tomi Valkeinen
2011-03-01 6:29 ` Tomi Valkeinen
2011-03-02 17:36 ` Tony Lindgren
2011-03-02 17:36 ` Tony Lindgren
2011-03-01 8:40 ` [PATCH] omapfb: " Jarkko Nikula
2011-03-01 8:40 ` Jarkko Nikula
2011-03-02 7:58 ` [PATCH] omapfb: Fix linker error in Tomi Valkeinen
2011-03-02 7:58 ` [PATCH] omapfb: Fix linker error in drivers/video/omap/lcd_2430sdp.c Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110228164715.e34a965e.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.