From: hjk@hansjkoch.de (Hans J. Koch)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 1/1] PRUSS UIO driver support
Date: Tue, 1 Mar 2011 23:22:29 +0100 [thread overview]
Message-ID: <20110301222229.GE20497@local> (raw)
In-Reply-To: <alpine.LFD.2.00.1103012238360.2701@localhost6.localdomain6>
On Tue, Mar 01, 2011 at 10:45:25PM +0100, Thomas Gleixner wrote:
>
> > +
> > + spin_lock_init(&lock);
>
> Sigh. DEFINE_SPINLOCK(lock); already initializes the lock.
>
> It's not the purpose of a review to tell you what you need to change
> mechanically. Reviewers hint to a correct solution and you are
> supposed to lookup what that solution means and act accordingly. If
> you do not understand the hint or its implications please ask _before_
> sending a new patch set.
Correct. But I'm to blame here, too, since I suggested the wrong solution.
Sorry for that, Gangadhar!
Thanks,
Hans
WARNING: multiple messages have this Message-ID (diff)
From: "Hans J. Koch" <hjk@hansjkoch.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Pratheesh Gangadhar <pratheesh@ti.com>,
linux-kernel@vger.kernel.org, hjk@hansjkoch.de, gregkh@suse.de,
sshtylyov@mvista.com, arnd@arndb.de, amit.chatterjee@ti.com,
davinci-linux-open-source@linux.davincidsp.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 1/1] PRUSS UIO driver support
Date: Tue, 1 Mar 2011 23:22:29 +0100 [thread overview]
Message-ID: <20110301222229.GE20497@local> (raw)
In-Reply-To: <alpine.LFD.2.00.1103012238360.2701@localhost6.localdomain6>
On Tue, Mar 01, 2011 at 10:45:25PM +0100, Thomas Gleixner wrote:
>
> > +
> > + spin_lock_init(&lock);
>
> Sigh. DEFINE_SPINLOCK(lock); already initializes the lock.
>
> It's not the purpose of a review to tell you what you need to change
> mechanically. Reviewers hint to a correct solution and you are
> supposed to lookup what that solution means and act accordingly. If
> you do not understand the hint or its implications please ask _before_
> sending a new patch set.
Correct. But I'm to blame here, too, since I suggested the wrong solution.
Sorry for that, Gangadhar!
Thanks,
Hans
next prev parent reply other threads:[~2011-03-01 22:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 21:28 [PATCH v7 0/1] Add PRUSS UIO driver support Pratheesh Gangadhar
2011-03-01 21:28 ` Pratheesh Gangadhar
2011-03-01 21:28 ` [PATCH v7 1/1] " Pratheesh Gangadhar
2011-03-01 21:28 ` Pratheesh Gangadhar
2011-03-01 21:45 ` Thomas Gleixner
2011-03-01 21:45 ` Thomas Gleixner
2011-03-01 22:22 ` Hans J. Koch [this message]
2011-03-01 22:22 ` Hans J. Koch
2011-03-02 8:47 ` TK, Pratheesh Gangadhar
2011-03-02 8:47 ` TK, Pratheesh Gangadhar
2011-03-02 9:27 ` Thomas Gleixner
2011-03-02 9:27 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110301222229.GE20497@local \
--to=hjk@hansjkoch.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.