From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 1/1] PRUSS UIO driver support
Date: Wed, 2 Mar 2011 21:23:37 +0100 [thread overview]
Message-ID: <201103022123.38050.arnd@arndb.de> (raw)
In-Reply-To: <20110302200956.GB23818@local>
On Wednesday 02 March 2011 21:09:56 Hans J. Koch wrote:
> > +static struct uio_info *info;
> > +static dma_addr_t sram_paddr, ddr_paddr;
> > +static void *prussio_vaddr, *sram_vaddr, *ddr_vaddr;
>
> So the correct thing would be
>
> static void __iomem *prussio_vaddr;
> static void *sram_vaddr, *ddr_vaddr;
I also commented that it should not be a global variable at
all, but a dynamic data structure referenced from the device.
Not important, but Pratheesh said he'd change it. If it stays
a global variable, I'd at least expect an explanation why
the static variable is considered better in this case.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: "Hans J. Koch" <hjk@hansjkoch.de>
Cc: Pratheesh Gangadhar <pratheesh@ti.com>,
linux-kernel@vger.kernel.org, gregkh@suse.de, tglx@linutronix.de,
sshtylyov@mvista.com, amit.chatterjee@ti.com,
davinci-linux-open-source@linux.davincidsp.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v8 1/1] PRUSS UIO driver support
Date: Wed, 2 Mar 2011 21:23:37 +0100 [thread overview]
Message-ID: <201103022123.38050.arnd@arndb.de> (raw)
In-Reply-To: <20110302200956.GB23818@local>
On Wednesday 02 March 2011 21:09:56 Hans J. Koch wrote:
> > +static struct uio_info *info;
> > +static dma_addr_t sram_paddr, ddr_paddr;
> > +static void *prussio_vaddr, *sram_vaddr, *ddr_vaddr;
>
> So the correct thing would be
>
> static void __iomem *prussio_vaddr;
> static void *sram_vaddr, *ddr_vaddr;
I also commented that it should not be a global variable at
all, but a dynamic data structure referenced from the device.
Not important, but Pratheesh said he'd change it. If it stays
a global variable, I'd at least expect an explanation why
the static variable is considered better in this case.
Arnd
next prev parent reply other threads:[~2011-03-02 20:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 11:38 [PATCH v8 0/1] Add PRUSS UIO driver support Pratheesh Gangadhar
2011-03-02 11:38 ` Pratheesh Gangadhar
2011-03-02 11:38 ` [PATCH v8 1/1] " Pratheesh Gangadhar
2011-03-02 11:38 ` Pratheesh Gangadhar
2011-03-02 13:22 ` Arnd Bergmann
2011-03-02 13:22 ` Arnd Bergmann
2011-03-03 9:24 ` TK, Pratheesh Gangadhar
2011-03-03 9:24 ` TK, Pratheesh Gangadhar
2011-03-02 13:23 ` Thomas Gleixner
2011-03-02 13:23 ` Thomas Gleixner
2011-03-02 20:09 ` Hans J. Koch
2011-03-02 20:09 ` Hans J. Koch
2011-03-02 20:23 ` Arnd Bergmann [this message]
2011-03-02 20:23 ` Arnd Bergmann
2011-03-02 20:56 ` Thomas Gleixner
2011-03-02 20:56 ` Thomas Gleixner
2011-03-03 9:29 ` TK, Pratheesh Gangadhar
2011-03-03 9:29 ` TK, Pratheesh Gangadhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103022123.38050.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.